mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 13:50:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix _hRecThread,_hPlayThread RTC_DCHECK reverse bug.

Browse source 
Bug: webrtc:6779
Change-Id: I030ec010c39ba3755f70b16a64a5163d0857c256
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228721
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34793}
This commit is contained in:
chengqian 2021-08-14 16:50:08 +08:00 committed by WebRTC LUCI CQ
parent f135800b5c
commit 0347a08ad3
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
AUTHORS
View file

@ -25,6 +25,7 @@ Ben Strong <bstrong@gmail.com>
Berthold Herrmann <bertholdherrmann08@googlemail.com> Berthold Herrmann <bertholdherrmann08@googlemail.com>
Bob Withers <bwit@pobox.com> Bob Withers <bwit@pobox.com>
Bridger Maxwell <bridgeyman@gmail.com> Bridger Maxwell <bridgeyman@gmail.com>
Cheng Qian <chengqian1521@qq.com>
Christophe Dumez <ch.dumez@samsung.com> Christophe Dumez <ch.dumez@samsung.com>
Chris Tserng <tserng@amazon.com> Chris Tserng <tserng@amazon.com>
Cody Barnes <conceptgenesis@gmail.com> Cody Barnes <conceptgenesis@gmail.com>

4
modules/audio_device/win/audio_device_core_win.cc
View file

@ -2355,7 +2355,7 @@ int32_t AudioDeviceWindowsCore::StartRecording() {
} }
} }
RTC_DCHECK(_hRecThread); RTC_DCHECK(_hRecThread == NULL);
_hRecThread = CreateThread(NULL, 0, lpStartAddress, this, 0, NULL); _hRecThread = CreateThread(NULL, 0, lpStartAddress, this, 0, NULL);
if (_hRecThread == NULL) { if (_hRecThread == NULL) {
RTC_LOG(LS_ERROR) << "failed to create the recording thread"; RTC_LOG(LS_ERROR) << "failed to create the recording thread";
@ -2492,7 +2492,7 @@ int32_t AudioDeviceWindowsCore::StartPlayout() {
MutexLock lockScoped(&mutex_); MutexLock lockScoped(&mutex_);
// Create thread which will drive the rendering. // Create thread which will drive the rendering.
RTC_DCHECK(_hPlayThread); RTC_DCHECK(_hPlayThread == NULL);
_hPlayThread = CreateThread(NULL, 0, WSAPIRenderThread, this, 0, NULL); _hPlayThread = CreateThread(NULL, 0, WSAPIRenderThread, this, 0, NULL);
if (_hPlayThread == NULL) { if (_hPlayThread == NULL) {
RTC_LOG(LS_ERROR) << "failed to create the playout thread"; RTC_LOG(LS_ERROR) << "failed to create the playout thread";