mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 13:50:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove unused RateControlSettings::TriggerProbeOnMaxAllocatedBitrateChange

Browse source 
The flag has been default true for a long period of time.(longer than https://webrtc-review.googlesource.com/c/src/+/148581)
Reference to it was removed in https://webrtc-review.googlesource.com/c/src/+/282860

Bug: webrtc:14392
Change-Id: I08aab062acc27d39b41c9d96571ed2ce058f2eec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282862
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38599}
This commit is contained in:
Per Kjellander 2022-11-09 14:03:16 +01:00 committed by WebRTC LUCI CQ
parent 7ca522dcec
commit 0dbee62eb9
3 changed files with 0 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
rtc_base/experiments/rate_control_settings.cc
View file

@ -68,7 +68,6 @@ std::unique_ptr<StructParametersParser> VideoRateControlConfig::Parser() {
"vp8_min_pixels", &vp8_min_pixels, // "vp8_min_pixels", &vp8_min_pixels, //
"trust_vp8", &trust_vp8, // "trust_vp8", &trust_vp8, //
"trust_vp9", &trust_vp9, // "trust_vp9", &trust_vp9, //
"probe_max_allocation", &probe_max_allocation, //
"bitrate_adjuster", &bitrate_adjuster, // "bitrate_adjuster", &bitrate_adjuster, //
"adjuster_use_headroom", &adjuster_use_headroom, // "adjuster_use_headroom", &adjuster_use_headroom, //
"vp8_s0_boost", &vp8_s0_boost, // "vp8_s0_boost", &vp8_s0_boost, //
@ -173,10 +172,6 @@ bool RateControlSettings::Vp8BaseHeavyTl3RateAllocation() const {
return video_config_.vp8_base_heavy_tl3_alloc; return video_config_.vp8_base_heavy_tl3_alloc;
} }
bool RateControlSettings::TriggerProbeOnMaxAllocatedBitrateChange() const {
return video_config_.probe_max_allocation;
}
bool RateControlSettings::UseEncoderBitrateAdjuster() const { bool RateControlSettings::UseEncoderBitrateAdjuster() const {
return video_config_.bitrate_adjuster; return video_config_.bitrate_adjuster;
} }

2
rtc_base/experiments/rate_control_settings.h
View file

@ -38,7 +38,6 @@ struct VideoRateControlConfig {
absl::optional<int> vp8_min_pixels; absl::optional<int> vp8_min_pixels;
bool trust_vp8 = true; bool trust_vp8 = true;
bool trust_vp9 = true; bool trust_vp9 = true;
bool probe_max_allocation = true;
bool bitrate_adjuster = true; bool bitrate_adjuster = true;
bool adjuster_use_headroom = true; bool adjuster_use_headroom = true;
bool vp8_s0_boost = false; bool vp8_s0_boost = false;
@ -79,7 +78,6 @@ class RateControlSettings final {
bool Vp8BaseHeavyTl3RateAllocation() const; bool Vp8BaseHeavyTl3RateAllocation() const;
bool TriggerProbeOnMaxAllocatedBitrateChange() const;
bool UseEncoderBitrateAdjuster() const; bool UseEncoderBitrateAdjuster() const;
bool BitrateAdjusterCanUseNetworkHeadroom() const; bool BitrateAdjusterCanUseNetworkHeadroom() const;

10
rtc_base/experiments/rate_control_settings_unittest.cc
View file

@ -172,16 +172,6 @@ TEST(RateControlSettingsTest,
EXPECT_FALSE(settings_after.Vp8BaseHeavyTl3RateAllocation()); EXPECT_FALSE(settings_after.Vp8BaseHeavyTl3RateAllocation());
} }
TEST(RateControlSettingsTest, TriggerProbeOnMaxAllocatedBitrateChange) {
EXPECT_TRUE(RateControlSettings::ParseFromFieldTrials()
.TriggerProbeOnMaxAllocatedBitrateChange());
test::ScopedFieldTrials field_trials(
"WebRTC-VideoRateControl/probe_max_allocation:0/");
EXPECT_FALSE(RateControlSettings::ParseFromFieldTrials()
.TriggerProbeOnMaxAllocatedBitrateChange());
}
TEST(RateControlSettingsTest, UseEncoderBitrateAdjuster) { TEST(RateControlSettingsTest, UseEncoderBitrateAdjuster) {
// Should be on by default. // Should be on by default.
EXPECT_TRUE( EXPECT_TRUE(