mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 22:00:47 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

OnLossNotification() receives references

Browse source 
A typo in a previous CL made OnLossNotification() accept its
single argument as a const-value, rather than a const-reference.

Bug: webrtc:10501
Change-Id: I5e6f9c79f15205b75ec90a53d3fccf3dd9927e33
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133343
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27659}
This commit is contained in:
Elad Alon 2019-04-17 12:48:06 +02:00 committed by Commit Bot
parent 491d29448e
commit 123ee9be8f
7 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
api/video_codecs/vp8_frame_buffer_controller.h
View file

@ -140,7 +140,7 @@ class Vp8FrameBufferController {
// Called when a loss notification is received. // Called when a loss notification is received.
virtual void OnLossNotification( virtual void OnLossNotification(
const VideoEncoder::LossNotification loss_notification) = 0; const VideoEncoder::LossNotification& loss_notification) = 0;
}; };
// Interface for a factory of Vp8FrameBufferController instances. // Interface for a factory of Vp8FrameBufferController instances.

2
api/video_codecs/vp8_temporal_layers.cc
View file

@ -89,7 +89,7 @@ void Vp8TemporalLayers::OnRttUpdate(int64_t rtt_ms) {
} }
void Vp8TemporalLayers::OnLossNotification( void Vp8TemporalLayers::OnLossNotification(
const VideoEncoder::LossNotification loss_notification) { const VideoEncoder::LossNotification& loss_notification) {
for (auto& controller : controllers_) { for (auto& controller : controllers_) {
controller->OnLossNotification(loss_notification); controller->OnLossNotification(loss_notification);
} }

2
api/video_codecs/vp8_temporal_layers.h
View file

@ -62,7 +62,7 @@ class Vp8TemporalLayers final : public Vp8FrameBufferController {
void OnRttUpdate(int64_t rtt_ms) override; void OnRttUpdate(int64_t rtt_ms) override;
void OnLossNotification( void OnLossNotification(
const VideoEncoder::LossNotification loss_notification) override; const VideoEncoder::LossNotification& loss_notification) override;
private: private:
std::vector<std::unique_ptr<Vp8FrameBufferController>> controllers_; std::vector<std::unique_ptr<Vp8FrameBufferController>> controllers_;

2
modules/video_coding/codecs/vp8/default_temporal_layers.cc
View file

@ -552,7 +552,7 @@ void DefaultTemporalLayers::OnPacketLossRateUpdate(float packet_loss_rate) {}
void DefaultTemporalLayers::OnRttUpdate(int64_t rtt_ms) {} void DefaultTemporalLayers::OnRttUpdate(int64_t rtt_ms) {}
void DefaultTemporalLayers::OnLossNotification( void DefaultTemporalLayers::OnLossNotification(
const VideoEncoder::LossNotification loss_notification) {} const VideoEncoder::LossNotification& loss_notification) {}
TemplateStructure DefaultTemporalLayers::GetTemplateStructure( TemplateStructure DefaultTemporalLayers::GetTemplateStructure(
int num_layers) const { int num_layers) const {

2
modules/video_coding/codecs/vp8/default_temporal_layers.h
View file

@ -64,7 +64,7 @@ class DefaultTemporalLayers final : public Vp8FrameBufferController {
void OnRttUpdate(int64_t rtt_ms) override; void OnRttUpdate(int64_t rtt_ms) override;
void OnLossNotification( void OnLossNotification(
const VideoEncoder::LossNotification loss_notification) override; const VideoEncoder::LossNotification& loss_notification) override;
private: private:
struct DependencyInfo { struct DependencyInfo {

2
modules/video_coding/codecs/vp8/screenshare_layers.cc
View file

@ -394,7 +394,7 @@ void ScreenshareLayers::OnPacketLossRateUpdate(float packet_loss_rate) {}
void ScreenshareLayers::OnRttUpdate(int64_t rtt_ms) {} void ScreenshareLayers::OnRttUpdate(int64_t rtt_ms) {}
void ScreenshareLayers::OnLossNotification( void ScreenshareLayers::OnLossNotification(
const VideoEncoder::LossNotification loss_notification) {} const VideoEncoder::LossNotification& loss_notification) {}
TemplateStructure ScreenshareLayers::GetTemplateStructure( TemplateStructure ScreenshareLayers::GetTemplateStructure(
int num_layers) const { int num_layers) const {

2
modules/video_coding/codecs/vp8/screenshare_layers.h
View file

@ -68,7 +68,7 @@ class ScreenshareLayers final : public Vp8FrameBufferController {
void OnRttUpdate(int64_t rtt_ms) override; void OnRttUpdate(int64_t rtt_ms) override;
void OnLossNotification( void OnLossNotification(
const VideoEncoder::LossNotification loss_notification) override; const VideoEncoder::LossNotification& loss_notification) override;
private: private:
enum class TemporalLayerState : int { kDrop, kTl0, kTl1, kTl1Sync }; enum class TemporalLayerState : int { kDrop, kTl0, kTl1, kTl1Sync };