From 154a262b617649b36fe5280d3b1fb0c568ceb78e Mon Sep 17 00:00:00 2001 From: Aaron Golden Date: Tue, 27 Nov 2018 11:58:47 -0800 Subject: [PATCH] Don't clear self.videoFrame when setting up OpenGL in the EAGL video view. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It makes sense to clean up self.videoFrame in -teardownGL, but if we happen to have a frame available in -setupGL then it's OK to keep using that frame. Clearing the frame here frequently causes the screen view to go black for a moment when the app returns from the background. Bug: webrtc:10059 Change-Id: Ic62f872a0a582c807cee1e30ea9bb32f31ada341 Reviewed-on: https://webrtc-review.googlesource.com/c/112213 Reviewed-by: Kári Helgason Commit-Queue: Kári Helgason Cr-Commit-Position: refs/heads/master@{#25816} --- sdk/objc/components/renderer/opengl/RTCEAGLVideoView.m | 1 - 1 file changed, 1 deletion(-) diff --git a/sdk/objc/components/renderer/opengl/RTCEAGLVideoView.m b/sdk/objc/components/renderer/opengl/RTCEAGLVideoView.m index 662e4c61ee..19b3dcc004 100644 --- a/sdk/objc/components/renderer/opengl/RTCEAGLVideoView.m +++ b/sdk/objc/components/renderer/opengl/RTCEAGLVideoView.m @@ -251,7 +251,6 @@ } - (void)setupGL { - self.videoFrame = nil; [self ensureGLContext]; glDisable(GL_DITHER); _timer.isPaused = NO;