From 15e46aa35856e36228de98872481d8858f30c5bf Mon Sep 17 00:00:00 2001 From: Florent Castelli Date: Wed, 27 Mar 2024 10:04:14 +0000 Subject: [PATCH] pc: Increase timeout for EndToEndCallWithSctpDataChannelFullBuffer The timeout was not long enough in debug mode on slower machines. Bug: chromium:40072842 Change-Id: Id82399cd7211abf5dd2e03ffa2ee4bd49f8c492f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/344680 Commit-Queue: Florent Castelli Auto-Submit: Florent Castelli Reviewed-by: Victor Boivie Commit-Queue: Victor Boivie Cr-Commit-Position: refs/heads/main@{#41971} --- pc/data_channel_integrationtest.cc | 4 +++- pc/test/integration_test_helpers.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/pc/data_channel_integrationtest.cc b/pc/data_channel_integrationtest.cc index 9afda05090..95661d73eb 100644 --- a/pc/data_channel_integrationtest.cc +++ b/pc/data_channel_integrationtest.cc @@ -295,8 +295,10 @@ TEST_P(DataChannelIntegrationTest, EndToEndCallWithSctpDataChannelFullBuffer) { DataChannelInterface::DataState::kClosing, DataChannelInterface::DataState::kClosed}; + // Debug data channels are very slow, use a long timeout for those slow, + // heavily parallelized runs. EXPECT_EQ_WAIT(DataChannelInterface::DataState::kClosed, - caller()->data_observer()->state(), kDefaultTimeout); + caller()->data_observer()->state(), kLongTimeout); EXPECT_THAT(caller()->data_observer()->states(), ::testing::ElementsAreArray(expected_states)); diff --git a/pc/test/integration_test_helpers.h b/pc/test/integration_test_helpers.h index 7b3f11905d..e1de1b3a27 100644 --- a/pc/test/integration_test_helpers.h +++ b/pc/test/integration_test_helpers.h @@ -141,6 +141,7 @@ using ::testing::Values; using RTCConfiguration = PeerConnectionInterface::RTCConfiguration; static const int kDefaultTimeout = 10000; +static const int kLongTimeout = 60000; static const int kMaxWaitForStatsMs = 3000; static const int kMaxWaitForActivationMs = 5000; static const int kMaxWaitForFramesMs = 10000;