mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-12 21:30:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Apply bugprone-stringview-nullptr.

Browse source 
Bug: None
Change-Id: Id6372a8a94f512fede50cdb36dc3ae378f271cee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258139
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36493}
This commit is contained in:
Mirko Bonadei 2022-04-07 17:27:15 +02:00 committed by WebRTC LUCI CQ
parent 3fcab3985c
commit 23e4654303
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pc/rtc_stats_collector.cc
View file

@ -280,7 +280,7 @@ absl::string_view NetworkTypeToStatsNetworkAdapterType(rtc::AdapterType type) {
break;
}
RTC_DCHECK_NOTREACHED();
return nullptr;
return {};
}
const char* QualityLimitationReasonToRTCQualityLimitationReason(

4
rtc_base/string_to_number_unittest.cc
View file

@ -99,12 +99,12 @@ TYPED_TEST_P(BasicNumberTest, TestInvalidInputs) {
EXPECT_EQ(absl::nullopt, StringToNumber<T>(" -5"));
EXPECT_EQ(absl::nullopt, StringToNumber<T>("5 "));
// Test various types of empty inputs
EXPECT_EQ(absl::nullopt, StringToNumber<T>(nullptr));
EXPECT_EQ(absl::nullopt, StringToNumber<T>({nullptr, 0}));
EXPECT_EQ(absl::nullopt, StringToNumber<T>(""));
EXPECT_EQ(absl::nullopt, StringToNumber<T>(std::string()));
EXPECT_EQ(absl::nullopt, StringToNumber<T>(std::string("")));
EXPECT_EQ(absl::nullopt, StringToNumber<T>(absl::string_view()));
EXPECT_EQ(absl::nullopt, StringToNumber<T>(absl::string_view(nullptr)));
EXPECT_EQ(absl::nullopt, StringToNumber<T>(absl::string_view(nullptr, 0)));
EXPECT_EQ(absl::nullopt, StringToNumber<T>(absl::string_view("")));
// Test strings with embedded nuls.
EXPECT_EQ(absl::nullopt, StringToNumber<T>(absl::string_view(