From 32b6bc455ce06fc7f5b0ed348c14d2024e5bc2cd Mon Sep 17 00:00:00 2001 From: Artem Titov Date: Wed, 8 Sep 2021 13:16:01 +0200 Subject: [PATCH] [PCLF] In SFU emulation mode check that we have only one codec Bug: None Change-Id: I3607159f24529fc05300d850cc4c544978c52413 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231502 Reviewed-by: Mirko Bonadei Commit-Queue: Artem Titov Cr-Commit-Position: refs/heads/main@{#34950} --- test/pc/e2e/peer_connection_quality_test.cc | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/test/pc/e2e/peer_connection_quality_test.cc b/test/pc/e2e/peer_connection_quality_test.cc index 684076cc51..f9a129448f 100644 --- a/test/pc/e2e/peer_connection_quality_test.cc +++ b/test/pc/e2e/peer_connection_quality_test.cc @@ -103,6 +103,21 @@ class FixturePeerConnectionObserver : public MockPeerConnectionObserver { std::function on_connected_callback_; }; +void ValidateP2PSimulcastParams( + const std::vector>& peers) { + for (size_t i = 0; i < peers.size(); ++i) { + Params* p = peers[i]->params(); + for (const VideoConfig& video_config : p->video_configs) { + if (video_config.simulcast_config) { + // When we simulate SFU we support only one video codec. + RTC_CHECK_EQ(p->video_codecs.size(), 1) + << "Only 1 video codec is supported when simulcast is enabled in " + << "at least 1 video config"; + } + } + } +} + } // namespace PeerConnectionE2EQualityTest::PeerConnectionE2EQualityTest( @@ -168,6 +183,7 @@ PeerConnectionE2EQualityTest::PeerHandle* PeerConnectionE2EQualityTest::AddPeer( void PeerConnectionE2EQualityTest::Run(RunParams run_params) { SetDefaultValuesForMissingParams(&run_params, &peer_configurations_); ValidateParams(run_params, peer_configurations_); + ValidateP2PSimulcastParams(peer_configurations_); RTC_CHECK_EQ(peer_configurations_.size(), 2) << "Only peer to peer calls are allowed, please add 2 peers";