mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 05:40:42 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improve warning about deprecation in PRESUBMIT

Browse source 
BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2691933003
Cr-Commit-Position: refs/heads/master@{#16575}
This commit is contained in:
oprypin 2017-02-13 04:13:23 -08:00 committed by Commit bot
parent 5583384048
commit 375b9ac4cc
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
PRESUBMIT.py
View file

@ -117,8 +117,9 @@ def _VerifyNativeApiHeadersListIsValid(input_api, output_api):
api_change_msg = """ api_change_msg = """
You seem to be changing native API header files. Please make sure that you: You seem to be changing native API header files. Please make sure that you:
1. Make compatible changes that don't break existing clients. 1. Make compatible changes that don't break existing clients. Usually
2. Mark the old stuff as deprecated. this is done by keeping the existing method signatures unchanged.
2. Mark the old stuff as deprecated (see RTC_DEPRECATED macro).
3. Create a timeline and plan for when the deprecated stuff will be 3. Create a timeline and plan for when the deprecated stuff will be
removed. (The amount of time we give users to change their code removed. (The amount of time we give users to change their code
should be informed by how much work it is for them. If they just should be informed by how much work it is for them. If they just