mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-18 16:17:50 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

CNAME is missing in simulcast layers.

Browse source 
CNAME is only set on the first simulcast layer.
It should be set on all of the layers.

Bug: webrtc:10383
Change-Id: Iea345a100769f45d09078adb93e51b7702326492
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126541
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Amit Hilbuch <amithi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27134}
This commit is contained in:
Amit Hilbuch 2019-03-08 16:17:21 -08:00 committed by Commit Bot
parent f1c9e21366
commit 38e6c66f4a
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
call/rtp_video_sender.cc
View file

@ -301,10 +301,9 @@ RtpVideoSender::RtpVideoSender(
} }
} }
// TODO(pbos): Should we set CNAME on all RTP modules?
rtp_streams_.front().rtp_rtcp->SetCNAME(rtp_config.c_name.c_str());
for (const RtpStreamSender& stream : rtp_streams_) { for (const RtpStreamSender& stream : rtp_streams_) {
// Simulcast has one module for each layer. Set the CNAME on all modules.
stream.rtp_rtcp->SetCNAME(rtp_config.c_name.c_str());
stream.rtp_rtcp->RegisterRtcpStatisticsCallback(observers.rtcp_stats); stream.rtp_rtcp->RegisterRtcpStatisticsCallback(observers.rtcp_stats);
stream.rtp_rtcp->RegisterSendChannelRtpStatisticsCallback( stream.rtp_rtcp->RegisterSendChannelRtpStatisticsCallback(
observers.rtp_stats); observers.rtp_stats);