From 3fa35172cd1a5cb65f95e94fb053346e55b98f3a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A1ri=20Tristan=20Helgason?= Date: Fri, 9 Sep 2016 08:55:05 +0000 Subject: [PATCH] Filter objc headers in cpplint presubmit check The previous blacklist would filter out all headers under /webrtc/sdk and all headers in objc dirs. This adds a filter for files that end in objc, for example `video_capture_objc.h`. BUG= NOTRY=true R=kjellander@webrtc.org Review URL: https://codereview.webrtc.org/2317023002 . Cr-Commit-Position: refs/heads/master@{#14153} --- PRESUBMIT.py | 1 + 1 file changed, 1 insertion(+) diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 04de7c8def..5101f27e94 100755 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -499,6 +499,7 @@ def _CommonChecks(input_api, output_api): # they do not follow C++ lint rules. black_list = input_api.DEFAULT_BLACK_LIST + ( r".*\bobjc[\\\/].*", + r".*objc\.[hcm]+$", r"webrtc\/build\/ios\/SDK\/.*", ) source_file_filter = lambda x: input_api.FilterSourceFile(x, None, black_list)