mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-12 21:30:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Delete RtcEventLogFactory factory as now unused

Browse source 
Bug: webrtc:10206, webrtc:10284
Change-Id: I34fa780f566b52e375ec625bf0d5d02c505d9912
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143782
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28400}
This commit is contained in:
Danil Chapovalov 2019-06-26 15:49:47 +02:00 committed by Commit Bot
parent 36c8ef625e
commit 4ba04b7740
22 changed files with 15 additions and 87 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
BUILD.gn
View file

@ -392,12 +392,12 @@ if (!build_with_chromium) {
":webrtc_common",
"api:libjingle_peerconnection_api",
"api:transport_api",
"api/rtc_event_log:rtc_event_log_factory",
"audio",
"call",
"common_audio",
"common_video",
"logging:rtc_event_log_api",
"logging:rtc_event_log_impl_base",
"media",
"modules",
"modules/video_capture:video_capture_internal_impl",

3
call/BUILD.gn
View file

@ -377,7 +377,6 @@ if (rtc_include_tests) {
"../api/video:video_rtp_headers",
"../audio",
"../logging:rtc_event_log_api",
"../logging:rtc_event_log_impl_base",
"../modules/audio_device:mock_audio_device",
"../modules/audio_mixer",
"../modules/audio_mixer:audio_mixer_impl",
@ -428,13 +427,13 @@ if (rtc_include_tests) {
"../api:rtc_event_log_output_file",
"../api:simulated_network_api",
"../api/audio_codecs:builtin_audio_encoder_factory",
"../api/rtc_event_log:rtc_event_log_factory",
"../api/task_queue",
"../api/task_queue:default_task_queue_factory",
"../api/video:builtin_video_bitrate_allocator_factory",
"../api/video:video_bitrate_allocation",
"../api/video_codecs:video_codecs_api",
"../logging:rtc_event_log_api",
"../logging:rtc_event_log_impl_base",
"../modules/audio_coding",
"../modules/audio_device",
"../modules/audio_device:audio_device_impl",

2
call/rampup_tests.cc
View file

@ -13,11 +13,11 @@
#include <memory>
#include "absl/memory/memory.h"
#include "api/rtc_event_log/rtc_event_log_factory.h"
#include "api/rtc_event_log_output_file.h"
#include "api/task_queue/default_task_queue_factory.h"
#include "api/task_queue/task_queue_factory.h"
#include "call/fake_network_pipe.h"
#include "logging/rtc_event_log/rtc_event_log_factory.h"
#include "rtc_base/checks.h"
#include "rtc_base/flags.h"
#include "rtc_base/logging.h"

2
examples/BUILD.gn
View file

@ -464,8 +464,8 @@ if (is_ios || (is_mac && target_cpu != "x86")) {
"../api:scoped_refptr",
"../api/audio_codecs:builtin_audio_decoder_factory",
"../api/audio_codecs:builtin_audio_encoder_factory",
"../api/rtc_event_log:rtc_event_log_factory",
"../api/task_queue:default_task_queue_factory",
"../logging:rtc_event_log_impl_base",
"../media:rtc_audio_video",
"../modules/audio_processing",
"../modules/audio_processing:api",

2
examples/androidnativeapi/BUILD.gn
View file

@ -50,8 +50,8 @@ if (is_android) {
":generated_jni",
"../../api:scoped_refptr",
"//api:libjingle_peerconnection_api",
"//api/rtc_event_log:rtc_event_log_factory",
"//api/task_queue:default_task_queue_factory",
"//logging:rtc_event_log_impl_base",
"//media:rtc_audio_video",
"//media:rtc_internal_video_codecs",
"//media:rtc_media_engine_defaults",

2
examples/androidnativeapi/jni/android_call_client.cc
View file

@ -14,9 +14,9 @@
#include "absl/memory/memory.h"
#include "api/peer_connection_interface.h"
#include "api/rtc_event_log/rtc_event_log_factory.h"
#include "api/task_queue/default_task_queue_factory.h"
#include "examples/androidnativeapi/generated_jni/CallClient_jni.h"
#include "logging/rtc_event_log/rtc_event_log_factory.h"
#include "media/engine/internal_decoder_factory.h"
#include "media/engine/internal_encoder_factory.h"
#include "media/engine/webrtc_media_engine.h"

2
examples/objcnativeapi/objc/objc_call_client.mm
View file

@ -21,8 +21,8 @@
#include "api/audio_codecs/builtin_audio_decoder_factory.h"
#include "api/audio_codecs/builtin_audio_encoder_factory.h"
#include "api/peer_connection_interface.h"
#include "api/rtc_event_log/rtc_event_log_factory.h"
#include "api/task_queue/default_task_queue_factory.h"
#include "logging/rtc_event_log/rtc_event_log_factory.h"
#include "media/engine/webrtc_media_engine.h"
#include "modules/audio_processing/include/audio_processing.h"
#include "sdk/objc/native/api/video_capturer.h"

20
logging/BUILD.gn
View file

@ -19,7 +19,6 @@ group("logging") {
deps = [
":rtc_event_audio",
":rtc_event_bwe",
":rtc_event_log_impl_base",
":rtc_event_log_impl_encoder",
":rtc_event_pacing",
":rtc_event_rtp_rtcp",
@ -266,23 +265,6 @@ if (rtc_enable_protobuf) {
}
}
rtc_static_library("rtc_event_log_impl_base") {
# TODO(bugs.webrtc.org/10206): Remove this target when all users switch to
# using target api/rtc_event_log:rtc_event_log_factory directly.
visibility = [ "*" ]
sources = [
"rtc_event_log/rtc_event_log_factory.cc",
"rtc_event_log/rtc_event_log_factory.h",
]
deps = [
"../api/rtc_event_log",
"../api/rtc_event_log:rtc_event_log_factory",
"../api/task_queue:global_task_queue_factory",
"//third_party/abseil-cpp/absl/memory",
]
}
rtc_source_set("fake_rtc_event_log") {
testonly = true
sources = [
@ -380,7 +362,6 @@ if (rtc_enable_protobuf) {
":rtc_event_generic_packet_events",
":rtc_event_log2_proto",
":rtc_event_log_api",
":rtc_event_log_impl_base",
":rtc_event_log_impl_encoder",
":rtc_event_log_parser",
":rtc_event_log_proto",
@ -392,6 +373,7 @@ if (rtc_enable_protobuf) {
"../api:libjingle_peerconnection_api",
"../api:rtc_event_log_output_file",
"../api:rtp_headers",
"../api/rtc_event_log:rtc_event_log_factory",
"../api/task_queue:default_task_queue_factory",
"../call",
"../call:call_interfaces",

22
logging/rtc_event_log/rtc_event_log_factory.cc
View file

@ -1,22 +0,0 @@
/*
* Copyright 2017 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include "logging/rtc_event_log/rtc_event_log_factory.h"
#include "absl/memory/memory.h"
#include "api/task_queue/global_task_queue_factory.h"
namespace webrtc {
std::unique_ptr<RtcEventLogFactoryInterface> CreateRtcEventLogFactory() {
return absl::make_unique<RtcEventLogFactory>(&GlobalTaskQueueFactory());
}
} // namespace webrtc

25
logging/rtc_event_log/rtc_event_log_factory.h
View file

@ -1,25 +0,0 @@
/*
* Copyright 2017 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#ifndef LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_FACTORY_H_
#define LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_FACTORY_H_
#include <memory>
#include "api/rtc_event_log/rtc_event_log_factory.h"
#include "api/rtc_event_log/rtc_event_log_factory_interface.h"
namespace webrtc {
// TODO(bugs.webrtc.org/10284): Stop using the RtcEventLogFactory factory.
std::unique_ptr<RtcEventLogFactoryInterface> CreateRtcEventLogFactory();
} // namespace webrtc
#endif // LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_FACTORY_H_

2
logging/rtc_event_log/rtc_event_log_unittest.cc
View file

@ -18,6 +18,7 @@
#include <vector>
#include "absl/memory/memory.h"
#include "api/rtc_event_log/rtc_event_log_factory.h"
#include "api/rtc_event_log_output_file.h"
#include "api/task_queue/default_task_queue_factory.h"
#include "logging/rtc_event_log/events/rtc_event_audio_network_adaptation.h"
@ -41,7 +42,6 @@
#include "logging/rtc_event_log/events/rtc_event_video_receive_stream_config.h"
#include "logging/rtc_event_log/events/rtc_event_video_send_stream_config.h"
#include "logging/rtc_event_log/rtc_event_log.h"
#include "logging/rtc_event_log/rtc_event_log_factory.h"
#include "logging/rtc_event_log/rtc_event_log_parser.h"
#include "logging/rtc_event_log/rtc_event_log_unittest_helper.h"
#include "logging/rtc_event_log/rtc_stream_config.h"

1
media/BUILD.gn
View file

@ -535,7 +535,6 @@ if (rtc_include_tests) {
"../call:call_interfaces",
"../common_video",
"../logging:rtc_event_log_api",
"../logging:rtc_event_log_impl_base",
"../modules/audio_device:mock_audio_device",
"../modules/audio_processing",
"../modules/audio_processing:api",

2
rtc_tools/BUILD.gn
View file

@ -184,7 +184,6 @@ if (!build_with_chromium) {
"../call:simulated_packet_receiver",
"../call:video_stream_api",
"../logging:rtc_event_log_api",
"../logging:rtc_event_log_impl_base",
"../media:rtc_audio_video",
"../media:rtc_media_base",
"../rtc_base",
@ -324,7 +323,6 @@ if (!build_with_chromium) {
"../call:call_interfaces",
"../call:video_stream_api",
"../logging:rtc_event_log_api",
"../logging:rtc_event_log_impl_base",
"../logging:rtc_event_log_parser",
"../logging:rtc_stream_config",
"../modules/audio_coding:ana_debug_dump_proto",

2
sdk/BUILD.gn
View file

@ -917,12 +917,12 @@ if (is_ios || is_mac) {
"../api/audio_codecs:audio_codecs_api",
"../api/audio_codecs:builtin_audio_decoder_factory",
"../api/audio_codecs:builtin_audio_encoder_factory",
"../api/rtc_event_log:rtc_event_log_factory",
"../api/task_queue:default_task_queue_factory",
"../api/video:video_frame",
"../api/video:video_rtp_headers",
"../api/video_codecs:video_codecs_api",
"../common_video",
"../logging:rtc_event_log_impl_base",
"../media:rtc_media_base",
"../modules:module_api",
"../modules/audio_device:audio_device_api",

2
sdk/android/BUILD.gn
View file

@ -1476,10 +1476,10 @@ if (is_android) {
":opensles_audio_device_module",
":video_jni",
"../../api:scoped_refptr",
"../../api/rtc_event_log:rtc_event_log_factory",
"../../api/task_queue:default_task_queue_factory",
"../../api/video:video_frame",
"../../api/video:video_rtp_headers",
"../../logging:rtc_event_log_impl_base",
"../../media:rtc_audio_video",
"../../media:rtc_internal_video_codecs",
"../../media:rtc_media_base",

2
sdk/android/native_unittests/peerconnection/peer_connection_factory_unittest.cc
View file

@ -10,8 +10,8 @@
#include "sdk/android/native_api/peerconnection/peer_connection_factory.h"
#include "absl/memory/memory.h"
#include "api/rtc_event_log/rtc_event_log_factory.h"
#include "api/task_queue/default_task_queue_factory.h"
#include "logging/rtc_event_log/rtc_event_log_factory.h"
#include "media/base/media_engine.h"
#include "media/engine/internal_decoder_factory.h"
#include "media/engine/internal_encoder_factory.h"

2
sdk/objc/api/peerconnection/RTCPeerConnectionFactory.mm
View file

@ -31,8 +31,8 @@
#include "absl/memory/memory.h"
#include "api/audio_codecs/builtin_audio_decoder_factory.h" // nogncheck
#include "api/audio_codecs/builtin_audio_encoder_factory.h" // nogncheck
#include "api/rtc_event_log/rtc_event_log_factory.h"
#include "api/task_queue/default_task_queue_factory.h"
#include "logging/rtc_event_log/rtc_event_log_factory.h"
#include "modules/audio_device/include/audio_device.h" // nogncheck
#include "modules/audio_processing/include/audio_processing.h" // nogncheck

1
test/BUILD.gn
View file

@ -748,7 +748,6 @@ rtc_source_set("test_common") {
"../call:simulated_packet_receiver",
"../call:video_stream_api",
"../logging:rtc_event_log_api",
"../logging:rtc_event_log_impl_base",
"../media:rtc_internal_video_codecs",
"../media:rtc_media_base",
"../modules/audio_device",

1
test/fuzzers/BUILD.gn
View file

@ -255,7 +255,6 @@ webrtc_fuzzer_test("congestion_controller_feedback_fuzzer") {
]
deps = [
"../../logging:rtc_event_log_api",
"../../logging:rtc_event_log_impl_base",
"../../modules/congestion_controller",
"../../modules/pacing",
"../../modules/remote_bitrate_estimator",

1
test/pc/e2e/BUILD.gn
View file

@ -350,7 +350,6 @@ if (rtc_include_tests) {
"../../../api/video_codecs:builtin_video_decoder_factory",
"../../../api/video_codecs:builtin_video_encoder_factory",
"../../../call:simulated_network",
"../../../logging:rtc_event_log_impl_base",
"../../../media:rtc_audio_video",
"../../../modules/audio_device:audio_device_impl",
"../../../p2p:rtc_p2p",

2
video/BUILD.gn
View file

@ -256,6 +256,7 @@ if (rtc_include_tests) {
"../api:rtc_event_log_output_file",
"../api:test_dependency_factory",
"../api:video_quality_test_fixture_api",
"../api/rtc_event_log:rtc_event_log_factory",
"../api/task_queue",
"../api/task_queue:default_task_queue_factory",
"../api/video:builtin_video_bitrate_allocator_factory",
@ -267,7 +268,6 @@ if (rtc_include_tests) {
"../call:simulated_network",
"../common_video",
"../logging:rtc_event_log_api",
"../logging:rtc_event_log_impl_base",
"../media:rtc_audio_video",
"../media:rtc_encoder_simulcast_proxy",
"../media:rtc_internal_video_codecs",

2
video/video_quality_test.h
View file

@ -16,11 +16,11 @@
#include <vector>
#include "api/fec_controller.h"
#include "api/rtc_event_log/rtc_event_log_factory.h"
#include "api/task_queue/task_queue_factory.h"
#include "api/test/video_quality_test_fixture.h"
#include "api/video/video_bitrate_allocator_factory.h"
#include "call/fake_network_pipe.h"
#include "logging/rtc_event_log/rtc_event_log_factory.h"
#include "media/engine/internal_decoder_factory.h"
#include "media/engine/internal_encoder_factory.h"
#include "test/call_test.h"