mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-12 21:30:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add nogncheck to protobuf_utils.h #include.

Browse source 
GN dependency checker doesn't run the preprocessor, so when the build
is configured with `rtc_enable_protobuf = false` it complains that
protobuf headers don't have a dependency (since the dependency is not
added here [1]).

It is unclear why this problem didn't show up before [2].

[1] - https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/rtc_base/BUILD.gn;l=26-29;drc=45afbc1e81449609cea181e410fa6875b00ec151
[2] - https://webrtc-review.googlesource.com/c/src/+/309262

Bug: None
Change-Id: I139fe3a9804209f0ca39a5cccce8fd4f3ae062c5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/310320
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40343}
This commit is contained in:
Mirko Bonadei 2023-06-26 07:26:39 +00:00 committed by WebRTC LUCI CQ
parent c9d96dfebe
commit 589ee5ae62
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
rtc_base/protobuf_utils.h
View file

@ -15,8 +15,8 @@
#if WEBRTC_ENABLE_PROTOBUF
#include "third_party/protobuf/src/google/protobuf/message_lite.h"
#include "third_party/protobuf/src/google/protobuf/repeated_field.h"
#include "third_party/protobuf/src/google/protobuf/message_lite.h" // nogncheck
#include "third_party/protobuf/src/google/protobuf/repeated_field.h" // nogncheck
namespace webrtc {