diff --git a/talk/app/webrtc/test/fakeaudiocapturemodule.h b/talk/app/webrtc/test/fakeaudiocapturemodule.h index 4284b9ed51..fdac0b9ed2 100644 --- a/talk/app/webrtc/test/fakeaudiocapturemodule.h +++ b/talk/app/webrtc/test/fakeaudiocapturemodule.h @@ -278,7 +278,7 @@ class FakeAudioCaptureModule // Protects variables that are accessed from process_thread_ and // the main thread. - mutable rtc::CriticalSection crit_; + rtc::CriticalSection crit_; // Protects |audio_callback_| that is accessed from process_thread_ and // the main thread. rtc::CriticalSection crit_callback_; diff --git a/talk/app/webrtc/test/fakeaudiocapturemodule_unittest.cc b/talk/app/webrtc/test/fakeaudiocapturemodule_unittest.cc index 6b675a9395..4e3bafef72 100644 --- a/talk/app/webrtc/test/fakeaudiocapturemodule_unittest.cc +++ b/talk/app/webrtc/test/fakeaudiocapturemodule_unittest.cc @@ -126,7 +126,7 @@ class FakeAdmTest : public testing::Test, return min_buffer_size; } - mutable rtc::CriticalSection crit_; + rtc::CriticalSection crit_; int push_iterations_; int pull_iterations_; diff --git a/talk/media/base/capturerenderadapter.h b/talk/media/base/capturerenderadapter.h index dda43f0871..a272952748 100644 --- a/talk/media/base/capturerenderadapter.h +++ b/talk/media/base/capturerenderadapter.h @@ -69,7 +69,7 @@ class CaptureRenderAdapter : public sigslot::has_slots<> { VideoRenderers video_renderers_; VideoCapturer* video_capturer_; // Critical section synchronizing the capture thread. - mutable rtc::CriticalSection capture_crit_; + rtc::CriticalSection capture_crit_; }; } // namespace cricket diff --git a/talk/media/base/fakevideorenderer.h b/talk/media/base/fakevideorenderer.h index d1e736e69c..0abfeffd05 100644 --- a/talk/media/base/fakevideorenderer.h +++ b/talk/media/base/fakevideorenderer.h @@ -142,7 +142,7 @@ class FakeVideoRenderer : public VideoRenderer { int height_; int num_rendered_frames_; bool black_frame_; - mutable rtc::CriticalSection crit_; + rtc::CriticalSection crit_; }; } // namespace cricket diff --git a/talk/media/devices/filevideocapturer.cc b/talk/media/devices/filevideocapturer.cc index 72398e0b88..8849a09b25 100644 --- a/talk/media/devices/filevideocapturer.cc +++ b/talk/media/devices/filevideocapturer.cc @@ -149,7 +149,7 @@ class FileVideoCapturer::FileReadThread private: FileVideoCapturer* capturer_; - mutable rtc::CriticalSection crit_; + rtc::CriticalSection crit_; bool finished_; RTC_DISALLOW_COPY_AND_ASSIGN(FileReadThread); diff --git a/talk/media/devices/yuvframescapturer.cc b/talk/media/devices/yuvframescapturer.cc index a60ad0270a..269c97c46d 100644 --- a/talk/media/devices/yuvframescapturer.cc +++ b/talk/media/devices/yuvframescapturer.cc @@ -85,7 +85,7 @@ class YuvFramesCapturer::YuvFramesThread private: YuvFramesCapturer* capturer_; - mutable rtc::CriticalSection crit_; + rtc::CriticalSection crit_; bool finished_; RTC_DISALLOW_COPY_AND_ASSIGN(YuvFramesThread); diff --git a/webrtc/audio/audio_state.h b/webrtc/audio/audio_state.h index 2cb83e4989..6bee3c6b99 100644 --- a/webrtc/audio/audio_state.h +++ b/webrtc/audio/audio_state.h @@ -47,7 +47,7 @@ class AudioState final : public webrtc::AudioState, // The critical section isn't strictly needed in this case, but xSAN bots may // trigger on unprotected cross-thread access. - mutable rtc::CriticalSection crit_sect_; + rtc::CriticalSection crit_sect_; bool typing_noise_detected_ GUARDED_BY(crit_sect_) = false; // Reference count; implementation copied from rtc::RefCountedObject. diff --git a/webrtc/base/bufferqueue.h b/webrtc/base/bufferqueue.h index 458f0189cd..89ffdf0189 100644 --- a/webrtc/base/bufferqueue.h +++ b/webrtc/base/bufferqueue.h @@ -45,7 +45,7 @@ class BufferQueue { private: size_t capacity_; size_t default_size_; - mutable CriticalSection crit_; + CriticalSection crit_; std::deque queue_ GUARDED_BY(crit_); std::vector free_list_ GUARDED_BY(crit_); diff --git a/webrtc/base/messagequeue.h b/webrtc/base/messagequeue.h index c3ab3b6669..856a6eb4bc 100644 --- a/webrtc/base/messagequeue.h +++ b/webrtc/base/messagequeue.h @@ -251,7 +251,7 @@ class MessageQueue { MessageList msgq_; PriorityQueue dmsgq_; uint32_t dmsgq_next_num_; - mutable CriticalSection crit_; + CriticalSection crit_; private: RTC_DISALLOW_COPY_AND_ASSIGN(MessageQueue); diff --git a/webrtc/base/physicalsocketserver.h b/webrtc/base/physicalsocketserver.h index ae1f10f596..cbe6580b62 100644 --- a/webrtc/base/physicalsocketserver.h +++ b/webrtc/base/physicalsocketserver.h @@ -172,7 +172,7 @@ class PhysicalSocket : public AsyncSocket, public sigslot::has_slots<> { SOCKET s_; uint8_t enabled_events_; bool udp_; - mutable CriticalSection crit_; + CriticalSection crit_; int error_ GUARDED_BY(crit_); ConnState state_; AsyncResolver* resolver_; diff --git a/webrtc/base/stream.h b/webrtc/base/stream.h index c57daae76c..98123b8211 100644 --- a/webrtc/base/stream.h +++ b/webrtc/base/stream.h @@ -555,7 +555,7 @@ class FifoBuffer : public StreamInterface { size_t data_length_; // amount of readable data in the buffer size_t read_position_; // offset to the readable data Thread* owner_; // stream callbacks are dispatched on this thread - mutable CriticalSection crit_; // object lock + CriticalSection crit_; // object lock RTC_DISALLOW_COPY_AND_ASSIGN(FifoBuffer); }; diff --git a/webrtc/base/thread_checker_impl.h b/webrtc/base/thread_checker_impl.h index 045583591d..b9867c3e7d 100644 --- a/webrtc/base/thread_checker_impl.h +++ b/webrtc/base/thread_checker_impl.h @@ -37,7 +37,7 @@ class ThreadCheckerImpl { void DetachFromThread(); private: - mutable CriticalSection lock_; + CriticalSection lock_; // This is mutable so that CalledOnValidThread can set it. // It's guarded by |lock_|. mutable PlatformThreadRef valid_thread_; diff --git a/webrtc/base/thread_unittest.cc b/webrtc/base/thread_unittest.cc index 7ed4326724..240ffc411f 100644 --- a/webrtc/base/thread_unittest.cc +++ b/webrtc/base/thread_unittest.cc @@ -164,7 +164,7 @@ class AtomicBool { } private: - mutable CriticalSection cs_; + CriticalSection cs_; bool flag_; }; diff --git a/webrtc/call/bitrate_allocator.h b/webrtc/call/bitrate_allocator.h index 88a9960f1f..5028e124bd 100644 --- a/webrtc/call/bitrate_allocator.h +++ b/webrtc/call/bitrate_allocator.h @@ -89,7 +89,7 @@ class BitrateAllocator { ObserverBitrateMap LowRateAllocation(uint32_t bitrate) EXCLUSIVE_LOCKS_REQUIRED(crit_sect_); - mutable rtc::CriticalSection crit_sect_; + rtc::CriticalSection crit_sect_; // Stored in a list to keep track of the insertion order. BitrateObserverConfList bitrate_observers_ GUARDED_BY(crit_sect_); bool bitrate_observers_modified_ GUARDED_BY(crit_sect_); diff --git a/webrtc/call/call_perf_tests.cc b/webrtc/call/call_perf_tests.cc index fa81953952..3ee49d9427 100644 --- a/webrtc/call/call_perf_tests.cc +++ b/webrtc/call/call_perf_tests.cc @@ -113,7 +113,7 @@ class SyncRtcpObserver : public test::RtpRtcpObserver { ntp_rtp_pairs_.push_front(ntp_rtp_pair); } - mutable rtc::CriticalSection crit_; + rtc::CriticalSection crit_; RtcpList ntp_rtp_pairs_ GUARDED_BY(crit_); }; diff --git a/webrtc/call/congestion_controller.h b/webrtc/call/congestion_controller.h index b77c46faa3..5f5e5905ed 100644 --- a/webrtc/call/congestion_controller.h +++ b/webrtc/call/congestion_controller.h @@ -74,7 +74,7 @@ class CongestionController { rtc::scoped_ptr remote_bitrate_estimator_; rtc::scoped_ptr remote_estimator_proxy_; - mutable rtc::CriticalSection encoder_crit_; + rtc::CriticalSection encoder_crit_; std::vector encoders_ GUARDED_BY(encoder_crit_); // Registered at construct time and assumed to outlive this class. diff --git a/webrtc/common_video/include/incoming_video_stream.h b/webrtc/common_video/include/incoming_video_stream.h index e24b2c623a..ecc4d5ef5e 100644 --- a/webrtc/common_video/include/incoming_video_stream.h +++ b/webrtc/common_video/include/incoming_video_stream.h @@ -77,9 +77,9 @@ class IncomingVideoStream : public VideoRenderCallback { uint32_t const stream_id_; const bool disable_prerenderer_smoothing_; // Critsects in allowed to enter order. - mutable rtc::CriticalSection stream_critsect_; - mutable rtc::CriticalSection thread_critsect_; - mutable rtc::CriticalSection buffer_critsect_; + rtc::CriticalSection stream_critsect_; + rtc::CriticalSection thread_critsect_; + rtc::CriticalSection buffer_critsect_; // TODO(pbos): Make plain member and stop resetting this thread, just // start/stoping it is enough. rtc::scoped_ptr incoming_render_thread_ diff --git a/webrtc/modules/audio_coding/acm2/acm_receiver.h b/webrtc/modules/audio_coding/acm2/acm_receiver.h index 826cb45864..d1ca50440b 100644 --- a/webrtc/modules/audio_coding/acm2/acm_receiver.h +++ b/webrtc/modules/audio_coding/acm2/acm_receiver.h @@ -281,7 +281,7 @@ class AcmReceiver { uint32_t NowInTimestamp(int decoder_sampling_rate) const; - mutable rtc::CriticalSection crit_sect_; + rtc::CriticalSection crit_sect_; int id_; // TODO(henrik.lundin) Make const. const Decoder* last_audio_decoder_ GUARDED_BY(crit_sect_); AudioFrame::VADActivity previous_audio_activity_ GUARDED_BY(crit_sect_); diff --git a/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h b/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h index 2a3bc61405..6750a91ea1 100644 --- a/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h +++ b/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h @@ -240,7 +240,7 @@ class AudioCodingModuleImpl final : public AudioCodingModule { // to |index|. int UpdateUponReceivingCodec(int index); - mutable rtc::CriticalSection acm_crit_sect_; + rtc::CriticalSection acm_crit_sect_; rtc::Buffer encode_buffer_ GUARDED_BY(acm_crit_sect_); int id_; // TODO(henrik.lundin) Make const. uint32_t expected_codec_ts_ GUARDED_BY(acm_crit_sect_); @@ -274,7 +274,7 @@ class AudioCodingModuleImpl final : public AudioCodingModule { uint32_t last_timestamp_ GUARDED_BY(acm_crit_sect_); uint32_t last_rtp_timestamp_ GUARDED_BY(acm_crit_sect_); - mutable rtc::CriticalSection callback_crit_sect_; + rtc::CriticalSection callback_crit_sect_; AudioPacketizationCallback* packetization_callback_ GUARDED_BY(callback_crit_sect_); ACMVADCallback* vad_callback_ GUARDED_BY(callback_crit_sect_); diff --git a/webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc b/webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc index c738d0f095..384db866bc 100644 --- a/webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc +++ b/webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc @@ -147,7 +147,7 @@ class PacketizationCallbackStubOldApi : public AudioPacketizationCallback { int last_payload_type_ GUARDED_BY(crit_sect_); uint32_t last_timestamp_ GUARDED_BY(crit_sect_); std::vector last_payload_vec_ GUARDED_BY(crit_sect_); - mutable rtc::CriticalSection crit_sect_; + rtc::CriticalSection crit_sect_; }; class AudioCodingModuleTestOldApi : public ::testing::Test { @@ -579,7 +579,7 @@ class AudioCodingModuleMtTestOldApi : public AudioCodingModuleTestOldApi { int send_count_; int insert_packet_count_; int pull_audio_count_ GUARDED_BY(crit_sect_); - mutable rtc::CriticalSection crit_sect_; + rtc::CriticalSection crit_sect_; int64_t next_insert_packet_time_ms_ GUARDED_BY(crit_sect_); rtc::scoped_ptr fake_clock_; }; @@ -842,7 +842,7 @@ class AcmReRegisterIsacMtTestOldApi : public AudioCodingModuleTestOldApi { rtc::PlatformThread receive_thread_; rtc::PlatformThread codec_registration_thread_; const rtc::scoped_ptr test_complete_; - mutable rtc::CriticalSection crit_sect_; + rtc::CriticalSection crit_sect_; bool codec_registered_ GUARDED_BY(crit_sect_); int receive_packet_count_ GUARDED_BY(crit_sect_); int64_t next_insert_packet_time_ms_ GUARDED_BY(crit_sect_); diff --git a/webrtc/modules/audio_coding/codecs/isac/locked_bandwidth_info.h b/webrtc/modules/audio_coding/codecs/isac/locked_bandwidth_info.h index 9996cbdbef..002af8c392 100644 --- a/webrtc/modules/audio_coding/codecs/isac/locked_bandwidth_info.h +++ b/webrtc/modules/audio_coding/codecs/isac/locked_bandwidth_info.h @@ -36,7 +36,7 @@ class LockedIsacBandwidthInfo final { } private: - mutable rtc::CriticalSection lock_; + rtc::CriticalSection lock_; IsacBandwidthInfo bwinfo_ GUARDED_BY(lock_); }; diff --git a/webrtc/modules/audio_coding/neteq/neteq_impl.h b/webrtc/modules/audio_coding/neteq/neteq_impl.h index 817b697bcf..02adcd35e9 100644 --- a/webrtc/modules/audio_coding/neteq/neteq_impl.h +++ b/webrtc/modules/audio_coding/neteq/neteq_impl.h @@ -338,7 +338,7 @@ class NetEqImpl : public webrtc::NetEq { // Creates DecisionLogic object with the mode given by |playout_mode_|. virtual void CreateDecisionLogic() EXCLUSIVE_LOCKS_REQUIRED(crit_sect_); - mutable rtc::CriticalSection crit_sect_; + rtc::CriticalSection crit_sect_; const rtc::scoped_ptr buffer_level_filter_ GUARDED_BY(crit_sect_); const rtc::scoped_ptr decoder_database_ diff --git a/webrtc/modules/audio_coding/test/Channel.h b/webrtc/modules/audio_coding/test/Channel.h index 3dcd499c03..5910fade25 100644 --- a/webrtc/modules/audio_coding/test/Channel.h +++ b/webrtc/modules/audio_coding/test/Channel.h @@ -100,7 +100,7 @@ class Channel : public AudioPacketizationCallback { // 60msec * 32 sample(max)/msec * 2 description (maybe) * 2 bytes/sample uint8_t _payloadData[60 * 32 * 2 * 2]; - mutable rtc::CriticalSection _channelCritSect; + rtc::CriticalSection _channelCritSect; FILE* _bitStreamFile; bool _saveBitStream; int16_t _lastPayloadType; diff --git a/webrtc/modules/audio_processing/audio_processing_impl.h b/webrtc/modules/audio_processing/audio_processing_impl.h index fbb9b6e7cc..5da3996e33 100644 --- a/webrtc/modules/audio_processing/audio_processing_impl.h +++ b/webrtc/modules/audio_processing/audio_processing_impl.h @@ -239,15 +239,15 @@ class AudioProcessingImpl : public AudioProcessing { EXCLUSIVE_LOCKS_REQUIRED(crit_capture_); // Critical section. - mutable rtc::CriticalSection crit_debug_; + rtc::CriticalSection crit_debug_; // Debug dump state. ApmDebugDumpState debug_dump_; #endif // Critical sections. - mutable rtc::CriticalSection crit_render_ ACQUIRED_BEFORE(crit_capture_); - mutable rtc::CriticalSection crit_capture_; + rtc::CriticalSection crit_render_ ACQUIRED_BEFORE(crit_capture_); + rtc::CriticalSection crit_capture_; // Structs containing the pointers to the submodules. rtc::scoped_ptr public_submodules_; diff --git a/webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc b/webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc index e1e6a310a5..3d2c71fb2d 100644 --- a/webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc +++ b/webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc @@ -298,7 +298,7 @@ class FrameCounters { } private: - mutable rtc::CriticalSection crit_; + rtc::CriticalSection crit_; int render_count GUARDED_BY(crit_) = 0; int capture_count GUARDED_BY(crit_) = 0; }; diff --git a/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc b/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc index 0c8c060ea3..285f600a42 100644 --- a/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc +++ b/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc @@ -202,7 +202,7 @@ class FrameCounters { } private: - mutable rtc::CriticalSection crit_; + rtc::CriticalSection crit_; int render_count_ GUARDED_BY(crit_) = 0; int capture_count_ GUARDED_BY(crit_) = 0; }; @@ -221,7 +221,7 @@ class LockedFlag { } private: - mutable rtc::CriticalSection crit_; + rtc::CriticalSection crit_; bool flag_ GUARDED_BY(crit_) = false; }; diff --git a/webrtc/modules/bitrate_controller/bitrate_controller_impl.h b/webrtc/modules/bitrate_controller/bitrate_controller_impl.h index d7888ccde3..74f3c14334 100644 --- a/webrtc/modules/bitrate_controller/bitrate_controller_impl.h +++ b/webrtc/modules/bitrate_controller/bitrate_controller_impl.h @@ -74,7 +74,7 @@ class BitrateControllerImpl : public BitrateController { BitrateObserver* observer_; int64_t last_bitrate_update_ms_; - mutable rtc::CriticalSection critsect_; + rtc::CriticalSection critsect_; SendSideBandwidthEstimation bandwidth_estimation_ GUARDED_BY(critsect_); uint32_t reserved_bitrate_bps_ GUARDED_BY(critsect_); diff --git a/webrtc/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.h b/webrtc/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.h index 97ed41a015..8551689548 100644 --- a/webrtc/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.h +++ b/webrtc/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.h @@ -9,8 +9,8 @@ * */ -#ifndef WEBRTC_MODULES_VIDEO_CODING_CODECS_VP9_FRAME_BUFFER_POOL_H_ -#define WEBRTC_MODULES_VIDEO_CODING_CODECS_VP9_FRAME_BUFFER_POOL_H_ +#ifndef WEBRTC_MODULES_VIDEO_CODING_CODECS_VP9_VP9_FRAME_BUFFER_POOL_H_ +#define WEBRTC_MODULES_VIDEO_CODING_CODECS_VP9_VP9_FRAME_BUFFER_POOL_H_ #include @@ -103,7 +103,7 @@ class Vp9FrameBufferPool { private: // Protects |allocated_buffers_|. - mutable rtc::CriticalSection buffers_lock_; + rtc::CriticalSection buffers_lock_; // All buffers, in use or ready to be recycled. std::vector> allocated_buffers_ GUARDED_BY(buffers_lock_); @@ -114,4 +114,4 @@ class Vp9FrameBufferPool { } // namespace webrtc -#endif // WEBRTC_MODULES_VIDEO_CODING_CODECS_VP9_FRAME_BUFFER_POOL_H_ +#endif // WEBRTC_MODULES_VIDEO_CODING_CODECS_VP9_VP9_FRAME_BUFFER_POOL_H_ diff --git a/webrtc/modules/video_coding/generic_encoder.h b/webrtc/modules/video_coding/generic_encoder.h index f739edb44f..da7297ffa2 100644 --- a/webrtc/modules/video_coding/generic_encoder.h +++ b/webrtc/modules/video_coding/generic_encoder.h @@ -138,7 +138,7 @@ class VCMGenericEncoder { VideoEncoderRateObserver* const rate_observer_; VCMEncodedFrameCallback* const vcm_encoded_frame_callback_; const bool internal_source_; - mutable rtc::CriticalSection params_lock_; + rtc::CriticalSection params_lock_; EncoderParameters encoder_params_ GUARDED_BY(params_lock_); VideoRotation rotation_; bool is_screenshare_; diff --git a/webrtc/modules/video_coding/video_coding_impl.h b/webrtc/modules/video_coding/video_coding_impl.h index 1ed96e126b..73733253bf 100644 --- a/webrtc/modules/video_coding/video_coding_impl.h +++ b/webrtc/modules/video_coding/video_coding_impl.h @@ -104,7 +104,7 @@ class VideoSender { Clock* const clock_; rtc::scoped_ptr process_crit_sect_; - mutable rtc::CriticalSection encoder_crit_; + rtc::CriticalSection encoder_crit_; VCMGenericEncoder* _encoder; VCMEncodedFrameCallback _encodedFrameCallback GUARDED_BY(encoder_crit_); media_optimization::MediaOptimization _mediaOpt; diff --git a/webrtc/modules/video_processing/video_processing_impl.h b/webrtc/modules/video_processing/video_processing_impl.h index edbaba12fa..1d9a3775cf 100644 --- a/webrtc/modules/video_processing/video_processing_impl.h +++ b/webrtc/modules/video_processing/video_processing_impl.h @@ -44,7 +44,7 @@ class VideoProcessingImpl : public VideoProcessing { VideoContentMetrics* GetContentMetrics() const override; private: - mutable rtc::CriticalSection mutex_; + rtc::CriticalSection mutex_; VPMDeflickering deflickering_ GUARDED_BY(mutex_); VPMBrightnessDetection brightness_detection_; VPMFramePreprocessor frame_pre_processor_; diff --git a/webrtc/system_wrappers/source/clock.cc b/webrtc/system_wrappers/source/clock.cc index 95df256f3c..926b95a3df 100644 --- a/webrtc/system_wrappers/source/clock.cc +++ b/webrtc/system_wrappers/source/clock.cc @@ -179,7 +179,7 @@ class WindowsRealTimeClock : public RealTimeClock { } // mutable as time-accessing functions are const. - mutable rtc::CriticalSection crit_; + rtc::CriticalSection crit_; mutable DWORD last_time_ms_; mutable LONG num_timer_wraps_; const ReferencePoint ref_point_; diff --git a/webrtc/test/fake_audio_device.h b/webrtc/test/fake_audio_device.h index 7ca657bbb6..ce480c1554 100644 --- a/webrtc/test/fake_audio_device.h +++ b/webrtc/test/fake_audio_device.h @@ -58,7 +58,7 @@ class FakeAudioDevice : public FakeAudioDeviceModule { Clock* clock_; rtc::scoped_ptr tick_; - mutable rtc::CriticalSection lock_; + rtc::CriticalSection lock_; rtc::PlatformThread thread_; rtc::scoped_ptr file_utility_; rtc::scoped_ptr input_stream_; diff --git a/webrtc/test/fake_network_pipe.h b/webrtc/test/fake_network_pipe.h index 5d589d86f0..99c5c1366b 100644 --- a/webrtc/test/fake_network_pipe.h +++ b/webrtc/test/fake_network_pipe.h @@ -71,7 +71,7 @@ class FakeNetworkPipe { private: Clock* const clock_; - mutable rtc::CriticalSection lock_; + rtc::CriticalSection lock_; PacketReceiver* packet_receiver_; std::queue capacity_link_; std::queue delay_link_; diff --git a/webrtc/video/overuse_frame_detector.h b/webrtc/video/overuse_frame_detector.h index d2606c19e6..0ef2e43857 100644 --- a/webrtc/video/overuse_frame_detector.h +++ b/webrtc/video/overuse_frame_detector.h @@ -119,7 +119,7 @@ class OveruseFrameDetector : public Module { // processing thread. // TODO(asapersson): See if we can reduce locking. As is, video frame // processing contends with reading stats and the processing thread. - mutable rtc::CriticalSection crit_; + rtc::CriticalSection crit_; const CpuOveruseOptions options_; diff --git a/webrtc/video/receive_statistics_proxy.h b/webrtc/video/receive_statistics_proxy.h index 87cb9506a9..0692297eb2 100644 --- a/webrtc/video/receive_statistics_proxy.h +++ b/webrtc/video/receive_statistics_proxy.h @@ -95,7 +95,7 @@ class ReceiveStatisticsProxy : public VCMReceiveStatisticsCallback, Clock* const clock_; - mutable rtc::CriticalSection crit_; + rtc::CriticalSection crit_; VideoReceiveStream::Stats stats_ GUARDED_BY(crit_); RateStatistics decode_fps_estimator_ GUARDED_BY(crit_); RateStatistics renders_fps_estimator_ GUARDED_BY(crit_); diff --git a/webrtc/video/send_statistics_proxy.h b/webrtc/video/send_statistics_proxy.h index 7f6df06ad8..f4c3f5ae00 100644 --- a/webrtc/video/send_statistics_proxy.h +++ b/webrtc/video/send_statistics_proxy.h @@ -131,7 +131,7 @@ class SendStatisticsProxy : public CpuOveruseMetricsObserver, Clock* const clock_; const VideoSendStream::Config config_; - mutable rtc::CriticalSection crit_; + rtc::CriticalSection crit_; VideoEncoderConfig::ContentType content_type_ GUARDED_BY(crit_); VideoSendStream::Stats stats_ GUARDED_BY(crit_); uint32_t last_sent_frame_timestamp_ GUARDED_BY(crit_); diff --git a/webrtc/video/video_send_stream_tests.cc b/webrtc/video/video_send_stream_tests.cc index 6014f057fa..00aa2a9018 100644 --- a/webrtc/video/video_send_stream_tests.cc +++ b/webrtc/video/video_send_stream_tests.cc @@ -1079,7 +1079,7 @@ TEST_F(VideoSendStreamTest, CanReconfigureToUseStartBitrateAbovePreviousMax) { } private: - mutable rtc::CriticalSection crit_; + rtc::CriticalSection crit_; int start_bitrate_kbps_ GUARDED_BY(crit_); };