mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 13:50:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Temporarily skip tests that consistently fail on Linux MSan.

Browse source 
This seems an issue with recently updated MSan prebuilt libraries,
or at least the issue started to happen after that. While investigating
let's skip the two tests to unblock presubmit and LKGR.

Bug: webrtc:12950
Change-Id: Iebd391deb9f669f6471bd41aae1ab32b7f6f8fc5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225420
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34434}
This commit is contained in:
Mirko Bonadei 2021-07-08 09:05:34 +02:00 committed by WebRTC LUCI CQ
parent 0c5a5ca45f
commit 5d70fe763d
2 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
modules/desktop_capture/screen_capturer_unittest.cc
View file

@ -99,7 +99,13 @@ ACTION_P(SaveUniquePtrArg, dest) {
*dest = std::move(*arg1); *dest = std::move(*arg1);
} }
TEST_F(ScreenCapturerTest, GetScreenListAndSelectScreen) { // TODO(bugs.webrtc.org/12950): Re-enable when libc++ issue is fixed.
#if defined(WEBRTC_LINUX) && defined(MEMORY_SANITIZER)
#define MAYBE_GetScreenListAndSelectScreen DISABLED_GetScreenListAndSelectScreen
#else
#define MAYBE_GetScreenListAndSelectScreen GetScreenListAndSelectScreen
#endif
TEST_F(ScreenCapturerTest, MAYBE_GetScreenListAndSelectScreen) {
webrtc::DesktopCapturer::SourceList screens; webrtc::DesktopCapturer::SourceList screens;
EXPECT_TRUE(capturer_->GetSourceList(&screens)); EXPECT_TRUE(capturer_->GetSourceList(&screens));
for (const auto& screen : screens) { for (const auto& screen : screens) {

8
modules/desktop_capture/window_capturer_unittest.cc
View file

@ -44,7 +44,13 @@ class WindowCapturerTest : public ::testing::Test,
}; };
// Verify that we can enumerate windows. // Verify that we can enumerate windows.
TEST_F(WindowCapturerTest, Enumerate) { // TODO(bugs.webrtc.org/12950): Re-enable when libc++ issue is fixed
#if defined(WEBRTC_LINUX) && defined(MEMORY_SANITIZER)
#define MAYBE_Enumerate DISABLED_Enumerate
#else
#define MAYBE_Enumerate Enumerate
#endif
TEST_F(WindowCapturerTest, MAYBE_Enumerate) {
DesktopCapturer::SourceList sources; DesktopCapturer::SourceList sources;
EXPECT_TRUE(capturer_->GetSourceList(&sources)); EXPECT_TRUE(capturer_->GetSourceList(&sources));