diff --git a/rtc_base/strings/string_format_unittest.cc b/rtc_base/strings/string_format_unittest.cc index d0e8eb2d71..5531001979 100644 --- a/rtc_base/strings/string_format_unittest.cc +++ b/rtc_base/strings/string_format_unittest.cc @@ -10,7 +10,11 @@ #include "rtc_base/strings/string_format.h" +#include + +#include "absl/strings/string_view.h" #include "rtc_base/checks.h" +#include "rtc_base/string_encode.h" #include "test/gtest.h" namespace rtc { @@ -32,4 +36,17 @@ TEST(StringFormatTest, MaxSizeShouldWork) { EXPECT_EQ(str, StringFormat("%s", str)); } +// Test that formating a string using `absl::string_view` works as expected +// whe using `%.*s`. +TEST(StringFormatTest, FormatStringView) { + const std::string main_string("This is a substring test."); + std::vector string_views = rtc::split(main_string, ' '); + ASSERT_EQ(string_views.size(), 5u); + + const absl::string_view& sv = string_views[3]; + std::string formatted = + StringFormat("We have a %.*s.", static_cast(sv.size()), sv.data()); + EXPECT_EQ(formatted.compare("We have a substring."), 0); +} + } // namespace rtc