mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 05:40:42 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix PRESUBMIT.py

Browse source 
NOTRY=True
TBR=kjellander@webrtc.org

Bug: webrtc:8197
Change-Id: Ie8b50faec7c6c5f7b9dd259c8312e4cec5748a42
Reviewed-on: https://webrtc-review.googlesource.com/1361
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Charu Jain <charujain@webrtc.org>
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19838}
This commit is contained in:
Edward Lemur 2017-09-14 17:02:01 +02:00 committed by Commit Bot
parent f1977b383d
commit 6d01f6d220
2 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
PRESUBMIT.py
View file

@ -493,7 +493,7 @@ def RunPythonTests(input_api, output_api):
return input_api.os_path.join(input_api.PresubmitLocalPath(), *args) return input_api.os_path.join(input_api.PresubmitLocalPath(), *args)
test_directories = [ test_directories = [
'/', input_api.PresubmitLocalPath(),
Join('webrtc', 'rtc_tools', 'py_event_log_analyzer'), Join('webrtc', 'rtc_tools', 'py_event_log_analyzer'),
Join('webrtc', 'rtc_tools'), Join('webrtc', 'rtc_tools'),
Join('webrtc', 'audio', 'test', 'unittests'), Join('webrtc', 'audio', 'test', 'unittests'),

7
presubmit_test.py Normal file → Executable file
View file

@ -1,3 +1,4 @@
#!/usr/bin/env python2
import unittest import unittest
import PRESUBMIT import PRESUBMIT
@ -10,7 +11,7 @@ class CheckBugEntryField(unittest.TestCase):
mock_output_api = MockOutputApi() mock_output_api = MockOutputApi()
mock_input_api.change.BUG = 'webrtc:1234' mock_input_api.change.BUG = 'webrtc:1234'
errors = PRESUBMIT.CheckCommitMessageBugEntry(mock_input_api, errors = PRESUBMIT.CheckCommitMessageBugEntry(mock_input_api,
mock_output_api) mock_output_api)
self.assertEqual(0, len(errors)) self.assertEqual(0, len(errors))
def testCommitMessageBugEntryReturnError(self): def testCommitMessageBugEntryReturnError(self):
@ -18,7 +19,7 @@ class CheckBugEntryField(unittest.TestCase):
mock_output_api = MockOutputApi() mock_output_api = MockOutputApi()
mock_input_api.change.BUG = 'webrtc:1234,webrtc=4321' mock_input_api.change.BUG = 'webrtc:1234,webrtc=4321'
errors = PRESUBMIT.CheckCommitMessageBugEntry(mock_input_api, errors = PRESUBMIT.CheckCommitMessageBugEntry(mock_input_api,
mock_output_api) mock_output_api)
self.assertEqual(1, len(errors)) self.assertEqual(1, len(errors))
self.assertEqual(('Bogus BUG entry: webrtc=4321. Please specify' self.assertEqual(('Bogus BUG entry: webrtc=4321. Please specify'
' the issue tracker prefix and the issue number,' ' the issue tracker prefix and the issue number,'
@ -30,7 +31,7 @@ class CheckBugEntryField(unittest.TestCase):
mock_output_api = MockOutputApi() mock_output_api = MockOutputApi()
mock_input_api.change.BUG = 'None' mock_input_api.change.BUG = 'None'
errors = PRESUBMIT.CheckCommitMessageBugEntry(mock_input_api, errors = PRESUBMIT.CheckCommitMessageBugEntry(mock_input_api,
mock_output_api) mock_output_api)
self.assertEqual(0, len(errors)) self.assertEqual(0, len(errors))