mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-12 21:30:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Test logging also with Windows paths.

Browse source 
Bug: None
Change-Id: Ic5d52b90d3a3f245bd9d2f56cda85b0cc1a1ef8d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270460
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37677}
This commit is contained in:
Mirko Bonadei 2022-08-03 12:49:40 +00:00 committed by WebRTC LUCI CQ
parent 47114f25e3
commit 70ed471836
1 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
rtc_base/logging_unittest.cc
View file

@ -27,6 +27,16 @@
namespace rtc {
namespace {
#if defined(WEBRTC_WIN)
constexpr char kFakeFilePath[] = "some\\path\\myfile.cc";
#else
constexpr char kFakeFilePath[] = "some/path/myfile.cc";
#endif
} // namespace
class LogSinkImpl : public LogSink {
public:
explicit LogSinkImpl(std::string* log_data) : log_data_(log_data) {}
@ -205,8 +215,8 @@ TEST(LogTest, WallClockStartTime) {
}
TEST(LogTest, CheckExtraErrorField) {
LogMessageForTesting log_msg("some/path/myfile.cc", 100, LS_WARNING,
ERRCTX_ERRNO, 0xD);
LogMessageForTesting log_msg(kFakeFilePath, 100, LS_WARNING, ERRCTX_ERRNO,
0xD);
log_msg.stream() << "This gets added at dtor time";
const std::string& extra = log_msg.get_extra();
@ -224,7 +234,7 @@ TEST(LogTest, CheckFilePathParsed) {
const char* tag = nullptr;
#endif
{
LogMessageForTesting log_msg("some/path/myfile.cc", 100, LS_INFO);
LogMessageForTesting log_msg(kFakeFilePath, 100, LS_INFO);
log_msg.stream() << "<- Does this look right?";
#if defined(WEBRTC_ANDROID)
tag = log_msg.get_tag();