mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 05:40:42 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add presubmit error if third_party/.git exists.

Browse source 
Bug: webrtc:8366
Change-Id: I5fc91a18211ebbc2f6e61688bbafa7a7cc991916
Reviewed-on: https://webrtc-review.googlesource.com/78401
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23357}
This commit is contained in:
Artem Titov 2018-05-23 10:16:30 +02:00 committed by Commit Bot
parent 72678e11cc
commit 71d4dc3509
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
PRESUBMIT.py
View file

@ -795,6 +795,7 @@ def CommonChecks(input_api, output_api):
non_third_party_sources = lambda x: input_api.FilterSourceFile(x,
black_list=third_party_filter_list)
results.extend(CheckNoGitRepoInThirdParty(input_api, output_api))
results.extend(input_api.canned_checks.CheckLongLines(
input_api, output_api, maxlen=80, source_file_filter=eighty_char_sources))
results.extend(input_api.canned_checks.CheckLongLines(
@ -834,6 +835,17 @@ def CommonChecks(input_api, output_api):
return results
def CheckNoGitRepoInThirdParty(input_api, output_api):
if os.path.isdir(input_api.os_path.join(
input_api.PresubmitLocalPath(), 'third_party', '.git')):
return [output_api.PresubmitError("Please remove third_party/.git "
"directory. This error means that "
"possibly you also have to apply other "
"instructions from the May 11th PSA from "
"titovartem@.")]
return []
def CheckThirdPartyChanges(input_api, output_api):
with _AddToPath(input_api.os_path.join(
input_api.PresubmitLocalPath(), 'tools_webrtc', 'presubmit_checks_lib')):