From 76d84f122e4b237981080225594d72b0786963ba Mon Sep 17 00:00:00 2001 From: Ali Tofigh Date: Thu, 12 May 2022 23:24:27 +0200 Subject: [PATCH] Adopt absl::string_view in common_audio/ Bug: webrtc:13579 Change-Id: I7f9beb34f92d1ea587eda87d1222774ce944a625 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262249 Reviewed-by: Minyue Li Commit-Queue: Ali Tofigh Cr-Commit-Position: refs/heads/main@{#36886} --- common_audio/wav_file.cc | 4 ++-- common_audio/wav_file.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/common_audio/wav_file.cc b/common_audio/wav_file.cc index e49126f139..127c9c0757 100644 --- a/common_audio/wav_file.cc +++ b/common_audio/wav_file.cc @@ -65,7 +65,7 @@ constexpr size_t kMaxChunksize = 4096; } // namespace -WavReader::WavReader(const std::string& filename) +WavReader::WavReader(absl::string_view filename) : WavReader(FileWrapper::OpenReadOnly(filename)) {} WavReader::WavReader(FileWrapper file) : file_(std::move(file)) { @@ -178,7 +178,7 @@ void WavReader::Close() { file_.Close(); } -WavWriter::WavWriter(const std::string& filename, +WavWriter::WavWriter(absl::string_view filename, int sample_rate, size_t num_channels, SampleFormat sample_format) diff --git a/common_audio/wav_file.h b/common_audio/wav_file.h index dda611be6a..72a4db79c2 100644 --- a/common_audio/wav_file.h +++ b/common_audio/wav_file.h @@ -39,7 +39,7 @@ class WavFile { class WavWriter final : public WavFile { public: // Opens a new WAV file for writing. - WavWriter(const std::string& filename, + WavWriter(absl::string_view filename, int sample_rate, size_t num_channels, SampleFormat sample_format = SampleFormat::kInt16); @@ -77,7 +77,7 @@ class WavWriter final : public WavFile { class WavReader final : public WavFile { public: // Opens an existing WAV file for reading. - explicit WavReader(const std::string& filename); + explicit WavReader(absl::string_view filename); explicit WavReader(FileWrapper file); // Close the WAV file.