From 775d07e27769d15b44a511c040bf68fb8386471c Mon Sep 17 00:00:00 2001 From: Oleh Prypin Date: Thu, 26 Apr 2018 15:36:45 +0200 Subject: [PATCH] Avoid ObjectToString warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit sdk/android/src/java/org/webrtc/HardwareVideoDecoder.java:210: warning: [ObjectToString] android.media.MediaCodec is final and does not override Object.toString, converting it to a string will print its identity (e.g. `android.media.MediaCodec@ 4488aabb`) instead of useful information. Logging.d(TAG, "decode uninitalized, codec: " + codec + ", callback: " + callback); Bug: None No-Try: True Change-Id: Ief08f8f7fcbd16091cac4d4f0b4d30e82f5b1bd3 Reviewed-on: https://webrtc-review.googlesource.com/72840 Commit-Queue: Oleh Prypin Reviewed-by: Sami Kalliomäki Cr-Commit-Position: refs/heads/master@{#23032} --- sdk/android/src/java/org/webrtc/HardwareVideoDecoder.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/android/src/java/org/webrtc/HardwareVideoDecoder.java b/sdk/android/src/java/org/webrtc/HardwareVideoDecoder.java index 0ca99af031..a24da4d565 100644 --- a/sdk/android/src/java/org/webrtc/HardwareVideoDecoder.java +++ b/sdk/android/src/java/org/webrtc/HardwareVideoDecoder.java @@ -207,7 +207,7 @@ class HardwareVideoDecoder public VideoCodecStatus decode(EncodedImage frame, DecodeInfo info) { decoderThreadChecker.checkIsOnValidThread(); if (codec == null || callback == null) { - Logging.d(TAG, "decode uninitalized, codec: " + codec + ", callback: " + callback); + Logging.d(TAG, "decode uninitalized, codec: " + (codec != null) + ", callback: " + callback); return VideoCodecStatus.UNINITIALIZED; }