mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-15 14:50:39 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Disable cpplint readability/todo.

Browse source 
This check triggers on new style TODOs (TODO: BUG - TEXT).
The fix should land in the upstream cpplint, on the other hand this
check is disbled in Chromium as well. WebRTC should disable for the
same reasons [1].

[1] - https://source.chromium.org/chromium/chromium/src/+/main:third_party/depot_tools/presubmit_canned_checks.py;l=48-54;drc=f2f8be1ca848f99de85fd299af537a2e2a462387

Bug: b/299058717
Change-Id: I3f56c92663d02dcb323d74870ed72025ae8e02e4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329161
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41280}
This commit is contained in:
Mirko Bonadei 2023-11-29 16:01:38 +00:00 committed by WebRTC LUCI CQ
parent 8eeb8facb9
commit 7b4b29a13f
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
PRESUBMIT.py
View file

@ -59,12 +59,15 @@ PYLINT_OLD_STYLE = [
# - build/c++11 : Rvalue ref checks are unreliable (false positives), # - build/c++11 : Rvalue ref checks are unreliable (false positives),
# include file and feature blocklists are # include file and feature blocklists are
# google3-specific. # google3-specific.
# - readability/todo : WebRTC puts bug links, not usernames, in TODOs.
# The new TODO style also doesn't match with this check.
# - runtime/references : Mutable references are not banned by the Google # - runtime/references : Mutable references are not banned by the Google
# C++ style guide anymore (starting from May 2020). # C++ style guide anymore (starting from May 2020).
# - whitespace/operators: Same as above (doesn't seem sufficient to eliminate # - whitespace/operators: Same as above (doesn't seem sufficient to eliminate
# all move-related errors). # all move-related errors).
DISABLED_LINT_FILTERS = [ DISABLED_LINT_FILTERS = [
'-build/c++11', '-build/c++11',
'-readability/todo',
'-runtime/references', '-runtime/references',
'-whitespace/operators', '-whitespace/operators',
] ]