mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 05:40:42 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Cleanup include and dependencies in api/metronome

Browse source 
In particular remove unused dependency on rtc::TaskQueue

Bug: webrtc:14169
Change-Id: Iaddf661bb0abcefb7d69608ab4f0dfe431732c9a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334900
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41562}
This commit is contained in:
Danil Chapovalov 2024-01-17 17:49:37 +01:00 committed by WebRTC LUCI CQ
parent 0b6899272c
commit 7d637a9788
6 changed files with 6 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
api/DEPS
View file

@ -159,13 +159,6 @@ specific_include_rules = {
"+modules/audio_processing/include/audio_processing.h", "+modules/audio_processing/include/audio_processing.h",
], ],
"fake_metronome\.h": [
"+rtc_base/synchronization/mutex.h",
"+rtc_base/task_queue.h",
"+rtc_base/task_utils/repeating_task.h",
"+rtc_base/thread_annotations.h",
],
"make_ref_counted\.h": [ "make_ref_counted\.h": [
"+rtc_base/ref_counted_object.h", "+rtc_base/ref_counted_object.h",
], ],

2
api/metronome/BUILD.gn
View file

@ -13,7 +13,7 @@ rtc_source_set("metronome") {
sources = [ "metronome.h" ] sources = [ "metronome.h" ]
deps = [ deps = [
"../../rtc_base/system:rtc_export", "../../rtc_base/system:rtc_export",
"../task_queue",
"../units:time_delta", "../units:time_delta",
] ]
absl_deps = [ "//third_party/abseil-cpp/absl/functional:any_invocable" ]
} }

2
api/metronome/metronome.h
View file

@ -11,7 +11,7 @@
#ifndef API_METRONOME_METRONOME_H_ #ifndef API_METRONOME_METRONOME_H_
#define API_METRONOME_METRONOME_H_ #define API_METRONOME_METRONOME_H_
#include "api/task_queue/task_queue_base.h" #include "absl/functional/any_invocable.h"
#include "api/units/time_delta.h" #include "api/units/time_delta.h"
#include "rtc_base/system/rtc_export.h" #include "rtc_base/system/rtc_export.h"

9
api/metronome/test/BUILD.gn
View file

@ -16,15 +16,8 @@ rtc_library("fake_metronome") {
] ]
deps = [ deps = [
"..:metronome", "..:metronome",
"../..:priority",
"../..:sequence_checker",
"../../../rtc_base:macromagic",
"../../../rtc_base:rtc_event",
"../../../rtc_base:rtc_task_queue",
"../../../rtc_base/synchronization:mutex",
"../../../rtc_base/task_utils:repeating_task",
"../../../test:test_support",
"../../task_queue", "../../task_queue",
"../../units:time_delta", "../../units:time_delta",
] ]
absl_deps = [ "//third_party/abseil-cpp/absl/functional:any_invocable" ]
} }

6
api/metronome/test/fake_metronome.cc
View file

@ -13,13 +13,9 @@
#include <utility> #include <utility>
#include <vector> #include <vector>
#include "api/priority.h" #include "absl/functional/any_invocable.h"
#include "api/sequence_checker.h"
#include "api/task_queue/task_queue_base.h" #include "api/task_queue/task_queue_base.h"
#include "api/task_queue/task_queue_factory.h"
#include "api/units/time_delta.h" #include "api/units/time_delta.h"
#include "rtc_base/event.h"
#include "rtc_base/task_utils/repeating_task.h"
namespace webrtc::test { namespace webrtc::test {

13
api/metronome/test/fake_metronome.h
View file

@ -11,18 +11,12 @@
#ifndef API_METRONOME_TEST_FAKE_METRONOME_H_ #ifndef API_METRONOME_TEST_FAKE_METRONOME_H_
#define API_METRONOME_TEST_FAKE_METRONOME_H_ #define API_METRONOME_TEST_FAKE_METRONOME_H_
#include <memory> #include <cstddef>
#include <set>
#include <vector> #include <vector>
#include "absl/functional/any_invocable.h"
#include "api/metronome/metronome.h" #include "api/metronome/metronome.h"
#include "api/task_queue/task_queue_base.h"
#include "api/task_queue/task_queue_factory.h"
#include "api/units/time_delta.h" #include "api/units/time_delta.h"
#include "rtc_base/synchronization/mutex.h"
#include "rtc_base/task_queue.h"
#include "rtc_base/task_utils/repeating_task.h"
#include "rtc_base/thread_annotations.h"
namespace webrtc::test { namespace webrtc::test {
@ -48,9 +42,6 @@ class ForcedTickMetronome : public Metronome {
// FakeMetronome is a metronome that ticks based on a repeating task at the // FakeMetronome is a metronome that ticks based on a repeating task at the
// `tick_period` provided in the constructor. It is designed for use with // `tick_period` provided in the constructor. It is designed for use with
// simulated task queues for unit tests. // simulated task queues for unit tests.
//
// `Stop()` must be called before destruction, as it cancels the metronome tick
// on the proper task queue.
class FakeMetronome : public Metronome { class FakeMetronome : public Metronome {
public: public:
explicit FakeMetronome(TimeDelta tick_period); explicit FakeMetronome(TimeDelta tick_period);