From 7d9f0dc40fb2a7fab3b04900fc4487a898d51fe6 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Fri, 12 Aug 2022 08:58:59 +0200 Subject: [PATCH] Downgrade go runtime to 1.16 for macOS AppRTC tests. Starting from Go 1.17, modules are the default and cannot be disabled. This requires a change in the GitHub repositury [1]. As a stopgap solution, this CL moves Go back to 1.16 and disables modules [2]. [1] - https://github.com/webrtc/apprtc/tree/master/src/collider [2] - https://go.dev/blog/go116-module-changes No-Presubmit: True Bug: webrtc:14342 Change-Id: Idd03639588bc03497a78f0cef350daebf3b2f1d9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271481 Reviewed-by: Evan Shrubsole Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/main@{#37760} --- rtc_tools/testing/build_apprtc.py | 1 + rtc_tools/testing/golang/mac/go.tar.gz.sha1 | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/rtc_tools/testing/build_apprtc.py b/rtc_tools/testing/build_apprtc.py index e93b7e06c7..d601357459 100755 --- a/rtc_tools/testing/build_apprtc.py +++ b/rtc_tools/testing/build_apprtc.py @@ -55,6 +55,7 @@ def main(argv): golang_env = os.environ.copy() golang_env['GOROOT'] = go_root_dir golang_env['GOPATH'] = golang_workspace + golang_env['GO111MODULE'] = 'off' collider_out = os.path.join( golang_workspace, 'collidermain' + utils.GetExecutableExtension()) subprocess.check_call( diff --git a/rtc_tools/testing/golang/mac/go.tar.gz.sha1 b/rtc_tools/testing/golang/mac/go.tar.gz.sha1 index ec3a4af76c..399edd5cd8 100644 --- a/rtc_tools/testing/golang/mac/go.tar.gz.sha1 +++ b/rtc_tools/testing/golang/mac/go.tar.gz.sha1 @@ -1 +1 @@ -94422c2571e68e7725b9fb878c37e7de47a2351a \ No newline at end of file +e13521f5d61465fe873371b266bc3ceafcb13562 \ No newline at end of file