mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-12 21:30:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove JsepSessionDescription::kDefaultVideoCodecName

Browse source 
which is only used in tests.

BUG=None

Change-Id: If215ad84e6756af2ee90777a27376400f8f4d8e0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/294721
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#39450}
This commit is contained in:
Philipp Hancke 2023-02-23 13:20:25 +01:00 committed by WebRTC LUCI CQ
parent 579a7b498c
commit 7f4270d160
3 changed files with 2 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
api/jsep_session_description.h
View file

@ -71,9 +71,6 @@ class JsepSessionDescription : public SessionDescriptionInterface {
size_t mediasection_index) const;
virtual bool ToString(std::string* out) const;
static const int kDefaultVideoCodecId;
static const char kDefaultVideoCodecName[];
private:
std::unique_ptr<cricket::SessionDescription> description_;
std::string session_id_;

3
pc/jsep_session_description.cc
View file

@ -121,9 +121,6 @@ void UpdateConnectionAddress(
} // namespace
const int JsepSessionDescription::kDefaultVideoCodecId = 100;
const char JsepSessionDescription::kDefaultVideoCodecName[] = "VP8";
// TODO(steveanton): Remove this default implementation once Chromium has been
// updated.
SdpType SessionDescriptionInterface::GetType() const {

6
pc/webrtc_sdp_unittest.cc
View file

@ -1317,8 +1317,7 @@ class WebRtcSdpTest : public ::testing::Test {
1, "AES_CM_128_HMAC_SHA1_80",
"inline:d0RmdmcmVCspeEc3QGZiNWpVLFJhQX1cfHAwJSoj|2^20|1:32", ""));
video->set_protocol(cricket::kMediaProtocolSavpf);
video->AddCodec(
VideoCodec(120, JsepSessionDescription::kDefaultVideoCodecName));
video->AddCodec(VideoCodec(120, "VP8"));
return video;
}
@ -1969,8 +1968,7 @@ class WebRtcSdpTest : public ::testing::Test {
ASSERT_TRUE(vcd);
ASSERT_FALSE(vcd->codecs().empty());
cricket::VideoCodec vp8 = vcd->codecs()[0];
EXPECT_STREQ(webrtc::JsepSessionDescription::kDefaultVideoCodecName,
vp8.name.c_str());
EXPECT_EQ(vp8.name, "VP8");
EXPECT_EQ(101, vp8.id);
EXPECT_TRUE(vp8.HasFeedbackParam(cricket::FeedbackParam(
cricket::kRtcpFbParamLntf, cricket::kParamValueEmpty)));