mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 13:50:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Switch from check_targets to no_check_targets in .gn

Browse source 
Bug: webrtc:12785
Change-Id: I3d5252323393f6cfd536b48a867d55d07313d7c9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219341
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34064}
This commit is contained in:
Byoungchan Lee 2021-05-20 18:30:10 +09:00 committed by WebRTC LUCI CQ
parent 193f4bf6c1
commit 8ed1e9336e
2 changed files with 7 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
.gn
View file

@ -20,33 +20,11 @@ script_executable = "python3"
# in the source tree, e.g. for third party source trees. # in the source tree, e.g. for third party source trees.
secondary_source = "//build/secondary/" secondary_source = "//build/secondary/"
# These are the targets to check headers for by default. The files in targets # These are the targets to skip header checking by default. The files in targets
# matching these patterns (see "gn help label_pattern" for format) will have # matching these patterns (see "gn help label_pattern" for format) will not have
# their includes checked for proper dependencies when you run either # their includes checked for proper dependencies when you run either
# "gn check" or "gn gen --check". # "gn check" or "gn gen --check".
check_targets = [ no_check_targets = [ "//third_party/icu/*" ]
"//api/*",
"//audio/*",
"//backup/*",
"//call/*",
"//common_audio/*",
"//common_video/*",
"//examples/*",
"//logging/*",
"//media/*",
"//modules/*",
"//net/*",
"//p2p/*",
"//pc/*",
"//rtc_base/*",
"//rtc_tools/*",
"//sdk/*",
"//stats/*",
"//system_wrappers/*",
"//test/*",
"//video/*",
"//third_party/libyuv/*",
]
# These are the list of GN files that run exec_script. This whitelist exists # These are the list of GN files that run exec_script. This whitelist exists
# to force additional review for new uses of exec_script, which is strongly # to force additional review for new uses of exec_script, which is strongly

4
BUILD.gn
View file

@ -520,6 +520,10 @@ if (!build_with_chromium) {
rtc_executable("webrtc_lib_link_test") { rtc_executable("webrtc_lib_link_test") {
testonly = true testonly = true
# This target is used for checking to link, so do not check dependencies
# on gn check.
check_includes = false # no-presubmit-check TODO(bugs.webrtc.org/12785)
sources = [ "webrtc_lib_link_test.cc" ] sources = [ "webrtc_lib_link_test.cc" ]
deps = [ deps = [
# NOTE: Don't add deps here. If this test fails to link, it means you # NOTE: Don't add deps here. If this test fails to link, it means you