Switch from check_targets to no_check_targets in .gn

Bug: webrtc:12785
Change-Id: I3d5252323393f6cfd536b48a867d55d07313d7c9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219341
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34064}

.gn

@@ -20,33 +20,11 @@ script_executable = "python3"
 # in the source tree, e.g. for third party source trees.
 secondary_source = "//build/secondary/"
 
-# These are the targets to check headers for by default. The files in targets
-# matching these patterns (see "gn help label_pattern" for format) will have
+# These are the targets to skip header checking by default. The files in targets
+# matching these patterns (see "gn help label_pattern" for format) will not have
 # their includes checked for proper dependencies when you run either
 # "gn check" or "gn gen --check".
-check_targets = [
-  "//api/*",
-  "//audio/*",
-  "//backup/*",
-  "//call/*",
-  "//common_audio/*",
-  "//common_video/*",
-  "//examples/*",
-  "//logging/*",
-  "//media/*",
-  "//modules/*",
-  "//net/*",
-  "//p2p/*",
-  "//pc/*",
-  "//rtc_base/*",
-  "//rtc_tools/*",
-  "//sdk/*",
-  "//stats/*",
-  "//system_wrappers/*",
-  "//test/*",
-  "//video/*",
-  "//third_party/libyuv/*",
-]
+no_check_targets = [ "//third_party/icu/*" ]
 
 # These are the list of GN files that run exec_script. This whitelist exists
 # to force additional review for new uses of exec_script, which is strongly

BUILD.gn

@@ -520,6 +520,10 @@ if (!build_with_chromium) {
     rtc_executable("webrtc_lib_link_test") {
       testonly = true
 
+      # This target is used for checking to link, so do not check dependencies
+      # on gn check.
+      check_includes = false  # no-presubmit-check TODO(bugs.webrtc.org/12785)
+
       sources = [ "webrtc_lib_link_test.cc" ]
       deps = [
         # NOTE: Don't add deps here. If this test fails to link, it means you