mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-20 09:07:52 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Enable rotation tests marked as expected failures

Browse source 
Bug: webrtc:8382
Change-Id: I70ba0cdbdc9bd1e3014a379deb9ae39795e60d1f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290899
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39247}
This commit is contained in:
Andreas Pehrson 2023-01-13 14:23:27 +01:00 committed by WebRTC LUCI CQ
parent 65ab5fd728
commit 97d1c34769
1 changed files with 0 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
sdk/objc/unittests/RTCCameraVideoCapturerTests.mm
View file

@ -186,9 +186,6 @@ CMSampleBufferRef createTestSampleBufferRef() {
[self.delegateMock verify]; [self.delegateMock verify];
} }
#if 0
// See crbug.com/1404878 - XCTExpectFailure and XCTSkip are considered failures
- (void)testDelegateCallbackWithValidBufferAndOrientationUpdate { - (void)testDelegateCallbackWithValidBufferAndOrientationUpdate {
#if TARGET_OS_IPHONE #if TARGET_OS_IPHONE
XCTExpectFailure(@"Setting orientation on UIDevice is not supported"); XCTExpectFailure(@"Setting orientation on UIDevice is not supported");
@ -295,8 +292,6 @@ CMSampleBufferRef createTestSampleBufferRef() {
withOrientation:UIDeviceOrientationLandscapeRight]; withOrientation:UIDeviceOrientationLandscapeRight];
} }
#endif
- (void)setExif:(CMSampleBufferRef)sampleBuffer { - (void)setExif:(CMSampleBufferRef)sampleBuffer {
rtc::ScopedCFTypeRef<CFMutableDictionaryRef> exif(CFDictionaryCreateMutable( rtc::ScopedCFTypeRef<CFMutableDictionaryRef> exif(CFDictionaryCreateMutable(
kCFAllocatorDefault, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks)); kCFAllocatorDefault, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));
@ -304,9 +299,6 @@ CMSampleBufferRef createTestSampleBufferRef() {
CMSetAttachment(sampleBuffer, CFSTR("{Exif}"), exif.get(), kCMAttachmentMode_ShouldPropagate); CMSetAttachment(sampleBuffer, CFSTR("{Exif}"), exif.get(), kCMAttachmentMode_ShouldPropagate);
} }
#if 0
// See crbug.com/1404878 - XCTExpectFailure and XCTSkip are considered failures
- (void)testRotationFrame { - (void)testRotationFrame {
#if TARGET_OS_IPHONE #if TARGET_OS_IPHONE
// Mock the AVCaptureConnection as we will get the camera position from the connection's // Mock the AVCaptureConnection as we will get the camera position from the connection's
@ -352,8 +344,6 @@ CMSampleBufferRef createTestSampleBufferRef() {
#endif #endif
} }
#endif
- (void)testImageExif { - (void)testImageExif {
#if TARGET_OS_IPHONE #if TARGET_OS_IPHONE
CMSampleBufferRef sampleBuffer = createTestSampleBufferRef(); CMSampleBufferRef sampleBuffer = createTestSampleBufferRef();