mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00
Remove unused TRACE_*COPY* macros
#rtc_fixit Bug: webrtc:15867 Change-Id: Id9198a5df4c4e5a4dace69cc8487b6ded40137ca Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/342721 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Evan Shrubsole <eshr@google.com> Cr-Commit-Position: refs/heads/main@{#41890}
This commit is contained in:
Evan Shrubsole
WebRTC LUCI CQ
parent
c6e502e362
commit
9849bfdb10
1 changed files with 0 additions and 144 deletions
|
|
@ -127,21 +127,6 @@
|
|||
// application. In Chrome's case, navigating to about:tracing will turn on
|
||||
// tracing and display data collected across all active processes.
|
||||
//
|
||||
//
|
||||
// Memory scoping note:
|
||||
// Tracing copies the pointers, not the string content, of the strings passed
|
||||
// in for category, name, and arg_names. Thus, the following code will
|
||||
// cause problems:
|
||||
// char* str = strdup("impprtantName");
|
||||
// TRACE_EVENT_INSTANT0("SUBSYSTEM", str); // BAD!
|
||||
// free(str); // Trace system now has dangling pointer
|
||||
//
|
||||
// To avoid this issue with the `name` and `arg_name` parameters, use the
|
||||
// TRACE_EVENT_COPY_XXX overloads of the macros at additional runtime overhead.
|
||||
// Notes: The category must always be in a long-lived char* (i.e. static const).
|
||||
// The `arg_values`, when used, are always deep copied with the _COPY
|
||||
// macros.
|
||||
//
|
||||
// When are string argument values copied:
|
||||
// const char* arg_values are only referenced by default:
|
||||
// TRACE_EVENT1("category", "name",
|
||||
|
|
@ -201,17 +186,6 @@
|
|||
INTERNAL_TRACE_EVENT_ADD(TRACE_EVENT_PHASE_INSTANT, category, name, \
|
||||
TRACE_EVENT_FLAG_NONE, arg1_name, arg1_val, \
|
||||
arg2_name, arg2_val)
|
||||
#define TRACE_EVENT_COPY_INSTANT0(category, name) \
|
||||
INTERNAL_TRACE_EVENT_ADD(TRACE_EVENT_PHASE_INSTANT, category, name, \
|
||||
TRACE_EVENT_FLAG_COPY)
|
||||
#define TRACE_EVENT_COPY_INSTANT1(category, name, arg1_name, arg1_val) \
|
||||
INTERNAL_TRACE_EVENT_ADD(TRACE_EVENT_PHASE_INSTANT, category, name, \
|
||||
TRACE_EVENT_FLAG_COPY, arg1_name, arg1_val)
|
||||
#define TRACE_EVENT_COPY_INSTANT2(category, name, arg1_name, arg1_val, \
|
||||
arg2_name, arg2_val) \
|
||||
INTERNAL_TRACE_EVENT_ADD(TRACE_EVENT_PHASE_INSTANT, category, name, \
|
||||
TRACE_EVENT_FLAG_COPY, arg1_name, arg1_val, \
|
||||
arg2_name, arg2_val)
|
||||
|
||||
// Records a single BEGIN event called "name" immediately, with 0, 1 or 2
|
||||
// associated arguments. If the category is not enabled, then this
|
||||
|
|
@ -229,17 +203,6 @@
|
|||
INTERNAL_TRACE_EVENT_ADD(TRACE_EVENT_PHASE_BEGIN, category, name, \
|
||||
TRACE_EVENT_FLAG_NONE, arg1_name, arg1_val, \
|
||||
arg2_name, arg2_val)
|
||||
#define TRACE_EVENT_COPY_BEGIN0(category, name) \
|
||||
INTERNAL_TRACE_EVENT_ADD(TRACE_EVENT_PHASE_BEGIN, category, name, \
|
||||
TRACE_EVENT_FLAG_COPY)
|
||||
#define TRACE_EVENT_COPY_BEGIN1(category, name, arg1_name, arg1_val) \
|
||||
INTERNAL_TRACE_EVENT_ADD(TRACE_EVENT_PHASE_BEGIN, category, name, \
|
||||
TRACE_EVENT_FLAG_COPY, arg1_name, arg1_val)
|
||||
#define TRACE_EVENT_COPY_BEGIN2(category, name, arg1_name, arg1_val, \
|
||||
arg2_name, arg2_val) \
|
||||
INTERNAL_TRACE_EVENT_ADD(TRACE_EVENT_PHASE_BEGIN, category, name, \
|
||||
TRACE_EVENT_FLAG_COPY, arg1_name, arg1_val, \
|
||||
arg2_name, arg2_val)
|
||||
|
||||
// Records a single END event for "name" immediately. If the category
|
||||
// is not enabled, then this does nothing.
|
||||
|
|
@ -256,17 +219,6 @@
|
|||
INTERNAL_TRACE_EVENT_ADD(TRACE_EVENT_PHASE_END, category, name, \
|
||||
TRACE_EVENT_FLAG_NONE, arg1_name, arg1_val, \
|
||||
arg2_name, arg2_val)
|
||||
#define TRACE_EVENT_COPY_END0(category, name) \
|
||||
INTERNAL_TRACE_EVENT_ADD(TRACE_EVENT_PHASE_END, category, name, \
|
||||
TRACE_EVENT_FLAG_COPY)
|
||||
#define TRACE_EVENT_COPY_END1(category, name, arg1_name, arg1_val) \
|
||||
INTERNAL_TRACE_EVENT_ADD(TRACE_EVENT_PHASE_END, category, name, \
|
||||
TRACE_EVENT_FLAG_COPY, arg1_name, arg1_val)
|
||||
#define TRACE_EVENT_COPY_END2(category, name, arg1_name, arg1_val, arg2_name, \
|
||||
arg2_val) \
|
||||
INTERNAL_TRACE_EVENT_ADD(TRACE_EVENT_PHASE_END, category, name, \
|
||||
TRACE_EVENT_FLAG_COPY, arg1_name, arg1_val, \
|
||||
arg2_name, arg2_val)
|
||||
|
||||
// Records the value of a counter called "name" immediately. Value
|
||||
// must be representable as a 32 bit integer.
|
||||
|
|
@ -276,10 +228,6 @@
|
|||
INTERNAL_TRACE_EVENT_ADD(TRACE_EVENT_PHASE_COUNTER, category, name, \
|
||||
TRACE_EVENT_FLAG_NONE, "value", \
|
||||
static_cast<int>(value))
|
||||
#define TRACE_COPY_COUNTER1(category, name, value) \
|
||||
INTERNAL_TRACE_EVENT_ADD(TRACE_EVENT_PHASE_COUNTER, category, name, \
|
||||
TRACE_EVENT_FLAG_COPY, "value", \
|
||||
static_cast<int>(value))
|
||||
|
||||
// Records the values of a multi-parted counter called "name" immediately.
|
||||
// The UI will treat value1 and value2 as parts of a whole, displaying their
|
||||
|
|
@ -292,12 +240,6 @@
|
|||
TRACE_EVENT_FLAG_NONE, value1_name, \
|
||||
static_cast<int>(value1_val), value2_name, \
|
||||
static_cast<int>(value2_val))
|
||||
#define TRACE_COPY_COUNTER2(category, name, value1_name, value1_val, \
|
||||
value2_name, value2_val) \
|
||||
INTERNAL_TRACE_EVENT_ADD(TRACE_EVENT_PHASE_COUNTER, category, name, \
|
||||
TRACE_EVENT_FLAG_COPY, value1_name, \
|
||||
static_cast<int>(value1_val), value2_name, \
|
||||
static_cast<int>(value2_val))
|
||||
|
||||
// Records the value of a counter called "name" immediately. Value
|
||||
// must be representable as a 32 bit integer.
|
||||
|
|
@ -311,10 +253,6 @@
|
|||
INTERNAL_TRACE_EVENT_ADD_WITH_ID(TRACE_EVENT_PHASE_COUNTER, category, name, \
|
||||
id, TRACE_EVENT_FLAG_NONE, "value", \
|
||||
static_cast<int>(value))
|
||||
#define TRACE_COPY_COUNTER_ID1(category, name, id, value) \
|
||||
INTERNAL_TRACE_EVENT_ADD_WITH_ID(TRACE_EVENT_PHASE_COUNTER, category, name, \
|
||||
id, TRACE_EVENT_FLAG_COPY, "value", \
|
||||
static_cast<int>(value))
|
||||
|
||||
// Records the values of a multi-parted counter called "name" immediately.
|
||||
// The UI will treat value1 and value2 as parts of a whole, displaying their
|
||||
|
|
@ -331,12 +269,6 @@
|
|||
id, TRACE_EVENT_FLAG_NONE, value1_name, \
|
||||
static_cast<int>(value1_val), value2_name, \
|
||||
static_cast<int>(value2_val))
|
||||
#define TRACE_COPY_COUNTER_ID2(category, name, id, value1_name, value1_val, \
|
||||
value2_name, value2_val) \
|
||||
INTERNAL_TRACE_EVENT_ADD_WITH_ID(TRACE_EVENT_PHASE_COUNTER, category, name, \
|
||||
id, TRACE_EVENT_FLAG_COPY, value1_name, \
|
||||
static_cast<int>(value1_val), value2_name, \
|
||||
static_cast<int>(value2_val))
|
||||
|
||||
// Records a single ASYNC_BEGIN event called "name" immediately, with 0, 1 or 2
|
||||
// associated arguments. If the category is not enabled, then this
|
||||
|
|
@ -367,18 +299,6 @@
|
|||
INTERNAL_TRACE_EVENT_ADD_WITH_ID(TRACE_EVENT_PHASE_ASYNC_BEGIN, category, \
|
||||
name, id, TRACE_EVENT_FLAG_NONE, arg1_name, \
|
||||
arg1_val, arg2_name, arg2_val)
|
||||
#define TRACE_EVENT_COPY_ASYNC_BEGIN0(category, name, id) \
|
||||
INTERNAL_TRACE_EVENT_ADD_WITH_ID(TRACE_EVENT_PHASE_ASYNC_BEGIN, category, \
|
||||
name, id, TRACE_EVENT_FLAG_COPY)
|
||||
#define TRACE_EVENT_COPY_ASYNC_BEGIN1(category, name, id, arg1_name, arg1_val) \
|
||||
INTERNAL_TRACE_EVENT_ADD_WITH_ID(TRACE_EVENT_PHASE_ASYNC_BEGIN, category, \
|
||||
name, id, TRACE_EVENT_FLAG_COPY, arg1_name, \
|
||||
arg1_val)
|
||||
#define TRACE_EVENT_COPY_ASYNC_BEGIN2(category, name, id, arg1_name, arg1_val, \
|
||||
arg2_name, arg2_val) \
|
||||
INTERNAL_TRACE_EVENT_ADD_WITH_ID(TRACE_EVENT_PHASE_ASYNC_BEGIN, category, \
|
||||
name, id, TRACE_EVENT_FLAG_COPY, arg1_name, \
|
||||
arg1_val, arg2_name, arg2_val)
|
||||
|
||||
// Records a single ASYNC_STEP event for `step` immediately. If the category
|
||||
// is not enabled, then this does nothing. The `name` and `id` must match the
|
||||
|
|
@ -393,15 +313,6 @@
|
|||
INTERNAL_TRACE_EVENT_ADD_WITH_ID(TRACE_EVENT_PHASE_ASYNC_STEP, category, \
|
||||
name, id, TRACE_EVENT_FLAG_NONE, "step", \
|
||||
step, arg1_name, arg1_val)
|
||||
#define TRACE_EVENT_COPY_ASYNC_STEP0(category, name, id, step) \
|
||||
INTERNAL_TRACE_EVENT_ADD_WITH_ID(TRACE_EVENT_PHASE_ASYNC_STEP, category, \
|
||||
name, id, TRACE_EVENT_FLAG_COPY, "step", \
|
||||
step)
|
||||
#define TRACE_EVENT_COPY_ASYNC_STEP1(category, name, id, step, arg1_name, \
|
||||
arg1_val) \
|
||||
INTERNAL_TRACE_EVENT_ADD_WITH_ID(TRACE_EVENT_PHASE_ASYNC_STEP, category, \
|
||||
name, id, TRACE_EVENT_FLAG_COPY, "step", \
|
||||
step, arg1_name, arg1_val)
|
||||
|
||||
// Records a single ASYNC_END event for "name" immediately. If the category
|
||||
// is not enabled, then this does nothing.
|
||||
|
|
@ -417,18 +328,6 @@
|
|||
INTERNAL_TRACE_EVENT_ADD_WITH_ID(TRACE_EVENT_PHASE_ASYNC_END, category, \
|
||||
name, id, TRACE_EVENT_FLAG_NONE, arg1_name, \
|
||||
arg1_val, arg2_name, arg2_val)
|
||||
#define TRACE_EVENT_COPY_ASYNC_END0(category, name, id) \
|
||||
INTERNAL_TRACE_EVENT_ADD_WITH_ID(TRACE_EVENT_PHASE_ASYNC_END, category, \
|
||||
name, id, TRACE_EVENT_FLAG_COPY)
|
||||
#define TRACE_EVENT_COPY_ASYNC_END1(category, name, id, arg1_name, arg1_val) \
|
||||
INTERNAL_TRACE_EVENT_ADD_WITH_ID(TRACE_EVENT_PHASE_ASYNC_END, category, \
|
||||
name, id, TRACE_EVENT_FLAG_COPY, arg1_name, \
|
||||
arg1_val)
|
||||
#define TRACE_EVENT_COPY_ASYNC_END2(category, name, id, arg1_name, arg1_val, \
|
||||
arg2_name, arg2_val) \
|
||||
INTERNAL_TRACE_EVENT_ADD_WITH_ID(TRACE_EVENT_PHASE_ASYNC_END, category, \
|
||||
name, id, TRACE_EVENT_FLAG_COPY, arg1_name, \
|
||||
arg1_val, arg2_name, arg2_val)
|
||||
|
||||
////////////////////////////////////////////////////////////////////////////////
|
||||
// Implementation specific tracing API definitions.
|
||||
|
|
@ -541,7 +440,6 @@
|
|||
|
||||
// Flags for changing the behavior of TRACE_EVENT_API_ADD_TRACE_EVENT.
|
||||
#define TRACE_EVENT_FLAG_NONE (static_cast<unsigned char>(0))
|
||||
#define TRACE_EVENT_FLAG_COPY (static_cast<unsigned char>(1 << 0))
|
||||
#define TRACE_EVENT_FLAG_HAS_ID (static_cast<unsigned char>(1 << 1))
|
||||
#define TRACE_EVENT_FLAG_MANGLE_ID (static_cast<unsigned char>(1 << 2))
|
||||
|
||||
|
|
@ -811,7 +709,6 @@ class TraceEndOnScopeClose {
|
|||
do { \
|
||||
} while (0)
|
||||
|
||||
#define TRACE_STR_COPY(str) RTC_NOOP()
|
||||
|
||||
#define TRACE_DISABLED_BY_DEFAULT(name) "disabled-by-default-" name
|
||||
|
||||
|
|
@ -829,54 +726,29 @@ class TraceEndOnScopeClose {
|
|||
arg2_val) \
|
||||
RTC_NOOP()
|
||||
|
||||
#define TRACE_EVENT_COPY_INSTANT0(category, name) RTC_NOOP()
|
||||
#define TRACE_EVENT_COPY_INSTANT1(category, name, arg1_name, arg1_val) \
|
||||
RTC_NOOP()
|
||||
#define TRACE_EVENT_COPY_INSTANT2(category, name, arg1_name, arg1_val, \
|
||||
arg2_name, arg2_val) \
|
||||
RTC_NOOP()
|
||||
|
||||
#define TRACE_EVENT_BEGIN0(category, name) RTC_NOOP()
|
||||
#define TRACE_EVENT_BEGIN1(category, name, arg1_name, arg1_val) RTC_NOOP()
|
||||
#define TRACE_EVENT_BEGIN2(category, name, arg1_name, arg1_val, arg2_name, \
|
||||
arg2_val) \
|
||||
RTC_NOOP()
|
||||
#define TRACE_EVENT_COPY_BEGIN0(category, name) RTC_NOOP()
|
||||
#define TRACE_EVENT_COPY_BEGIN1(category, name, arg1_name, arg1_val) RTC_NOOP()
|
||||
#define TRACE_EVENT_COPY_BEGIN2(category, name, arg1_name, arg1_val, \
|
||||
arg2_name, arg2_val) \
|
||||
RTC_NOOP()
|
||||
|
||||
#define TRACE_EVENT_END0(category, name) RTC_NOOP()
|
||||
#define TRACE_EVENT_END1(category, name, arg1_name, arg1_val) RTC_NOOP()
|
||||
#define TRACE_EVENT_END2(category, name, arg1_name, arg1_val, arg2_name, \
|
||||
arg2_val) \
|
||||
RTC_NOOP()
|
||||
#define TRACE_EVENT_COPY_END0(category, name) RTC_NOOP()
|
||||
#define TRACE_EVENT_COPY_END1(category, name, arg1_name, arg1_val) RTC_NOOP()
|
||||
#define TRACE_EVENT_COPY_END2(category, name, arg1_name, arg1_val, arg2_name, \
|
||||
arg2_val) \
|
||||
RTC_NOOP()
|
||||
|
||||
#define TRACE_COUNTER1(category, name, value) RTC_NOOP()
|
||||
#define TRACE_COPY_COUNTER1(category, name, value) RTC_NOOP()
|
||||
|
||||
#define TRACE_COUNTER2(category, name, value1_name, value1_val, value2_name, \
|
||||
value2_val) \
|
||||
RTC_NOOP()
|
||||
#define TRACE_COPY_COUNTER2(category, name, value1_name, value1_val, \
|
||||
value2_name, value2_val) \
|
||||
RTC_NOOP()
|
||||
|
||||
#define TRACE_COUNTER_ID1(category, name, id, value) RTC_NOOP()
|
||||
#define TRACE_COPY_COUNTER_ID1(category, name, id, value) RTC_NOOP()
|
||||
|
||||
#define TRACE_COUNTER_ID2(category, name, id, value1_name, value1_val, \
|
||||
value2_name, value2_val) \
|
||||
RTC_NOOP()
|
||||
#define TRACE_COPY_COUNTER_ID2(category, name, id, value1_name, value1_val, \
|
||||
value2_name, value2_val) \
|
||||
RTC_NOOP()
|
||||
|
||||
#define TRACE_EVENT_ASYNC_BEGIN0(category, name, id) RTC_NOOP()
|
||||
#define TRACE_EVENT_ASYNC_BEGIN1(category, name, id, arg1_name, arg1_val) \
|
||||
|
|
@ -884,20 +756,10 @@ class TraceEndOnScopeClose {
|
|||
#define TRACE_EVENT_ASYNC_BEGIN2(category, name, id, arg1_name, arg1_val, \
|
||||
arg2_name, arg2_val) \
|
||||
RTC_NOOP()
|
||||
#define TRACE_EVENT_COPY_ASYNC_BEGIN0(category, name, id) RTC_NOOP()
|
||||
#define TRACE_EVENT_COPY_ASYNC_BEGIN1(category, name, id, arg1_name, arg1_val) \
|
||||
RTC_NOOP()
|
||||
#define TRACE_EVENT_COPY_ASYNC_BEGIN2(category, name, id, arg1_name, arg1_val, \
|
||||
arg2_name, arg2_val) \
|
||||
RTC_NOOP()
|
||||
|
||||
#define TRACE_EVENT_ASYNC_STEP0(category, name, id, step) RTC_NOOP()
|
||||
#define TRACE_EVENT_ASYNC_STEP1(category, name, id, step, arg1_name, arg1_val) \
|
||||
RTC_NOOP()
|
||||
#define TRACE_EVENT_COPY_ASYNC_STEP0(category, name, id, step) RTC_NOOP()
|
||||
#define TRACE_EVENT_COPY_ASYNC_STEP1(category, name, id, step, arg1_name, \
|
||||
arg1_val) \
|
||||
RTC_NOOP()
|
||||
|
||||
#define TRACE_EVENT_ASYNC_END0(category, name, id) RTC_NOOP()
|
||||
#define TRACE_EVENT_ASYNC_END1(category, name, id, arg1_name, arg1_val) \
|
||||
|
|
@ -905,12 +767,6 @@ class TraceEndOnScopeClose {
|
|||
#define TRACE_EVENT_ASYNC_END2(category, name, id, arg1_name, arg1_val, \
|
||||
arg2_name, arg2_val) \
|
||||
RTC_NOOP()
|
||||
#define TRACE_EVENT_COPY_ASYNC_END0(category, name, id) RTC_NOOP()
|
||||
#define TRACE_EVENT_COPY_ASYNC_END1(category, name, id, arg1_name, arg1_val) \
|
||||
RTC_NOOP()
|
||||
#define TRACE_EVENT_COPY_ASYNC_END2(category, name, id, arg1_name, arg1_val, \
|
||||
arg2_name, arg2_val) \
|
||||
RTC_NOOP()
|
||||
|
||||
#define TRACE_EVENT_API_GET_CATEGORY_ENABLED ""
|
||||
|
||||
|
|
|
|||
Loading…
Reference in a new issue