mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-19 16:47:50 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Reenable some iOS tests.

Browse source 
These tests were failing on mac-11 machines but seem to do fine on mac-12.

Bug: webrtc:13989,webrtc:13991
Change-Id: I11fb2302046fbb06b0824a4adc543a446405991b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/272363
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#37843}
This commit is contained in:
Jeremy Leconte 2022-08-19 09:29:55 +02:00 committed by WebRTC LUCI CQ
parent 0385618a56
commit 99d7d6b4f6
2 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
examples/objc/AppRTCMobile/tests/ARDAppClient_xctest.mm
View file

@ -161,8 +161,6 @@
#pragma mark - Cases #pragma mark - Cases
// TODO(crbug.com/webrtc/13991): testSession crashes when running on simulators.
#if !TARGET_IPHONE_SIMULATOR
// Tests that an ICE connection is established between two ARDAppClient objects // Tests that an ICE connection is established between two ARDAppClient objects
// where one is set up as a caller and the other the answerer. Network // where one is set up as a caller and the other the answerer. Network
// components are mocked out and messages are relayed directly from object to // components are mocked out and messages are relayed directly from object to
@ -229,7 +227,6 @@
} }
}]; }];
} }
#endif
// Test to see that we get a local video connection // Test to see that we get a local video connection
// Note this will currently pass even when no camera is connected as a local // Note this will currently pass even when no camera is connected as a local

5
sdk/objc/unittests/RTCPeerConnectionFactory_xctest.m
View file

@ -131,11 +131,10 @@
XCTAssertTrue(true, "Expect test does not crash"); XCTAssertTrue(true, "Expect test does not crash");
} }
// TODO(crbug.com/webrtc/13989): Remove call to CreateSender in senderWithKind.
#if !TARGET_IPHONE_SIMULATOR
- (void)testRTCRtpSenderLifetime { - (void)testRTCRtpSenderLifetime {
@autoreleasepool { @autoreleasepool {
RTC_OBJC_TYPE(RTCConfiguration) *config = [[RTC_OBJC_TYPE(RTCConfiguration) alloc] init]; RTC_OBJC_TYPE(RTCConfiguration) *config = [[RTC_OBJC_TYPE(RTCConfiguration) alloc] init];
config.sdpSemantics = RTCSdpSemanticsPlanB;
RTC_OBJC_TYPE(RTCMediaConstraints) *constraints = RTC_OBJC_TYPE(RTCMediaConstraints) *constraints =
[[RTC_OBJC_TYPE(RTCMediaConstraints) alloc] initWithMandatoryConstraints:@{} [[RTC_OBJC_TYPE(RTCMediaConstraints) alloc] initWithMandatoryConstraints:@{}
optionalConstraints:nil]; optionalConstraints:nil];
@ -163,6 +162,7 @@
- (void)testRTCRtpReceiverLifetime { - (void)testRTCRtpReceiverLifetime {
@autoreleasepool { @autoreleasepool {
RTC_OBJC_TYPE(RTCConfiguration) *config = [[RTC_OBJC_TYPE(RTCConfiguration) alloc] init]; RTC_OBJC_TYPE(RTCConfiguration) *config = [[RTC_OBJC_TYPE(RTCConfiguration) alloc] init];
config.sdpSemantics = RTCSdpSemanticsPlanB;
RTC_OBJC_TYPE(RTCMediaConstraints) *constraints = RTC_OBJC_TYPE(RTCMediaConstraints) *constraints =
[[RTC_OBJC_TYPE(RTCMediaConstraints) alloc] initWithMandatoryConstraints:@{} [[RTC_OBJC_TYPE(RTCMediaConstraints) alloc] initWithMandatoryConstraints:@{}
optionalConstraints:nil]; optionalConstraints:nil];
@ -206,7 +206,6 @@
XCTAssertTrue(true, "Expect test does not crash"); XCTAssertTrue(true, "Expect test does not crash");
} }
#endif
- (void)testAudioSourceLifetime { - (void)testAudioSourceLifetime {
@autoreleasepool { @autoreleasepool {