From a0f5f60c93edcf4105c38f1648f4ba1546a7db0c Mon Sep 17 00:00:00 2001 From: Per Kjellander Date: Wed, 10 Jan 2018 15:57:32 +0000 Subject: [PATCH] Revert "Revert "Make some more targets publicly visible"" This reverts commit 55d1809d0d73592a1ddf4f0fb02ce7444fa066aa. Reason for revert: This cl was not the culprit for breaking chrome content/renderer deps. Original change's description: > Revert "Make some more targets publicly visible" > > This reverts commit 60d179256213c7516808aff827637cab8a47de89. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > Make some more targets publicly visible > > > > To fix build errors introduced by > > https://webrtc-review.googlesource.com/c/src/+/24140 > > > > BUG=webrtc:8254 > > NOTRY=true > > > > Change-Id: I9cdf9cee39735368af78291134dbad70aebb7195 > > Reviewed-on: https://webrtc-review.googlesource.com/38660 > > Commit-Queue: Karl Wiberg > > Reviewed-by: Mirko Bonadei > > Cr-Commit-Position: refs/heads/master@{#21552} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I475ac382218fa77d33abc595f0773275d715a28e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38740 > Reviewed-by: Per Kjellander > Commit-Queue: Per Kjellander > Cr-Commit-Position: refs/heads/master@{#21554} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: If8e9b7b1c934ec4b5ed61941c845e62e43bef97e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38841 Reviewed-by: Per Kjellander Commit-Queue: Per Kjellander Cr-Commit-Position: refs/heads/master@{#21559} --- media/BUILD.gn | 1 + modules/video_capture/BUILD.gn | 1 + rtc_tools/BUILD.gn | 1 + 3 files changed, 3 insertions(+) diff --git a/media/BUILD.gn b/media/BUILD.gn index 24d9c2e5d0..f9e2dc1771 100644 --- a/media/BUILD.gn +++ b/media/BUILD.gn @@ -139,6 +139,7 @@ rtc_static_library("rtc_constants") { } rtc_static_library("rtc_internal_video_codecs") { + visibility = [ "*" ] defines = [] libs = [] deps = [ diff --git a/modules/video_capture/BUILD.gn b/modules/video_capture/BUILD.gn index 63785646f0..0696db82c7 100644 --- a/modules/video_capture/BUILD.gn +++ b/modules/video_capture/BUILD.gn @@ -13,6 +13,7 @@ import("../../webrtc.gni") # 'video_capture_internal_impl' depending on whether they want to # use the internal capturer. rtc_static_library("video_capture_module") { + visibility = [ "*" ] sources = [ "device_info_impl.cc", "device_info_impl.h", diff --git a/rtc_tools/BUILD.gn b/rtc_tools/BUILD.gn index ac7e44d8f4..40664872c0 100644 --- a/rtc_tools/BUILD.gn +++ b/rtc_tools/BUILD.gn @@ -199,6 +199,7 @@ if (!build_with_chromium) { } rtc_static_library("event_log_visualizer_utils") { + visibility = [ "*" ] sources = [ "event_log_visualizer/analyzer.cc", "event_log_visualizer/analyzer.h",