mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 05:40:42 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

PRESUBMIT: Improve error message about checkdeps.

Browse source 
This will make it easier for new project members to know what's
causing the error.

BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2770883004
Cr-Commit-Position: refs/heads/master@{#17358}
This commit is contained in:
kjellander 2017-03-23 03:47:05 -07:00 committed by Commit bot
parent 590d482dd4
commit a7066a35ba
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
PRESUBMIT.py
View file

@ -409,13 +409,18 @@ def _CheckUnwantedDependencies(input_api, output_api):
results = [] results = []
if error_descriptions: if error_descriptions:
results.append(output_api.PresubmitError( results.append(output_api.PresubmitError(
'You added one or more #includes that violate checkdeps rules.', 'You added one or more #includes that violate checkdeps rules.\n'
'Check that the DEPS files in these locations contain valid rules.\n'
'See https://cs.chromium.org/chromium/src/buildtools/checkdeps/ for '
'more details about checkdeps.',
error_descriptions)) error_descriptions))
if warning_descriptions: if warning_descriptions:
results.append(output_api.PresubmitPromptOrNotify( results.append(output_api.PresubmitPromptOrNotify(
'You added one or more #includes of files that are temporarily\n' 'You added one or more #includes of files that are temporarily\n'
'allowed but being removed. Can you avoid introducing the\n' 'allowed but being removed. Can you avoid introducing the\n'
'#include? See relevant DEPS file(s) for details and contacts.', '#include? See relevant DEPS file(s) for details and contacts.\n'
'See https://cs.chromium.org/chromium/src/buildtools/checkdeps/ for '
'more details about checkdeps.',
warning_descriptions)) warning_descriptions))
return results return results