mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-15 14:50:39 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Delete deprecated AudioDecoderOpus::MakeAudioDecoder

Browse source 
Bug: webrtc:356878416
Change-Id: I2dc830c46fb5eece3b93a0354fd1e8a323a5e2ec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/360841
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Jakob Ivarsson‎ <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42880}
This commit is contained in:
Danil Chapovalov 2024-08-28 17:06:40 +02:00 committed by WebRTC LUCI CQ
parent f2487c0d4f
commit a99bf7fa84
3 changed files with 0 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
api/audio_codecs/opus/BUILD.gn
View file

@ -63,12 +63,10 @@ rtc_library("audio_decoder_opus") {
]
deps = [
"..:audio_codecs_api",
"../../../api:field_trials_view",
"../../../modules/audio_coding:webrtc_opus",
"../../../rtc_base:checks",
"../../../rtc_base/system:rtc_export",
"../../environment",
"../../transport:field_trial_based_config",
"//third_party/abseil-cpp/absl/strings",
"//third_party/abseil-cpp/absl/types:optional",
]

19
api/audio_codecs/opus/audio_decoder_opus.cc
View file

@ -21,8 +21,6 @@
#include "api/audio_codecs/audio_codec_pair_id.h"
#include "api/audio_codecs/audio_decoder.h"
#include "api/audio_codecs/audio_format.h"
#include "api/field_trials_view.h"
#include "api/transport/field_trial_based_config.h"
#include "modules/audio_coding/codecs/opus/audio_decoder_opus.h"
#include "rtc_base/checks.h"
@ -91,21 +89,4 @@ std::unique_ptr<AudioDecoder> AudioDecoderOpus::MakeAudioDecoder(
env.field_trials(), config.num_channels, config.sample_rate_hz);
}
std::unique_ptr<AudioDecoder> AudioDecoderOpus::MakeAudioDecoder(
Config config,
absl::optional<AudioCodecPairId> /*codec_pair_id*/,
const FieldTrialsView* field_trials) {
if (!config.IsOk()) {
RTC_DCHECK_NOTREACHED();
return nullptr;
}
if (field_trials == nullptr) {
return std::make_unique<AudioDecoderOpusImpl>(
FieldTrialBasedConfig(), config.num_channels, config.sample_rate_hz);
} else {
return std::make_unique<AudioDecoderOpusImpl>(
*field_trials, config.num_channels, config.sample_rate_hz);
}
}
} // namespace webrtc

8
api/audio_codecs/opus/audio_decoder_opus.h
View file

@ -19,7 +19,6 @@
#include "api/audio_codecs/audio_decoder.h"
#include "api/audio_codecs/audio_format.h"
#include "api/environment/environment.h"
#include "api/field_trials_view.h"
#include "rtc_base/system/rtc_export.h"
namespace webrtc {
@ -35,13 +34,6 @@ struct RTC_EXPORT AudioDecoderOpus {
static absl::optional<Config> SdpToConfig(const SdpAudioFormat& audio_format);
static void AppendSupportedDecoders(std::vector<AudioCodecSpec>* specs);
[[deprecated("bugs.webrtc.org/356878416")]] //
static std::unique_ptr<AudioDecoder>
MakeAudioDecoder(
Config config,
absl::optional<AudioCodecPairId> codec_pair_id = absl::nullopt,
const FieldTrialsView* field_trials = nullptr);
static std::unique_ptr<AudioDecoder> MakeAudioDecoder(const Environment& env,
Config config);
static std::unique_ptr<AudioDecoder> MakeAudioDecoder(