mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 05:40:42 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Make EncodeResultCallback rvalue ref-qualified.

Browse source 
Bug: b/336978562
Change-Id: Icc9be7a5ad095304bf68e19ffedca77d8bc1810c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349266
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42285}
This commit is contained in:
philipel 2024-04-26 15:22:10 +02:00 committed by WebRTC LUCI CQ
parent cf4764e062
commit a9d7c19011
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
api/video_codecs/libaom_av1_encoder_factory.cc
View file

@ -14,6 +14,7 @@
#include <map> #include <map>
#include <memory> #include <memory>
#include <string> #include <string>
#include <utility>
#include <vector> #include <vector>
#include "absl/algorithm/container.h" #include "absl/algorithm/container.h"
@ -619,7 +620,7 @@ aom_svc_params_t GetSvcParams(
void DoErrorCallback(std::vector<FrameEncodeSettings>& frame_settings) { void DoErrorCallback(std::vector<FrameEncodeSettings>& frame_settings) {
for (FrameEncodeSettings& settings : frame_settings) { for (FrameEncodeSettings& settings : frame_settings) {
if (settings.result_callback) { if (settings.result_callback) {
settings.result_callback({}); std::move(settings.result_callback)({});
// To avoid invoking any callback more than once. // To avoid invoking any callback more than once.
settings.result_callback = {}; settings.result_callback = {};
} }
@ -788,7 +789,7 @@ void LibaomAv1Encoder::Encode(
return; return;
} else { } else {
RTC_CHECK(settings.result_callback); RTC_CHECK(settings.result_callback);
settings.result_callback(result); std::move(settings.result_callback)(result);
// To avoid invoking any callback more than once. // To avoid invoking any callback more than once.
settings.result_callback = {}; settings.result_callback = {};
} }

2
api/video_codecs/video_encoder_interface.h
View file

@ -52,7 +52,7 @@ class VideoEncoderInterface {
}; };
using EncodeResult = absl::variant<EncodingError, EncodedData>; using EncodeResult = absl::variant<EncodingError, EncodedData>;
using EncodeResultCallback = using EncodeResultCallback =
absl::AnyInvocable<void(const EncodeResult& result)>; absl::AnyInvocable<void(const EncodeResult& result) &&>;
struct FrameEncodeSettings { struct FrameEncodeSettings {
struct Cbr { struct Cbr {