mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-19 00:27:51 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

[frame-buffer3] Enable WebRTC-LegacyFrameIdJumpBehavior by default

Browse source 
When disabled, the test ResolutionAdaptsToAvailableBandwidth fails when
using frame buffer3. It is not clear if that is a problem with the test
or if that behaviour is required, and thus it is safer to have this
enabled by default and experiment with turning it off in the future.

Change-Id: I7a6ae14c37a0cdc3e203f39f6cc0c3ad87038a60
Bug: webrtc:13343
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247700
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35764}
This commit is contained in:
Evan Shrubsole 2022-01-21 14:51:18 +01:00 committed by WebRTC LUCI CQ
parent 95701503f2
commit b39fce858f
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/video_coding/frame_buffer3.cc
View file

@ -65,7 +65,7 @@ bool IsLastFrameInTemporalUnit(const FrameIteratorT& it) {
FrameBuffer::FrameBuffer(int max_size, int max_decode_history) FrameBuffer::FrameBuffer(int max_size, int max_decode_history)
: legacy_frame_id_jump_behavior_( : legacy_frame_id_jump_behavior_(
field_trial::IsEnabled("WebRTC-LegacyFrameIdJumpBehavior")), !field_trial::IsDisabled("WebRTC-LegacyFrameIdJumpBehavior")),
max_size_(max_size), max_size_(max_size),
decoded_frame_history_(max_decode_history) {} decoded_frame_history_(max_decode_history) {}

6
modules/video_coding/frame_buffer3_unittest.cc
View file

@ -275,7 +275,8 @@ TEST(FrameBuffer3Test, InterleavedStream) {
TEST(FrameBuffer3Test, LegacyFrameIdJumpBehavior) { TEST(FrameBuffer3Test, LegacyFrameIdJumpBehavior) {
{ {
// WebRTC-LegacyFrameIdJumpBehavior is disabled by default. test::ScopedFieldTrials field_trial(
"WebRTC-LegacyFrameIdJumpBehavior/Disabled/");
FrameBuffer buffer(/*max_frame_slots=*/10, /*max_decode_history=*/100); FrameBuffer buffer(/*max_frame_slots=*/10, /*max_decode_history=*/100);
buffer.InsertFrame(Builder().Time(20).Id(3).AsLast().Build()); buffer.InsertFrame(Builder().Time(20).Id(3).AsLast().Build());
@ -286,8 +287,7 @@ TEST(FrameBuffer3Test, LegacyFrameIdJumpBehavior) {
} }
{ {
test::ScopedFieldTrials field_trial( // WebRTC-LegacyFrameIdJumpBehavior is disabled by default.
"WebRTC-LegacyFrameIdJumpBehavior/Enabled/");
FrameBuffer buffer(/*max_frame_slots=*/10, /*max_decode_history=*/100); FrameBuffer buffer(/*max_frame_slots=*/10, /*max_decode_history=*/100);
buffer.InsertFrame(Builder().Time(20).Id(3).AsLast().Build()); buffer.InsertFrame(Builder().Time(20).Id(3).AsLast().Build());