From c381c33767d424a25c4c44b54fb6b7e96e1a0e67 Mon Sep 17 00:00:00 2001 From: Tony Herre Date: Thu, 13 Apr 2023 07:37:55 +0000 Subject: [PATCH] Make TransformableVideoFrameInterface::SetMetadata pure virtual Bug: webrtc:14709 Change-Id: I9e131a041e80c1774b982f61197a0499b97c6ae7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301162 Reviewed-by: Stefan Holmer Commit-Queue: Stefan Holmer Auto-Submit: Tony Herre Reviewed-by: Stefan Holmer Cr-Commit-Position: refs/heads/main@{#39845} --- api/frame_transformer_interface.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/api/frame_transformer_interface.h b/api/frame_transformer_interface.h index fd60b87596..2f7b139f9f 100644 --- a/api/frame_transformer_interface.h +++ b/api/frame_transformer_interface.h @@ -60,9 +60,7 @@ class TransformableVideoFrameInterface : public TransformableFrameInterface { virtual VideoFrameMetadata Metadata() const = 0; - // TODO(https://crbug.com/webrtc/14709): Make pure virtual when Chromium MOCK - // has implemented this. - virtual void SetMetadata(const VideoFrameMetadata&) {} + virtual void SetMetadata(const VideoFrameMetadata&) = 0; }; // Extends the TransformableFrameInterface to expose audio-specific information.