From c95ad5fe9dcba3fa4a1e9625670bc2cd6c31dfff Mon Sep 17 00:00:00 2001 From: Danil Chapovalov Date: Mon, 8 Jan 2024 18:05:51 +0100 Subject: [PATCH] Delete deprecated FecControllerFactoryInterface::CreateFecController variant Bug: webrtc:10335 Change-Id: Id113133a9bf73830f16ac889e5e80633b5055279 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/333841 Commit-Queue: Danil Chapovalov Reviewed-by: Harald Alvestrand Cr-Commit-Position: refs/heads/main@{#41491} --- api/BUILD.gn | 1 - api/fec_controller.h | 16 +--------------- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/api/BUILD.gn b/api/BUILD.gn index 6cec2974fc..341b39cdbe 100644 --- a/api/BUILD.gn +++ b/api/BUILD.gn @@ -890,7 +890,6 @@ rtc_source_set("fec_controller_api") { deps = [ "../modules:module_fec_api", - "../rtc_base:checks", "environment", "video:video_frame_type", ] diff --git a/api/fec_controller.h b/api/fec_controller.h index 6f45ccbde3..5c2aa3b786 100644 --- a/api/fec_controller.h +++ b/api/fec_controller.h @@ -17,7 +17,6 @@ #include "api/environment/environment.h" #include "api/video/video_frame_type.h" #include "modules/include/module_fec_types.h" -#include "rtc_base/checks.h" namespace webrtc { // TODO(yinwa): work in progress. API in class FecController should not be @@ -91,21 +90,8 @@ class FecControllerFactoryInterface { public: virtual ~FecControllerFactoryInterface() = default; - // TODO: bugs.webrtc.org/10335 - make pure virtual when implemented by derived - // classes. virtual std::unique_ptr CreateFecController( - const Environment& env) { -#pragma clang diagnostic push -#pragma clang diagnostic ignored "-Wdeprecated-declarations" - return CreateFecController(); -#pragma clang diagnostic pop - } - - // TODO: bugs.webrtc.org/10335 - delete when implementation is removed from - // the derived classes. - [[deprecated]] virtual std::unique_ptr CreateFecController() { - RTC_CHECK_NOTREACHED(); - } + const Environment& env) = 0; }; } // namespace webrtc