mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 13:50:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

sdp: cleanup WebRTC-PreventSsrcGroupsWithUnexpectedSize killswitch

Browse source 
the rollout has happened a while ago with no issues requiring the use
of the killswitch

BUG=chromium:40066610

Change-Id: I2c8148976a1da219ebbfbe6908224b6384348194
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/348823
Commit-Queue: Philipp Hancke <phancke@meta.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42164}
This commit is contained in:
Philipp Hancke 2024-04-23 10:29:54 -07:00 committed by WebRTC LUCI CQ
parent e92b143eea
commit c97d434ec4
2 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
experiments/field_trials.py
View file

@ -105,9 +105,6 @@ ACTIVE_FIELD_TRIALS: FrozenSet[FieldTrial] = frozenset([
FieldTrial('WebRTC-PermuteTlsClientHello', FieldTrial('WebRTC-PermuteTlsClientHello',
'webrtc:15467', 'webrtc:15467',
date(2024, 7, 1)), date(2024, 7, 1)),
FieldTrial('WebRTC-PreventSsrcGroupsWithUnexpectedSize',
'chromium:1459124',
date(2024, 4, 1)),
FieldTrial('WebRTC-ReceiveBufferSize', FieldTrial('WebRTC-ReceiveBufferSize',
'webrtc:15585', 'webrtc:15585',
date(2024, 4, 1)), date(2024, 4, 1)),

5
pc/sdp_offer_answer.cc
View file

@ -3576,10 +3576,9 @@ RTCError SdpOfferAnswerHandler::ValidateSessionDescription(
return error; return error;
} }
// TODO(crbug.com/1459124): remove killswitch after rollout. // Validate the SSRC groups.
error = ValidateSsrcGroups(*sdesc->description()); error = ValidateSsrcGroups(*sdesc->description());
if (!error.ok() && if (!error.ok()) {
!pc_->trials().IsDisabled("WebRTC-PreventSsrcGroupsWithUnexpectedSize")) {
return error; return error;
} }