mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-17 23:57:59 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

peerconnection: add was-ever-connected boolean flag

Browse source 
and report some metrics only on the first connection state
change to connected

BUG=webrtc:12383

Change-Id: I32908e23c51aa40730be8e534793829268d4e25e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208583
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#33333}
This commit is contained in:
Philipp Hancke 2021-02-24 11:04:30 +01:00 committed by Commit Bot
parent 2ee9415a8c
commit cd0373f013
2 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pc/peer_connection.cc
View file

@ -1797,9 +1797,11 @@ void PeerConnection::SetConnectionState(
connection_state_ = new_state; connection_state_ = new_state;
Observer()->OnConnectionChange(new_state); Observer()->OnConnectionChange(new_state);
// The connection state change to connected usually happens once per if (new_state == PeerConnectionState::kConnected && !was_ever_connected_) {
// connection which makes it a good point to report metrics. was_ever_connected_ = true;
if (new_state == PeerConnectionState::kConnected) {
// The first connection state change to connected happens once per
// connection which makes it a good point to report metrics.
// Record bundle-policy from configuration. Done here from // Record bundle-policy from configuration. Done here from
// connectionStateChange to limit to actually established connections. // connectionStateChange to limit to actually established connections.
BundlePolicyUsage policy = kBundlePolicyUsageMax; BundlePolicyUsage policy = kBundlePolicyUsageMax;

4
pc/peer_connection.h
View file

@ -707,6 +707,10 @@ class PeerConnection : public PeerConnectionInternal,
std::unique_ptr<RtpTransmissionManager> rtp_manager_; std::unique_ptr<RtpTransmissionManager> rtp_manager_;
rtc::WeakPtrFactory<PeerConnection> weak_factory_; rtc::WeakPtrFactory<PeerConnection> weak_factory_;
// Did the connectionState ever change to `connected`?
// Used to gather metrics only the first such state change.
bool was_ever_connected_ RTC_GUARDED_BY(signaling_thread()) = false;
}; };
} // namespace webrtc } // namespace webrtc