mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-12 21:30:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add -Wctad-maybe-unsupported.

Browse source 
This will allow to catch issues (like the one that caused the revert
[1]) at CQ time.

[1] - https://webrtc-review.googlesource.com/c/src/+/273486

Bug: None
Change-Id: Ib12c15dcdc3e2a358d40c1a2ffabfbf42274e978
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273660
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37982}
This commit is contained in:
Mirko Bonadei 2022-09-01 18:19:42 +02:00 committed by WebRTC LUCI CQ
parent 7baa63ff9c
commit ce03028216
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
BUILD.gn
View file

@ -318,9 +318,15 @@ config("common_config") {
defines += [ "WEBRTC_EXCLUDE_AUDIO_PROCESSING_MODULE" ]
}
# TODO(webrtc:13219): Fix -Wshadow instances and enable.
if (is_clang) {
cflags += [ "-Wno-shadow" ]
cflags += [
# TODO(webrtc:13219): Fix -Wshadow instances and enable.
"-Wno-shadow",
# See https://reviews.llvm.org/D56731 for details about this
# warning.
"-Wctad-maybe-unsupported",
]
}
if (build_with_chromium) {

3
modules/desktop_capture/linux/wayland/shared_screencast_stream.cc
View file

@ -850,7 +850,8 @@ SharedScreenCastStream::~SharedScreenCastStream() {}
rtc::scoped_refptr<SharedScreenCastStream>
SharedScreenCastStream::CreateDefault() {
// Explicit new, to access non-public constructor.
return rtc::scoped_refptr(new SharedScreenCastStream());
return rtc::scoped_refptr<SharedScreenCastStream>(
new SharedScreenCastStream());
}
bool SharedScreenCastStream::StartScreenCastStream(uint32_t stream_node_id) {