mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-19 08:37:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use FakeRenderer when fuzzing

Browse source 
Do not fuzz with real renderer because it is merely frame copying and
doesn't exercise different control flows. This CL also improved fuzzing
performance and fixed a memory leak.

Bug: chromium:952606, chromium:1009077, chromium:1009073
Change-Id: I77c6f2581db82bfd95edb18e5f0e541a94c78208
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156620
Commit-Queue: Benjamin Wright <benwright@webrtc.org>
Reviewed-by: Benjamin Wright <benwright@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29522}
This commit is contained in:
Kuang-che Wu 2019-10-12 10:42:33 +08:00 committed by Commit Bot
parent 785d4c40ca
commit ce9da1636a
3 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
test/fuzzers/utils/BUILD.gn
View file

@ -35,7 +35,7 @@ rtc_source_set("rtp_replayer") {
"../../../test:rtp_test_utils", "../../../test:rtp_test_utils",
"../../../test:run_test", "../../../test:run_test",
"../../../test:run_test_interface", "../../../test:run_test_interface",
"../../../test:test_renderer", "../../../test:test_common",
"../../../test:test_support", "../../../test:test_support",
"../../../test:video_test_common", "../../../test:video_test_common",
] ]

5
test/fuzzers/utils/rtp_replayer.cc
View file

@ -21,6 +21,7 @@
#include "test/call_config_utils.h" #include "test/call_config_utils.h"
#include "test/encoder_settings.h" #include "test/encoder_settings.h"
#include "test/fake_decoder.h" #include "test/fake_decoder.h"
#include "test/fake_videorenderer.h"
#include "test/rtp_file_reader.h" #include "test/rtp_file_reader.h"
#include "test/rtp_header_parser.h" #include "test/rtp_header_parser.h"
@ -111,9 +112,7 @@ void RtpReplayer::SetupVideoStreams(
decoder.decoder_factory = stream_state->decoder_factory.get(); decoder.decoder_factory = stream_state->decoder_factory.get();
} }
// Create the window to display the rendered video. stream_state->sinks.emplace_back(new test::FakeVideoRenderer());
stream_state->sinks.emplace_back(
test::VideoRenderer::Create("Fuzzing WebRTC Video Config", 640, 480));
// Create a receive stream for this config. // Create a receive stream for this config.
receive_config.renderer = stream_state->sinks.back().get(); receive_config.renderer = stream_state->sinks.back().get();
stream_state->receive_streams.emplace_back( stream_state->receive_streams.emplace_back(

1
test/fuzzers/utils/rtp_replayer.h
View file

@ -28,7 +28,6 @@
#include "test/null_transport.h" #include "test/null_transport.h"
#include "test/rtp_file_reader.h" #include "test/rtp_file_reader.h"
#include "test/test_video_capturer.h" #include "test/test_video_capturer.h"
#include "test/video_renderer.h"
namespace webrtc { namespace webrtc {
namespace test { namespace test {