mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 05:40:42 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove expired WebRTC-Bwe-SubtractAdditionalBackoffTerm

Browse source 
Bug: webrtc:13402
Change-Id: Ia5a741fb7af753fbcbf00ece4f8e321c9b2655a2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/345721
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42028}
This commit is contained in:
Emil Lundmark 2024-04-04 13:51:19 +02:00 committed by WebRTC LUCI CQ
parent 91b1cfbfa0
commit d5c107d5d4
3 changed files with 2 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
experiments/field_trials.py
View file

@ -53,9 +53,6 @@ ACTIVE_FIELD_TRIALS: FrozenSet[FieldTrial] = frozenset([
FieldTrial('WebRTC-Av1-GetEncoderInfoOverride', FieldTrial('WebRTC-Av1-GetEncoderInfoOverride',
'webrtc:14931', 'webrtc:14931',
date(2024, 4, 1)), date(2024, 4, 1)),
FieldTrial('WebRTC-Bwe-SubtractAdditionalBackoffTerm',
'webrtc:13402',
date(2024, 4, 1)),
FieldTrial('WebRTC-DataChannelMessageInterleaving', FieldTrial('WebRTC-DataChannelMessageInterleaving',
'webrtc:5696', 'webrtc:5696',
date(2024, 10, 1)), date(2024, 10, 1)),

7
modules/remote_bitrate_estimator/aimd_rate_control.cc
View file

@ -79,9 +79,7 @@ AimdRateControl::AimdRateControl(const FieldTrialsView& key_value_config,
rtt_(kDefaultRtt), rtt_(kDefaultRtt),
send_side_(send_side), send_side_(send_side),
no_bitrate_increase_in_alr_( no_bitrate_increase_in_alr_(
key_value_config.IsEnabled("WebRTC-DontIncreaseDelayBasedBweInAlr")), key_value_config.IsEnabled("WebRTC-DontIncreaseDelayBasedBweInAlr")) {
subtract_additional_backoff_term_(!key_value_config.IsDisabled(
"WebRTC-Bwe-SubtractAdditionalBackoffTerm")) {
ParseFieldTrial( ParseFieldTrial(
{&disable_estimate_bounded_increase_, {&disable_estimate_bounded_increase_,
&use_current_estimate_as_min_upper_bound_}, &use_current_estimate_as_min_upper_bound_},
@ -289,8 +287,7 @@ void AimdRateControl::ChangeBitrate(const RateControlInput& input,
// Set bit rate to something slightly lower than the measured throughput // Set bit rate to something slightly lower than the measured throughput
// to get rid of any self-induced delay. // to get rid of any self-induced delay.
decreased_bitrate = estimated_throughput * beta_; decreased_bitrate = estimated_throughput * beta_;
if (decreased_bitrate > DataRate::KilobitsPerSec(5) && if (decreased_bitrate > DataRate::KilobitsPerSec(5)) {
subtract_additional_backoff_term_) {
decreased_bitrate -= DataRate::KilobitsPerSec(5); decreased_bitrate -= DataRate::KilobitsPerSec(5);
} }

2
modules/remote_bitrate_estimator/aimd_rate_control.h
View file

@ -103,8 +103,6 @@ class AimdRateControl {
// Allow the delay based estimate to only increase as long as application // Allow the delay based estimate to only increase as long as application
// limited region (alr) is not detected. // limited region (alr) is not detected.
const bool no_bitrate_increase_in_alr_; const bool no_bitrate_increase_in_alr_;
// If true, subtract an additional 5kbps when backing off.
const bool subtract_additional_backoff_term_;
// If "Disabled", estimated link capacity is not used as upper bound. // If "Disabled", estimated link capacity is not used as upper bound.
FieldTrialFlag disable_estimate_bounded_increase_{"Disabled"}; FieldTrialFlag disable_estimate_bounded_increase_{"Disabled"};
FieldTrialParameter<bool> use_current_estimate_as_min_upper_bound_{"c_upper", FieldTrialParameter<bool> use_current_estimate_as_min_upper_bound_{"c_upper",