From d7d5c0c1db92877ed952ad7b01fa0f9de928dfa3 Mon Sep 17 00:00:00 2001 From: Jeremy Leconte Date: Tue, 19 Mar 2024 10:02:21 +0100 Subject: [PATCH] Disable InjectDependencyDescriptor on Windows. Change-Id: I6dd715063cc5b75b378e35b85f88974936229150 Bug: webrtc:15876 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/343341 Reviewed-by: Tomas Gunnarsson Commit-Queue: Jeremy Leconte Cr-Commit-Position: refs/heads/main@{#41928} --- pc/peer_connection_field_trial_tests.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/pc/peer_connection_field_trial_tests.cc b/pc/peer_connection_field_trial_tests.cc index ae566359e4..3379e6723d 100644 --- a/pc/peer_connection_field_trial_tests.cc +++ b/pc/peer_connection_field_trial_tests.cc @@ -142,7 +142,13 @@ TEST_F(PeerConnectionFieldTrialTest, EnableDependencyDescriptorAdvertised) { // Tests that dependency descriptor RTP header extensions can be exchanged // via SDP munging, even if dependency descriptor field trial is disabled. -TEST_F(PeerConnectionFieldTrialTest, InjectDependencyDescriptor) { +#ifdef WEBRTC_WIN +// TODO: crbug.com/webrtc/15876 - Test is flaky on Windows machines. +#define MAYBE_InjectDependencyDescriptor DISABLED_InjectDependencyDescriptor +#else +#define MAYBE_InjectDependencyDescriptor InjectDependencyDescriptor +#endif +TEST_F(PeerConnectionFieldTrialTest, MAYBE_InjectDependencyDescriptor) { std::unique_ptr field_trials = std::make_unique( "WebRTC-DependencyDescriptorAdvertised/Disabled/");