From e14abcb20bedbfa4de8215816f3e94757d4519be Mon Sep 17 00:00:00 2001 From: Danil Chapovalov Date: Mon, 27 Mar 2023 17:08:01 +0200 Subject: [PATCH] Cleanup FieldTrialView Delete alias WebRtcKeyValueConfig as unused Replace .find() == 0 with absl::StartsWith per clang-tidy recommendation https://clang.llvm.org/extra/clang-tidy/checks/abseil/string-find-startswith.html Bug: webrtc:10335 Change-Id: I1f09c262844c0678a8d8c0d0d3274df3d947737c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299181 Reviewed-by: Tomas Gunnarsson Auto-Submit: Danil Chapovalov Commit-Queue: Tomas Gunnarsson Cr-Commit-Position: refs/heads/main@{#39690} --- api/field_trials_view.h | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/api/field_trials_view.h b/api/field_trials_view.h index 45e6f7899b..d8df84574d 100644 --- a/api/field_trials_view.h +++ b/api/field_trials_view.h @@ -12,6 +12,7 @@ #include +#include "absl/strings/match.h" #include "absl/strings/string_view.h" #include "rtc_base/system/rtc_export.h" @@ -32,18 +33,14 @@ class RTC_EXPORT FieldTrialsView { virtual std::string Lookup(absl::string_view key) const = 0; bool IsEnabled(absl::string_view key) const { - return Lookup(key).find("Enabled") == 0; + return absl::StartsWith(Lookup(key), "Enabled"); } bool IsDisabled(absl::string_view key) const { - return Lookup(key).find("Disabled") == 0; + return absl::StartsWith(Lookup(key), "Disabled"); } }; -// TODO(bugs.webrtc.org/10335): Remove once all migrated to -// api/field_trials_view.h -typedef FieldTrialsView WebRtcKeyValueConfig; - } // namespace webrtc #endif // API_FIELD_TRIALS_VIEW_H_