mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-12 21:30:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Removing non-const RtpSenderInterface::GetParameters().

Browse source 
This removes the temporary non-const method that was kept in the code to
enable backwards compatibility while we fix downstream project dependencies.

Bug: webrtc:10251
Change-Id: Ie221af1d3b0f19112449d61e0f357a833f7a8b18
Reviewed-on: https://webrtc-review.googlesource.com/c/123561
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Amit Hilbuch <amithi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26824}
This commit is contained in:
Amit Hilbuch 2019-02-20 10:40:12 -08:00 committed by Commit Bot
parent f58e43e2a6
commit e1e789b6ac
2 changed files with 1 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
api/rtp_sender_interface.cc
View file

@ -30,16 +30,4 @@ rtc::scoped_refptr<DtlsTransportInterface> RtpSenderInterface::dtls_transport()
return nullptr;
}
// TODO(amithi): Fix downstream dependencies and make GetParameters pure
// virtual.
RtpParameters RtpSenderInterface::GetParameters() {
const RtpSenderInterface* interface = this;
return interface->GetParameters();
}
RtpParameters RtpSenderInterface::GetParameters() const {
RtpSenderInterface* interface = const_cast<RtpSenderInterface*>(this);
return interface->GetParameters();
}
} // namespace webrtc

4
api/rtp_sender_interface.h
View file

@ -67,9 +67,7 @@ class RtpSenderInterface : public rtc::RefCountInterface {
// TODO(orphis): Make it pure virtual once Chrome has updated
virtual std::vector<RtpEncodingParameters> init_send_encodings() const;
// TODO(amithi): Fix downstream dependecies and remove the non-const method.
virtual RtpParameters GetParameters();
virtual RtpParameters GetParameters() const;
virtual RtpParameters GetParameters() const = 0;
// Note that only a subset of the parameters can currently be changed. See
// rtpparameters.h
// The encodings are in increasing quality order for simulcast.