mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 05:40:42 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove unnecessary overload

Browse source 
Bug: webrtc:13579
Change-Id: Ib8e9f3fb085718a140b5a6199cb75e7da22e4fe5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271202
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37747}
This commit is contained in:
Ali Tofigh 2022-08-10 19:24:23 +02:00 committed by WebRTC LUCI CQ
parent e04d0fa1b2
commit e2d829cf77
2 changed files with 0 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
modules/audio_processing/include/audio_processing.h
View file

@ -623,15 +623,6 @@ class RTC_EXPORT AudioProcessing : public rtc::RefCountInterface {
// return value of true indicates that the file has been // return value of true indicates that the file has been
// sucessfully opened, while a value of false indicates that // sucessfully opened, while a value of false indicates that
// opening the file failed. // opening the file failed.
//
// TODO(webrtc:13579): Remove std::string version once downstream users have
// implemented the absl::string_view version.
virtual bool CreateAndAttachAecDump(const std::string& file_name,
int64_t max_log_size_bytes,
rtc::TaskQueue* worker_queue) {
return CreateAndAttachAecDump(absl::string_view(file_name),
max_log_size_bytes, worker_queue);
}
virtual bool CreateAndAttachAecDump(absl::string_view file_name, virtual bool CreateAndAttachAecDump(absl::string_view file_name,
int64_t max_log_size_bytes, int64_t max_log_size_bytes,
rtc::TaskQueue* worker_queue) = 0; rtc::TaskQueue* worker_queue) = 0;

6
modules/audio_processing/include/mock_audio_processing.h
View file

@ -151,12 +151,6 @@ class MockAudioProcessing : public AudioProcessing {
MOCK_METHOD(void, set_stream_key_pressed, (bool key_pressed), (override)); MOCK_METHOD(void, set_stream_key_pressed, (bool key_pressed), (override));
MOCK_METHOD(void, set_stream_analog_level, (int), (override)); MOCK_METHOD(void, set_stream_analog_level, (int), (override));
MOCK_METHOD(int, recommended_stream_analog_level, (), (const, override)); MOCK_METHOD(int, recommended_stream_analog_level, (), (const, override));
MOCK_METHOD(bool,
CreateAndAttachAecDump,
(const std::string& file_name,
int64_t max_log_size_bytes,
rtc::TaskQueue* worker_queue),
(override));
MOCK_METHOD(bool, MOCK_METHOD(bool,
CreateAndAttachAecDump, CreateAndAttachAecDump,
(absl::string_view file_name, (absl::string_view file_name,