mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-12 21:30:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Replace RTC_DEPRECATED with ABSL_DEPRECATED

Browse source 
This remove webrtc-specific macro that has no reason to be webrtc specific
ABSL_DEPRECATED takes a message parameter encouraging to write text how class or function is deprecated.

Bug: webrtc:12484
Change-Id: I89f1398f91dacadc37f7db469dcd985e3724e444
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208282
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33314}
This commit is contained in:
Danil Chapovalov 2021-02-22 12:43:39 +01:00 committed by Commit Bot
parent 8ef1d7b1f9
commit e904161cec
50 changed files with 63 additions and 142 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
api/BUILD.gn
View file

@ -206,7 +206,6 @@ rtc_library("libjingle_peerconnection_api") {
"../modules/audio_processing:audio_processing_statistics",
"../rtc_base",
"../rtc_base:checks",
"../rtc_base:deprecation",
"../rtc_base:ip_address",
"../rtc_base:rtc_base_approved",
"../rtc_base:socket_address",

1
api/DEPS
View file

@ -45,7 +45,6 @@ specific_include_rules = {
"+rtc_base/system/rtc_export.h",
"+rtc_base/system/rtc_export_template.h",
"+rtc_base/units/unit_base.h",
"+rtc_base/deprecation.h",
],
"array_view\.h": [

1
api/audio_codecs/BUILD.gn
View file

@ -33,7 +33,6 @@ rtc_library("audio_codecs_api") {
"..:bitrate_allocation",
"..:scoped_refptr",
"../../rtc_base:checks",
"../../rtc_base:deprecation",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:sanitizer",
"../../rtc_base/system:rtc_export",

10
api/audio_codecs/audio_encoder.h
View file

@ -16,12 +16,12 @@
#include <utility>
#include <vector>
#include "absl/base/attributes.h"
#include "absl/types/optional.h"
#include "api/array_view.h"
#include "api/call/bitrate_allocation.h"
#include "api/units/time_delta.h"
#include "rtc_base/buffer.h"
#include "rtc_base/deprecation.h"
namespace webrtc {
@ -182,12 +182,11 @@ class AudioEncoder {
// implementation does nothing.
virtual void SetMaxPlaybackRate(int frequency_hz);
// This is to be deprecated. Please use |OnReceivedTargetAudioBitrate|
// instead.
// Tells the encoder what average bitrate we'd like it to produce. The
// encoder is free to adjust or disregard the given bitrate (the default
// implementation does the latter).
RTC_DEPRECATED virtual void SetTargetBitrate(int target_bps);
ABSL_DEPRECATED("Use OnReceivedTargetAudioBitrate instead")
virtual void SetTargetBitrate(int target_bps);
// Causes this encoder to let go of any other encoders it contains, and
// returns a pointer to an array where they are stored (which is required to
@ -210,7 +209,8 @@ class AudioEncoder {
virtual void OnReceivedUplinkPacketLossFraction(
float uplink_packet_loss_fraction);
RTC_DEPRECATED virtual void OnReceivedUplinkRecoverablePacketLossFraction(
ABSL_DEPRECATED("")
virtual void OnReceivedUplinkRecoverablePacketLossFraction(
float uplink_recoverable_packet_loss_fraction);
// Provides target audio bitrate to this encoder to allow it to adapt.

1
api/jsep.h
View file

@ -28,7 +28,6 @@
#include "absl/types/optional.h"
#include "api/rtc_error.h"
#include "rtc_base/deprecation.h"
#include "rtc_base/ref_count.h"
#include "rtc_base/system/rtc_export.h"

1
api/jsep_session_description.h
View file

@ -23,7 +23,6 @@
#include "api/jsep.h"
#include "api/jsep_ice_candidate.h"
#include "rtc_base/constructor_magic.h"
#include "rtc_base/deprecation.h"
namespace cricket {
class SessionDescription;

1
api/rtp_receiver_interface.h
View file

@ -26,7 +26,6 @@
#include "api/rtp_parameters.h"
#include "api/scoped_refptr.h"
#include "api/transport/rtp/rtp_source.h"
#include "rtc_base/deprecation.h"
#include "rtc_base/ref_count.h"
#include "rtc_base/system/rtc_export.h"

7
api/rtp_transceiver_interface.h
View file

@ -14,6 +14,7 @@
#include <string>
#include <vector>
#include "absl/base/attributes.h"
#include "absl/types/optional.h"
#include "api/array_view.h"
#include "api/media_types.h"
@ -111,8 +112,8 @@ class RTC_EXPORT RtpTransceiverInterface : public rtc::RefCountInterface {
// https://w3c.github.io/webrtc-pc/#dom-rtcrtptransceiver-direction
// TODO(hta): Deprecate SetDirection without error and rename
// SetDirectionWithError to SetDirection, remove default implementations.
RTC_DEPRECATED virtual void SetDirection(
RtpTransceiverDirection new_direction);
ABSL_DEPRECATED("Use SetDirectionWithError instead")
virtual void SetDirection(RtpTransceiverDirection new_direction);
virtual RTCError SetDirectionWithError(RtpTransceiverDirection new_direction);
// The current_direction attribute indicates the current direction negotiated
@ -140,7 +141,7 @@ class RTC_EXPORT RtpTransceiverInterface : public rtc::RefCountInterface {
// This is an internal function, and is exposed for historical reasons.
// https://w3c.github.io/webrtc-pc/#dfn-stop-the-rtcrtptransceiver
virtual void StopInternal();
RTC_DEPRECATED virtual void Stop();
ABSL_DEPRECATED("Use StopStandard instead") virtual void Stop();
// The SetCodecPreferences method overrides the default codec preferences used
// by WebRTC for this transceiver.

3
api/transport/BUILD.gn
View file

@ -33,7 +33,6 @@ rtc_library("network_control") {
deps = [
":webrtc_key_value_config",
"../../rtc_base:deprecation",
"../rtc_event_log",
"../units:data_rate",
"../units:data_size",
@ -89,8 +88,8 @@ rtc_library("goog_cc") {
":webrtc_key_value_config",
"..:network_state_predictor_api",
"../../modules/congestion_controller/goog_cc",
"../../rtc_base:deprecation",
]
absl_deps = [ "//third_party/abseil-cpp/absl/base:core_headers" ]
}
rtc_source_set("sctp_transport_factory_interface") {

9
api/transport/goog_cc_factory.h
View file

@ -12,9 +12,9 @@
#define API_TRANSPORT_GOOG_CC_FACTORY_H_
#include <memory>
#include "absl/base/attributes.h"
#include "api/network_state_predictor.h"
#include "api/transport/network_control.h"
#include "rtc_base/deprecation.h"
namespace webrtc {
class RtcEventLog;
@ -31,8 +31,8 @@ class GoogCcNetworkControllerFactory
: public NetworkControllerFactoryInterface {
public:
GoogCcNetworkControllerFactory() = default;
explicit RTC_DEPRECATED GoogCcNetworkControllerFactory(
RtcEventLog* event_log);
ABSL_DEPRECATED("")
explicit GoogCcNetworkControllerFactory(RtcEventLog* event_log);
explicit GoogCcNetworkControllerFactory(
NetworkStatePredictorFactoryInterface* network_state_predictor_factory);
@ -49,7 +49,8 @@ class GoogCcNetworkControllerFactory
// Deprecated, use GoogCcFactoryConfig to enable feedback only mode instead.
// Factory to create packet feedback only GoogCC, this can be used for
// connections providing packet receive time feedback but no other reports.
class RTC_DEPRECATED GoogCcFeedbackNetworkControllerFactory
class ABSL_DEPRECATED("use GoogCcFactoryConfig instead")
GoogCcFeedbackNetworkControllerFactory
: public GoogCcNetworkControllerFactory {
public:
explicit GoogCcFeedbackNetworkControllerFactory(RtcEventLog* event_log);

1
api/transport/network_types.h
View file

@ -19,7 +19,6 @@
#include "api/units/data_size.h"
#include "api/units/time_delta.h"
#include "api/units/timestamp.h"
#include "rtc_base/deprecation.h"
namespace webrtc {

1
api/video/BUILD.gn
View file

@ -142,7 +142,6 @@ rtc_library("encoded_image") {
"..:rtp_packet_info",
"..:scoped_refptr",
"../../rtc_base:checks",
"../../rtc_base:deprecation",
"../../rtc_base:rtc_base_approved",
"../../rtc_base/system:rtc_export",
]

5
api/video/encoded_image.h
View file

@ -16,6 +16,7 @@
#include <map>
#include <utility>
#include "absl/base/attributes.h"
#include "absl/types/optional.h"
#include "api/rtp_packet_infos.h"
#include "api/scoped_refptr.h"
@ -26,7 +27,6 @@
#include "api/video/video_rotation.h"
#include "api/video/video_timing.h"
#include "rtc_base/checks.h"
#include "rtc_base/deprecation.h"
#include "rtc_base/ref_count.h"
#include "rtc_base/system/rtc_export.h"
@ -73,7 +73,8 @@ class RTC_EXPORT EncodedImage {
EncodedImage();
EncodedImage(EncodedImage&&);
EncodedImage(const EncodedImage&);
RTC_DEPRECATED EncodedImage(uint8_t* buffer, size_t length, size_t capacity);
ABSL_DEPRECATED("")
EncodedImage(uint8_t* buffer, size_t length, size_t capacity);
~EncodedImage();

2
api/video_codecs/video_encoder.h
View file

@ -364,7 +364,7 @@ class RTC_EXPORT VideoEncoder {
// TODO(bugs.webrtc.org/10720): After updating downstream projects and posting
// an announcement to discuss-webrtc, remove the three-parameters variant
// and make the two-parameters variant pure-virtual.
/* RTC_DEPRECATED */ virtual int32_t InitEncode(
/* ABSL_DEPRECATED("bugs.webrtc.org/10720") */ virtual int32_t InitEncode(
const VideoCodec* codec_settings,
int32_t number_of_cores,
size_t max_payload_size);

2
audio/utility/BUILD.gn
View file

@ -26,10 +26,10 @@ rtc_library("audio_frame_operations") {
"../../api/audio:audio_frame_api",
"../../common_audio",
"../../rtc_base:checks",
"../../rtc_base:deprecation",
"../../rtc_base:rtc_base_approved",
"../../system_wrappers:field_trial",
]
absl_deps = [ "//third_party/abseil-cpp/absl/base:core_headers" ]
}
if (rtc_include_tests) {

8
audio/utility/audio_frame_operations.h
View file

@ -14,8 +14,8 @@
#include <stddef.h>
#include <stdint.h>
#include "absl/base/attributes.h"
#include "api/audio/audio_frame.h"
#include "rtc_base/deprecation.h"
namespace webrtc {
@ -36,12 +36,14 @@ class AudioFrameOperations {
// |frame.num_channels_| will be updated. This version checks for sufficient
// buffer size and that |num_channels_| is mono. Use UpmixChannels
// instead. TODO(bugs.webrtc.org/8649): remove.
RTC_DEPRECATED static int MonoToStereo(AudioFrame* frame);
ABSL_DEPRECATED("bugs.webrtc.org/8649")
static int MonoToStereo(AudioFrame* frame);
// |frame.num_channels_| will be updated. This version checks that
// |num_channels_| is stereo. Use DownmixChannels
// instead. TODO(bugs.webrtc.org/8649): remove.
RTC_DEPRECATED static int StereoToMono(AudioFrame* frame);
ABSL_DEPRECATED("bugs.webrtc.org/8649")
static int StereoToMono(AudioFrame* frame);
// Downmixes 4 channels |src_audio| to stereo |dst_audio|. This is an in-place
// operation, meaning |src_audio| and |dst_audio| may point to the same

1
logging/BUILD.gn
View file

@ -342,7 +342,6 @@ if (rtc_enable_protobuf) {
"../modules/rtp_rtcp",
"../modules/rtp_rtcp:rtp_rtcp_format",
"../rtc_base:checks",
"../rtc_base:deprecation",
"../rtc_base:ignore_wundef",
"../rtc_base:protobuf_utils",
"../rtc_base:rtc_base_approved",

3
logging/rtc_event_log/rtc_event_log_parser.h
View file

@ -19,6 +19,7 @@
#include <utility> // pair
#include <vector>
#include "absl/base/attributes.h"
#include "api/rtc_event_log/rtc_event_log.h"
#include "call/video_receive_stream.h"
#include "call/video_send_stream.h"
@ -296,7 +297,7 @@ class ParsedRtcEventLog {
return error_ + " failed at " + file_ + " line " + std::to_string(line_);
}
RTC_DEPRECATED operator bool() const { return ok(); }
ABSL_DEPRECATED("Use ok() instead") operator bool() const { return ok(); }
private:
ParseStatus() : error_(), file_(), line_(0) {}

1
media/BUILD.gn
View file

@ -242,7 +242,6 @@ rtc_library("rtc_internal_video_codecs") {
"../modules/video_coding/codecs/av1:libaom_av1_decoder",
"../modules/video_coding/codecs/av1:libaom_av1_encoder",
"../rtc_base:checks",
"../rtc_base:deprecation",
"../rtc_base:rtc_base_approved",
"../rtc_base/system:rtc_export",
"../test:fake_video_codecs",

2
modules/audio_coding/BUILD.gn
View file

@ -17,7 +17,6 @@ visibility = [ ":*" ]
rtc_source_set("audio_coding_module_typedefs") {
visibility += [ "*" ]
sources = [ "include/audio_coding_module_typedefs.h" ]
deps = [ "../../rtc_base:deprecation" ]
}
rtc_library("audio_coding") {
@ -52,7 +51,6 @@ rtc_library("audio_coding") {
"../../common_audio:common_audio_c",
"../../rtc_base:audio_format_to_string",
"../../rtc_base:checks",
"../../rtc_base:deprecation",
"../../rtc_base:rtc_base_approved",
"../../rtc_base/synchronization:mutex",
"../../system_wrappers",

2
modules/audio_coding/include/audio_coding_module_typedefs.h
View file

@ -13,8 +13,6 @@
#include <map>
#include "rtc_base/deprecation.h"
namespace webrtc {
///////////////////////////////////////////////////////////////////////////

3
modules/audio_device/BUILD.gn
View file

@ -51,7 +51,6 @@ rtc_source_set("audio_device_api") {
"../../api:scoped_refptr",
"../../api/task_queue",
"../../rtc_base:checks",
"../../rtc_base:deprecation",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:stringutils",
]
@ -171,7 +170,6 @@ rtc_library("audio_device_impl") {
"../../common_audio:common_audio_c",
"../../rtc_base",
"../../rtc_base:checks",
"../../rtc_base:deprecation",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:rtc_task_queue",
"../../rtc_base/synchronization:mutex",
@ -183,6 +181,7 @@ rtc_library("audio_device_impl") {
"../../system_wrappers:metrics",
"../utility",
]
absl_deps = [ "//third_party/abseil-cpp/absl/base:core_headers" ]
if (rtc_include_internal_audio_device && is_ios) {
deps += [ "../../sdk:audio_device" ]
}

5
modules/audio_device/include/audio_device_data_observer.h
View file

@ -14,6 +14,7 @@
#include <stddef.h>
#include <stdint.h>
#include "absl/base/attributes.h"
#include "api/scoped_refptr.h"
#include "api/task_queue/task_queue_factory.h"
#include "modules/audio_device/include/audio_device.h"
@ -48,7 +49,7 @@ rtc::scoped_refptr<AudioDeviceModule> CreateAudioDeviceWithDataObserver(
// Creates an ADMWrapper around an ADM instance that registers
// the provided AudioDeviceDataObserver.
RTC_DEPRECATED
ABSL_DEPRECATED("")
rtc::scoped_refptr<AudioDeviceModule> CreateAudioDeviceWithDataObserver(
rtc::scoped_refptr<AudioDeviceModule> impl,
AudioDeviceDataObserver* observer);
@ -60,7 +61,7 @@ rtc::scoped_refptr<AudioDeviceModule> CreateAudioDeviceWithDataObserver(
std::unique_ptr<AudioDeviceDataObserver> observer);
// Creates an ADM instance with AudioDeviceDataObserver registered.
RTC_DEPRECATED
ABSL_DEPRECATED("")
rtc::scoped_refptr<AudioDeviceModule> CreateAudioDeviceWithDataObserver(
const AudioDeviceModule::AudioLayer audio_layer,
TaskQueueFactory* task_queue_factory,

1
modules/audio_device/include/audio_device_defines.h
View file

@ -16,7 +16,6 @@
#include <string>
#include "rtc_base/checks.h"
#include "rtc_base/deprecation.h"
#include "rtc_base/strings/string_builder.h"
namespace webrtc {

4
modules/audio_processing/BUILD.gn
View file

@ -43,7 +43,6 @@ rtc_library("api") {
"../../api/audio:aec3_config",
"../../api/audio:audio_frame_api",
"../../api/audio:echo_control",
"../../rtc_base:deprecation",
"../../rtc_base:rtc_base_approved",
"../../rtc_base/system:arch",
"../../rtc_base/system:file_wrapper",
@ -119,8 +118,8 @@ rtc_source_set("aec_dump_interface") {
deps = [
":api",
":audio_frame_view",
"../../rtc_base:deprecation",
]
absl_deps = [ "//third_party/abseil-cpp/absl/base:core_headers" ]
}
rtc_library("audio_processing") {
@ -177,7 +176,6 @@ rtc_library("audio_processing") {
"../../common_audio:common_audio_c",
"../../common_audio/third_party/ooura:fft_size_256",
"../../rtc_base:checks",
"../../rtc_base:deprecation",
"../../rtc_base:gtest_prod",
"../../rtc_base:ignore_wundef",
"../../rtc_base:refcount",

5
modules/audio_processing/include/aec_dump.h
View file

@ -15,9 +15,9 @@
#include <string>
#include "absl/base/attributes.h"
#include "modules/audio_processing/include/audio_frame_view.h"
#include "modules/audio_processing/include/audio_processing.h"
#include "rtc_base/deprecation.h"
namespace webrtc {
@ -76,7 +76,8 @@ class AecDump {
// Logs Event::Type INIT message.
virtual void WriteInitMessage(const ProcessingConfig& api_format,
int64_t time_now_ms) = 0;
RTC_DEPRECATED void WriteInitMessage(const ProcessingConfig& api_format) {
ABSL_DEPRECATED("")
void WriteInitMessage(const ProcessingConfig& api_format) {
WriteInitMessage(api_format, 0);
}

1
modules/audio_processing/include/audio_processing.h
View file

@ -32,7 +32,6 @@
#include "modules/audio_processing/include/config.h"
#include "rtc_base/arraysize.h"
#include "rtc_base/constructor_magic.h"
#include "rtc_base/deprecation.h"
#include "rtc_base/ref_count.h"
#include "rtc_base/system/file_wrapper.h"
#include "rtc_base/system/rtc_export.h"

3
modules/rtp_rtcp/BUILD.gn
View file

@ -116,7 +116,6 @@ rtc_library("rtp_rtcp_format") {
"../../api/video:video_rtp_headers",
"../../common_video",
"../../rtc_base:checks",
"../../rtc_base:deprecation",
"../../rtc_base:divide_round",
"../../rtc_base:rtc_base_approved",
"../../system_wrappers",
@ -284,7 +283,6 @@ rtc_library("rtp_rtcp") {
"../../logging:rtc_event_rtp_rtcp",
"../../modules/audio_coding:audio_coding_module_typedefs",
"../../rtc_base:checks",
"../../rtc_base:deprecation",
"../../rtc_base:divide_round",
"../../rtc_base:gtest_prod",
"../../rtc_base:rate_limiter",
@ -335,7 +333,6 @@ rtc_source_set("rtp_rtcp_legacy") {
"../../api/video:video_bitrate_allocation",
"../../logging:rtc_event_rtp_rtcp",
"../../rtc_base:checks",
"../../rtc_base:deprecation",
"../../rtc_base:gtest_prod",
"../../rtc_base:rtc_base_approved",
"../../rtc_base/synchronization:mutex",

1
modules/rtp_rtcp/include/receive_statistics.h
View file

@ -20,7 +20,6 @@
#include "modules/rtp_rtcp/include/rtcp_statistics.h"
#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
#include "modules/rtp_rtcp/source/rtcp_packet/report_block.h"
#include "rtc_base/deprecation.h"
namespace webrtc {

1
modules/rtp_rtcp/include/rtp_header_extension_map.h
View file

@ -19,7 +19,6 @@
#include "api/rtp_parameters.h"
#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
#include "rtc_base/checks.h"
#include "rtc_base/deprecation.h"
namespace webrtc {

6
modules/rtp_rtcp/include/rtp_rtcp.h
View file

@ -13,9 +13,9 @@
#include <memory>
#include "absl/base/attributes.h"
#include "modules/include/module.h"
#include "modules/rtp_rtcp/source/rtp_rtcp_interface.h"
#include "rtc_base/deprecation.h"
namespace webrtc {
@ -23,8 +23,8 @@ namespace webrtc {
class RtpRtcp : public Module, public RtpRtcpInterface {
public:
// Instantiates a deprecated version of the RtpRtcp module.
static std::unique_ptr<RtpRtcp> RTC_DEPRECATED
Create(const Configuration& configuration) {
static std::unique_ptr<RtpRtcp> ABSL_DEPRECATED("")
Create(const Configuration& configuration) {
return DEPRECATED_Create(configuration);
}

1
modules/rtp_rtcp/source/rtp_packet_received.h
View file

@ -19,7 +19,6 @@
#include "api/rtp_headers.h"
#include "api/scoped_refptr.h"
#include "modules/rtp_rtcp/source/rtp_packet.h"
#include "rtc_base/deprecation.h"
namespace webrtc {
// Class to hold rtp packet with metadata for receiver side.

1
modules/rtp_rtcp/source/rtp_sender.h
View file

@ -29,7 +29,6 @@
#include "modules/rtp_rtcp/source/rtp_packet_history.h"
#include "modules/rtp_rtcp/source/rtp_rtcp_config.h"
#include "modules/rtp_rtcp/source/rtp_rtcp_interface.h"
#include "rtc_base/deprecation.h"
#include "rtc_base/random.h"
#include "rtc_base/rate_statistics.h"
#include "rtc_base/synchronization/mutex.h"

3
modules/video_coding/BUILD.gn
View file

@ -186,7 +186,6 @@ rtc_library("video_coding") {
"../../common_video",
"../../rtc_base",
"../../rtc_base:checks",
"../../rtc_base:deprecation",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:rtc_numerics",
"../../rtc_base:rtc_task_queue",
@ -236,7 +235,6 @@ rtc_library("video_codec_interface") {
"../../api/video_codecs:video_codecs_api",
"../../common_video",
"../../common_video/generic_frame_descriptor",
"../../rtc_base:deprecation",
"../../rtc_base/system:rtc_export",
]
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
@ -487,7 +485,6 @@ rtc_library("webrtc_vp8") {
"../../api/video_codecs:vp8_temporal_layers_factory",
"../../common_video",
"../../rtc_base:checks",
"../../rtc_base:deprecation",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:rtc_numerics",
"../../rtc_base/experiments:cpu_speed_experiment",

5
modules/video_coding/codecs/vp8/include/vp8.h
View file

@ -14,10 +14,10 @@
#include <memory>
#include <vector>
#include "absl/base/attributes.h"
#include "api/video_codecs/video_encoder.h"
#include "api/video_codecs/vp8_frame_buffer_controller.h"
#include "modules/video_coding/include/video_codec_interface.h"
#include "rtc_base/deprecation.h"
namespace webrtc {
@ -40,7 +40,8 @@ class VP8Encoder {
static std::unique_ptr<VideoEncoder> Create();
static std::unique_ptr<VideoEncoder> Create(Settings settings);
RTC_DEPRECATED static std::unique_ptr<VideoEncoder> Create(
ABSL_DEPRECATED("")
static std::unique_ptr<VideoEncoder> Create(
std::unique_ptr<Vp8FrameBufferControllerFactory>
frame_buffer_controller_factory);
};

2
modules/video_coding/deprecated/BUILD.gn
View file

@ -21,7 +21,6 @@ rtc_library("nack_module") {
"../../../api/units:timestamp",
"../../../rtc_base:checks",
"../../../rtc_base:criticalsection",
"../../../rtc_base:deprecation",
"../../../rtc_base:logging",
"../../../rtc_base:macromagic",
"../../../rtc_base:rtc_numerics",
@ -31,4 +30,5 @@ rtc_library("nack_module") {
"../../../system_wrappers:field_trial",
"../../utility",
]
absl_deps = [ "//third_party/abseil-cpp/absl/base:core_headers" ]
}

4
modules/video_coding/deprecated/nack_module.h
View file

@ -17,11 +17,11 @@
#include <set>
#include <vector>
#include "absl/base/attributes.h"
#include "api/units/time_delta.h"
#include "modules/include/module.h"
#include "modules/include/module_common_types.h"
#include "modules/video_coding/histogram.h"
#include "rtc_base/deprecation.h"
#include "rtc_base/numerics/sequence_number_util.h"
#include "rtc_base/synchronization/mutex.h"
#include "rtc_base/thread_annotations.h"
@ -125,7 +125,7 @@ class DEPRECATED_NackModule : public Module {
const absl::optional<BackoffSettings> backoff_settings_;
};
using NackModule = RTC_DEPRECATED DEPRECATED_NackModule;
using NackModule = ABSL_DEPRECATED("") DEPRECATED_NackModule;
} // namespace webrtc

4
modules/video_coding/include/video_codec_interface.h
View file

@ -13,6 +13,7 @@
#include <vector>
#include "absl/base/attributes.h"
#include "absl/types/optional.h"
#include "api/video/video_frame.h"
#include "api/video_codecs/video_decoder.h"
@ -21,7 +22,6 @@
#include "modules/video_coding/codecs/h264/include/h264_globals.h"
#include "modules/video_coding/codecs/vp9/include/vp9_globals.h"
#include "modules/video_coding/include/video_error_codes.h"
#include "rtc_base/deprecation.h"
#include "rtc_base/system/rtc_export.h"
namespace webrtc {
@ -79,7 +79,7 @@ struct CodecSpecificInfoVP9 {
uint8_t num_ref_pics;
uint8_t p_diff[kMaxVp9RefPics];
RTC_DEPRECATED bool end_of_picture;
ABSL_DEPRECATED("") bool end_of_picture;
};
static_assert(std::is_pod<CodecSpecificInfoVP9>::value, "");

2
pc/BUILD.gn
View file

@ -117,7 +117,6 @@ rtc_library("rtc_pc_base") {
"../rtc_base",
"../rtc_base:callback_list",
"../rtc_base:checks",
"../rtc_base:deprecation",
"../rtc_base:rtc_task_queue",
"../rtc_base:socket",
"../rtc_base:socket_address",
@ -289,7 +288,6 @@ rtc_library("peerconnection") {
"../rtc_base",
"../rtc_base:callback_list",
"../rtc_base:checks",
"../rtc_base:deprecation",
"../rtc_base:ip_address",
"../rtc_base:network_constants",
"../rtc_base:rtc_base_approved",

1
pc/peer_connection.h
View file

@ -88,7 +88,6 @@
#include "pc/usage_pattern.h"
#include "rtc_base/checks.h"
#include "rtc_base/copy_on_write_buffer.h"
#include "rtc_base/deprecation.h"
#include "rtc_base/network/sent_packet.h"
#include "rtc_base/rtc_certificate.h"
#include "rtc_base/ssl_certificate.h"

1
pc/session_description.h
View file

@ -37,7 +37,6 @@
#include "pc/media_protocol_names.h"
#include "pc/simulcast_description.h"
#include "rtc_base/checks.h"
#include "rtc_base/deprecation.h"
#include "rtc_base/socket_address.h"
#include "rtc_base/system/rtc_export.h"

9
rtc_base/BUILD.gn
View file

@ -307,10 +307,6 @@ rtc_library("logging") {
frameworks = [ "Foundation.framework" ]
}
# logging.h needs the deprecation header while downstream projects are
# removing code that depends on logging implementation details.
deps += [ ":deprecation" ]
if (is_android) {
libs += [ "log" ]
}
@ -457,10 +453,6 @@ rtc_source_set("type_traits") {
sources = [ "type_traits.h" ]
}
rtc_source_set("deprecation") {
sources = [ "deprecation.h" ]
}
rtc_library("rtc_task_queue") {
visibility = [ "*" ]
sources = [
@ -909,7 +901,6 @@ rtc_library("rtc_base") {
":async_resolver_interface",
":async_socket",
":checks",
":deprecation",
":ip_address",
":network_constants",
":null_socket_server",

45
rtc_base/deprecation.h
View file

@ -1,45 +0,0 @@
/*
* Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#ifndef RTC_BASE_DEPRECATION_H_
#define RTC_BASE_DEPRECATION_H_
// Annotate the declarations of deprecated functions with this to cause a
// compiler warning when they're used. Like so:
//
// RTC_DEPRECATED std::pony PonyPlz(const std::pony_spec& ps);
//
// NOTE 1: The annotation goes on the declaration in the .h file, not the
// definition in the .cc file!
//
// NOTE 2: In order to keep unit testing the deprecated function without
// getting warnings, do something like this:
//
// std::pony DEPRECATED_PonyPlz(const std::pony_spec& ps);
// RTC_DEPRECATED inline std::pony PonyPlz(const std::pony_spec& ps) {
// return DEPRECATED_PonyPlz(ps);
// }
//
// In other words, rename the existing function, and provide an inline wrapper
// using the original name that calls it. That way, callers who are willing to
// call it using the DEPRECATED_-prefixed name don't get the warning.
//
// TODO(kwiberg): Remove this when we can use [[deprecated]] from C++14.
#if defined(_MSC_VER)
// Note: Deprecation warnings seem to fail to trigger on Windows
// (https://bugs.chromium.org/p/webrtc/issues/detail?id=5368).
#define RTC_DEPRECATED __declspec(deprecated)
#elif defined(__GNUC__)
#define RTC_DEPRECATED __attribute__((__deprecated__))
#else
#define RTC_DEPRECATED
#endif
#endif // RTC_BASE_DEPRECATION_H_

6
rtc_base/logging.h
View file

@ -51,10 +51,10 @@
#include <string>
#include <utility>
#include "absl/base/attributes.h"
#include "absl/meta/type_traits.h"
#include "absl/strings/string_view.h"
#include "rtc_base/constructor_magic.h"
#include "rtc_base/deprecation.h"
#include "rtc_base/strings/string_builder.h"
#include "rtc_base/system/inline.h"
@ -434,7 +434,7 @@ class LogMessage {
// DEPRECATED - DO NOT USE - PLEASE USE THE MACROS INSTEAD OF THE CLASS.
// Android code should use the 'const char*' version since tags are static
// and we want to avoid allocating a std::string copy per log line.
RTC_DEPRECATED
ABSL_DEPRECATED("Use RTC_LOG macros instead of accessing this class directly")
LogMessage(const char* file,
int line,
LoggingSeverity sev,
@ -508,7 +508,7 @@ class LogMessage {
// DEPRECATED - DO NOT USE - PLEASE USE THE MACROS INSTEAD OF THE CLASS.
// Android code should use the 'const char*' version since tags are static
// and we want to avoid allocating a std::string copy per log line.
RTC_DEPRECATED
ABSL_DEPRECATED("Use RTC_LOG macros instead of accessing this class directly")
LogMessage(const char* file,
int line,
LoggingSeverity sev,

1
rtc_base/ssl_identity.h
View file

@ -18,7 +18,6 @@
#include <memory>
#include <string>
#include "rtc_base/deprecation.h"
#include "rtc_base/system/rtc_export.h"
namespace rtc {

1
rtc_base/ssl_stream_adapter.h
View file

@ -18,7 +18,6 @@
#include <vector>
#include "absl/memory/memory.h"
#include "rtc_base/deprecation.h"
#include "rtc_base/ssl_certificate.h"
#include "rtc_base/ssl_identity.h"
#include "rtc_base/stream.h"

2
rtc_tools/BUILD.gn
View file

@ -365,7 +365,6 @@ if (!build_with_chromium) {
":chart_proto",
"../api:function_view",
"../api:network_state_predictor_api",
"../rtc_base:deprecation",
"../rtc_base:ignore_wundef",
# TODO(kwiberg): Remove this dependency.
@ -396,6 +395,7 @@ if (!build_with_chromium) {
]
absl_deps = [
"//third_party/abseil-cpp/absl/algorithm:container",
"//third_party/abseil-cpp/absl/base:core_headers",
"//third_party/abseil-cpp/absl/strings",
"//third_party/abseil-cpp/absl/types:optional",
]

10
rtc_tools/rtc_event_log_visualizer/plot_base.h
View file

@ -15,7 +15,7 @@
#include <utility>
#include <vector>
#include "rtc_base/deprecation.h"
#include "absl/base/attributes.h"
#include "rtc_base/ignore_wundef.h"
RTC_PUSH_IGNORING_WUNDEF()
@ -101,8 +101,8 @@ class Plot {
public:
virtual ~Plot() {}
// Deprecated. Use PrintPythonCode() or ExportProtobuf() instead.
RTC_DEPRECATED virtual void Draw() {}
ABSL_DEPRECATED("Use PrintPythonCode() or ExportProtobuf() instead.")
virtual void Draw() {}
// Sets the lower x-axis limit to min_value (if left_margin == 0).
// Sets the upper x-axis limit to max_value (if right_margin == 0).
@ -189,8 +189,8 @@ class PlotCollection {
public:
virtual ~PlotCollection() {}
// Deprecated. Use PrintPythonCode() or ExportProtobuf() instead.
RTC_DEPRECATED virtual void Draw() {}
ABSL_DEPRECATED("Use PrintPythonCode() or ExportProtobuf() instead.")
virtual void Draw() {}
virtual Plot* AppendNewPlot();

7
rtc_tools/rtc_event_log_visualizer/plot_protobuf.h
View file

@ -10,6 +10,7 @@
#ifndef RTC_TOOLS_RTC_EVENT_LOG_VISUALIZER_PLOT_PROTOBUF_H_
#define RTC_TOOLS_RTC_EVENT_LOG_VISUALIZER_PLOT_PROTOBUF_H_
#include "absl/base/attributes.h"
#include "rtc_base/ignore_wundef.h"
RTC_PUSH_IGNORING_WUNDEF()
#include "rtc_tools/rtc_event_log_visualizer/proto/chart.pb.h"
@ -25,10 +26,10 @@ class ProtobufPlot final : public Plot {
void Draw() override;
};
class ProtobufPlotCollection final : public PlotCollection {
class ABSL_DEPRECATED("Use PlotCollection and ExportProtobuf() instead")
ProtobufPlotCollection final : public PlotCollection {
public:
// This class is deprecated. Use PlotCollection and ExportProtobuf() instead.
RTC_DEPRECATED ProtobufPlotCollection();
ProtobufPlotCollection();
~ProtobufPlotCollection() override;
void Draw() override;
Plot* AppendNewPlot() override;

7
rtc_tools/rtc_event_log_visualizer/plot_python.h
View file

@ -10,6 +10,7 @@
#ifndef RTC_TOOLS_RTC_EVENT_LOG_VISUALIZER_PLOT_PYTHON_H_
#define RTC_TOOLS_RTC_EVENT_LOG_VISUALIZER_PLOT_PYTHON_H_
#include "absl/base/attributes.h"
#include "rtc_tools/rtc_event_log_visualizer/plot_base.h"
namespace webrtc {
@ -21,10 +22,10 @@ class PythonPlot final : public Plot {
void Draw() override;
};
class PythonPlotCollection final : public PlotCollection {
class ABSL_DEPRECATED("Use PlotCollection and PrintPythonCode() instead.")
PythonPlotCollection final : public PlotCollection {
public:
// This class is deprecated. Use PlotCollection and PrintPythonCode() instead.
RTC_DEPRECATED explicit PythonPlotCollection(bool shared_xaxis = false);
explicit PythonPlotCollection(bool shared_xaxis = false);
~PythonPlotCollection() override;
void Draw() override;
Plot* AppendNewPlot() override;