mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-14 14:20:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Alias instead of reimplement rtc::RefCountedObject

Browse source 
Mentioned reasons for re-implementing it do not apply when simplest form of aliasing is used.

Bug: webrtc:42225969
Change-Id: If8b51f173faf4c66cde74413f4fbc7c72ad87323
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/366460
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43285}
This commit is contained in:
Danil Chapovalov 2024-10-22 16:26:05 +02:00 committed by WebRTC LUCI CQ
parent 639494be57
commit eba6831300
1 changed files with 2 additions and 48 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
rtc_base/ref_counted_object.h
View file

@ -89,54 +89,8 @@ class FinalRefCountedObject final : public T {
// Backwards compatibe aliases. // Backwards compatibe aliases.
// TODO: https://issues.webrtc.org/42225969 - deprecate and remove. // TODO: https://issues.webrtc.org/42225969 - deprecate and remove.
namespace rtc { namespace rtc {
// Because there are users of this template that use "friend using ::webrtc::FinalRefCountedObject;
// rtc::RefCountedObject<>" to give access to a private destructor, some using ::webrtc::RefCountedObject;
// indirection is needed; "friend" declarations cannot span an "using"
// declaration. Since a templated class on top of a templated class can't access
// the subclass' protected members, we duplicate the entire class instead.
template <class T>
class RefCountedObject : public T {
public:
RefCountedObject() {}
RefCountedObject(const RefCountedObject&) = delete;
RefCountedObject& operator=(const RefCountedObject&) = delete;
template <class P0>
explicit RefCountedObject(P0&& p0) : T(std::forward<P0>(p0)) {}
template <class P0, class P1, class... Args>
RefCountedObject(P0&& p0, P1&& p1, Args&&... args)
: T(std::forward<P0>(p0),
std::forward<P1>(p1),
std::forward<Args>(args)...) {}
void AddRef() const override { ref_count_.IncRef(); }
webrtc::RefCountReleaseStatus Release() const override {
const auto status = ref_count_.DecRef();
if (status == webrtc::RefCountReleaseStatus::kDroppedLastRef) {
delete this;
}
return status;
}
// Return whether the reference count is one. If the reference count is used
// in the conventional way, a reference count of 1 implies that the current
// thread owns the reference and no other thread shares it. This call
// performs the test for a reference count of one, and performs the memory
// barrier needed for the owning thread to act on the object, knowing that it
// has exclusive access to the object.
virtual bool HasOneRef() const { return ref_count_.HasOneRef(); }
protected:
~RefCountedObject() override {}
mutable webrtc::webrtc_impl::RefCounter ref_count_{0};
};
template <typename T>
using FinalRefCountedObject = webrtc::FinalRefCountedObject<T>;
} // namespace rtc } // namespace rtc
#endif // RTC_BASE_REF_COUNTED_OBJECT_H_ #endif // RTC_BASE_REF_COUNTED_OBJECT_H_