mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-12 21:30:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove deprecated version of Vp8FrameBufferControllerFactory::Create

Browse source 
Bug: webrtc:10769
Change-Id: I31de2d21d5325eb4b175815739c2477352842425
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144381
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28448}
This commit is contained in:
Elad Alon 2019-07-02 11:20:23 +02:00 committed by Commit Bot
parent e9d6e658c3
commit ed56cf44b0
3 changed files with 1 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
api/video_codecs/vp8_frame_buffer_controller.h
View file

@ -181,24 +181,10 @@ class Vp8FrameBufferControllerFactory {
virtual std::unique_ptr<Vp8FrameBufferControllerFactory> Clone() const = 0;
// Create a Vp8FrameBufferController instance.
// TODO(bugs.webrtc.org/10769): Update downstream projects, then remove
// version without |fec_controller_override| and make the other version
// pure-virtual.
// (In theory, if neither version is overridden, stack overflow would occur.
// In practice, all subclasses override at least one version, and following
// the update of downstream projects, only one pure-virtual version will
// remain.)
virtual std::unique_ptr<Vp8FrameBufferController> Create(
const VideoCodec& codec,
const VideoEncoder::Settings& settings) {
return Create(codec, settings, nullptr);
}
virtual std::unique_ptr<Vp8FrameBufferController> Create(
const VideoCodec& codec,
const VideoEncoder::Settings& settings,
FecControllerOverride* fec_controller_override) {
return Create(codec, settings);
}
FecControllerOverride* fec_controller_override) = 0;
};
} // namespace webrtc

6
api/video_codecs/vp8_temporal_layers_factory.cc
View file

@ -23,12 +23,6 @@
namespace webrtc {
std::unique_ptr<Vp8FrameBufferController> Vp8TemporalLayersFactory::Create(
const VideoCodec& codec,
const VideoEncoder::Settings& settings) {
return Create(codec, settings, nullptr);
}
std::unique_ptr<Vp8FrameBufferController> Vp8TemporalLayersFactory::Create(
const VideoCodec& codec,
const VideoEncoder::Settings& settings,

5
api/video_codecs/vp8_temporal_layers_factory.h
View file

@ -23,11 +23,6 @@ class Vp8TemporalLayersFactory : public Vp8FrameBufferControllerFactory {
std::unique_ptr<Vp8FrameBufferControllerFactory> Clone() const override;
// TODO(bugs.webrtc.org/10769): Update downstream projects, then remove.
std::unique_ptr<Vp8FrameBufferController> Create(
const VideoCodec& codec,
const VideoEncoder::Settings& settings) override;
std::unique_ptr<Vp8FrameBufferController> Create(
const VideoCodec& codec,
const VideoEncoder::Settings& settings,