From f4dfa1ce0178e70f55dac8fbb23e925f98a5c141 Mon Sep 17 00:00:00 2001 From: Danil Chapovalov Date: Tue, 7 Mar 2023 18:31:07 +0100 Subject: [PATCH] Reassign TODO from self to bug with more context MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit No-try: true Bug: webrtc:14449 Change-Id: Iab1954d4a7a2fd791ad2ac97062ac73d5ce372dd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296581 Commit-Queue: Björn Terelius Auto-Submit: Danil Chapovalov Reviewed-by: Björn Terelius Cr-Commit-Position: refs/heads/main@{#39501} --- logging/rtc_event_log/rtc_event_log_impl.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/logging/rtc_event_log/rtc_event_log_impl.cc b/logging/rtc_event_log/rtc_event_log_impl.cc index 6d855f5e05..31f1e553a0 100644 --- a/logging/rtc_event_log/rtc_event_log_impl.cc +++ b/logging/rtc_event_log/rtc_event_log_impl.cc @@ -112,9 +112,9 @@ bool RtcEventLogImpl::StartLogging(std::unique_ptr output, void RtcEventLogImpl::StopLogging() { RTC_DLOG(LS_INFO) << "Stopping WebRTC event log."; - // TODO(danilchap): Do not block current thread waiting on the task queue. - // It might work for now, for current callers, but disallows caller to share - // threads with the `task_queue_`. + // TODO(bugs.webrtc.org/14449): Do not block current thread waiting on the + // task queue. It might work for now, for current callers, but disallows + // caller to share threads with the `task_queue_`. rtc::Event output_stopped; StopLogging([&output_stopped]() { output_stopped.Set(); }); output_stopped.Wait(rtc::Event::kForever);