mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-20 09:07:52 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Don't signal updated bitrate allocation on encoder paused

Browse source 
If the paced queue gets too long becaused of e.g. encoder overshoot,
the encoder is paused by setting the target bitrate to 0. Don't signal
this 0-bitrate via RTCP TargetBitrate message as the overall target
bitrate is probably unchanged.

Bug: webrtc:9734
Change-Id: I77f23b707a8d4494d0c89fa05005ac1482eace52
Reviewed-on: https://webrtc-review.googlesource.com/99507
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24679}
This commit is contained in:
Erik Språng 2018-09-11 12:37:51 +02:00 committed by Commit Bot
parent 661a0c6b02
commit f4ef2dd532
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
video/video_send_stream_impl.cc
View file

@ -432,7 +432,10 @@ void VideoSendStreamImpl::SignalEncoderTimedOut() {
void VideoSendStreamImpl::OnBitrateAllocationUpdated(
const VideoBitrateAllocation& allocation) {
rtp_video_sender_->OnBitrateAllocationUpdated(allocation);
if (encoder_target_rate_bps_ != 0) {
// Send bitrate allocation metadata only if encoder is not paused.
rtp_video_sender_->OnBitrateAllocationUpdated(allocation);
}
}
void VideoSendStreamImpl::SignalEncoderActive() {